ICEpdf
  1. ICEpdf
  2. PDF-105

Incremental Update of encrypted strings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0 - Beta
    • Fix Version/s: 4.0 - Beta, 4.0
    • Component/s: Core/Parsing
    • Labels:
      None
    • Environment:
      An encrypted PDF document.

      Description

      During testing, Mark identified two areas of concern when writing out encrypted pdf documents.

      NameNode.decryptIfText(Object) :: line 136
      - we create a new StringLiteral when decrypting a name tree node but don't copy the old parent reference neede for encryption.

      URIAction.setURI(String) :: line 87
      - uri was being saved a java.lang.String stead of StringObject.

        Issue Links

          Activity

          Repository Revision Date User Message
          ICEsoft Public SVN Repository #19893 Wed Dec 09 04:36:44 MST 2009 patrick.corless PDF-105 update to insure that we are properly encrypting/decrypting StringObject for URIAction uri and Name nodes.
          Files Changed
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/HexStringObject.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/NameNode.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/LiteralStringObject.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/actions/URIAction.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/StringObject.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #19894 Wed Dec 09 06:07:57 MST 2009 patrick.corless PDF-105 updated String object encryption so make correct call to encrypt/decrypt.
          Files Changed
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/NameNode.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/LiteralStringObject.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/actions/URIAction.java
          Commit graph MODIFY /icepdf/trunk/icepdf/core/src/org/icepdf/core/pobjects/Destination.java
          Patrick Corless created issue -
          Patrick Corless made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s 4.0 - Beta [ 10212 ]
          Hide
          Patrick Corless added a comment -

          The NameNode issue isn't to big a deal as we always save named references as Name object which aren't encrypted. However I did tidy up the code so we don't loose the object reference.

          URIAction issue is definately a bug and would likely result in a URI that would be readable. I've update the code so that the save the URI value back to the URIAction dictionary as a StringObject. Encryption checks are now done on getURI():String call.

          Show
          Patrick Corless added a comment - The NameNode issue isn't to big a deal as we always save named references as Name object which aren't encrypted. However I did tidy up the code so we don't loose the object reference. URIAction issue is definately a bug and would likely result in a URI that would be readable. I've update the code so that the save the URI value back to the URIAction dictionary as a StringObject. Encryption checks are now done on getURI():String call.
          Patrick Corless made changes -
          Link This issue blocks PDF-72 [ PDF-72 ]
          Hide
          Patrick Corless added a comment -

          Updated the the Literal string class to encrypt and decrypt strings as the algorithm isn't symmetric, for some reason I thought is was.

          We are correctly encrypting and decrypting uri actions now but the output is being converted to unicode which is causing problems with reading the saved file.

          Show
          Patrick Corless added a comment - Updated the the Literal string class to encrypt and decrypt strings as the algorithm isn't symmetric, for some reason I thought is was. We are correctly encrypting and decrypting uri actions now but the output is being converted to unicode which is causing problems with reading the saved file.
          Patrick Corless made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Ken Fyten made changes -
          Fix Version/s 4.0 [ 10222 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Patrick Corless
              Reporter:
              Patrick Corless
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: