ICEmobile
  1. ICEmobile
  2. MOBI-759

maven build of samples does not work for binary release bundle

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3 Beta
    • Fix Version/s: 1.3 Final
    • Component/s: Applications
    • Labels:
      None
    • Environment:
      icemobile maven

      Description

      the current maven build structure for sample parents (jsf and jsp) using relative paths does not work for binary release bundle as there is no jsf or jsp directory structure in there.
      The 1.3 Beta1 release src bundle was missing the bundle-parent pom.xml in the icemobile (base) folder, but that has been checked in (after 1.3.0-BETA1 release).

        Activity

        Judy Guglielmin created issue -
        Hide
        Judy Guglielmin added a comment -

        We could add jsf and jsp folders to the binary bundle which just contain the sample parent poms (might be easiest). I am still trying a few other things, but no success so far.

        Show
        Judy Guglielmin added a comment - We could add jsf and jsp folders to the binary bundle which just contain the sample parent poms (might be easiest). I am still trying a few other things, but no success so far.
        Judy Guglielmin made changes -
        Field Original Value New Value
        Assignee Philip Breau [ philip.breau ] Ted Goddard [ ted.goddard ]
        Hide
        Deryk Sinotte added a comment -

        Not sure if I have this right so I'll just summarize what I see as the problem here and someone can correct me where I go off the path....

        • The various pom.xml files under samples/ rely on parent poms in directories that are not directly in their heirarchy. That is:
        jsf/pom.xml
        jsp/pom.xml
        
        samples/jsfsample/pom.xml (relies on parent ../../jsf/pom.xml)
        samples/jspsample/pom.xml (relies on parent ../../jsp/pom.xml)
        • The jsf/pom.xml and jsp/pom.xml have very little to do in the directories that they are currently in. There are no child poms under jsf and there is only one child pom under jsp (jsp/tests/jsptagtest/pom.xml).

        The way it sits right now, it's pretty fragile and fairly un-Mavenish. The right thing to do is have a "permanent" parent pom under the samples directory rather than have the child poms reach across to a directory outside the normal hierarchy (and that disappears when the binary build is constructed). That way it's in the natural directory structure and is always there for the child poms of the samples.

        Since there are 2 flavours of sample applications, there's a couple of ways to potentially do this:

        • The samples could be re-organized by type so they can each have their own parent pom:
        samples/jsf/pom.xml
        samples/jsp/pom.xml
        • A single samples parent pom (samples/pom.xml) could potentially be constructed that utilizes Maven profiles - a profile for JSF examples and a profile for JSP examples.
        Show
        Deryk Sinotte added a comment - Not sure if I have this right so I'll just summarize what I see as the problem here and someone can correct me where I go off the path.... The various pom.xml files under samples/ rely on parent poms in directories that are not directly in their heirarchy. That is: jsf/pom.xml jsp/pom.xml samples/jsfsample/pom.xml (relies on parent ../../jsf/pom.xml) samples/jspsample/pom.xml (relies on parent ../../jsp/pom.xml) The jsf/pom.xml and jsp/pom.xml have very little to do in the directories that they are currently in. There are no child poms under jsf and there is only one child pom under jsp (jsp/tests/jsptagtest/pom.xml). The way it sits right now, it's pretty fragile and fairly un-Mavenish. The right thing to do is have a "permanent" parent pom under the samples directory rather than have the child poms reach across to a directory outside the normal hierarchy (and that disappears when the binary build is constructed). That way it's in the natural directory structure and is always there for the child poms of the samples. Since there are 2 flavours of sample applications, there's a couple of ways to potentially do this: The samples could be re-organized by type so they can each have their own parent pom: samples/jsf/pom.xml samples/jsp/pom.xml A single samples parent pom (samples/pom.xml) could potentially be constructed that utilizes Maven profiles - a profile for JSF examples and a profile for JSP examples.
        Hide
        Judy Guglielmin added a comment -

        I had proposed that exact configuration for 1.2 release and later, but it was not accepted. That would definitely make things much easier, than trying to work with the folder structure the way it is. the sample-jsf-parent and sample-jsp-parent already exist and would be in those 2 locations.
        the parent would then move from icemobile/pom.xml to icemobile/samples/pom.xml
        ...and...none of the poms would need to be modified.

        Show
        Judy Guglielmin added a comment - I had proposed that exact configuration for 1.2 release and later, but it was not accepted. That would definitely make things much easier, than trying to work with the folder structure the way it is. the sample-jsf-parent and sample-jsp-parent already exist and would be in those 2 locations. the parent would then move from icemobile/pom.xml to icemobile/samples/pom.xml ...and...none of the poms would need to be modified.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35849 Tue Jun 04 09:54:01 MDT 2013 judy.guglielmin MOBI-759 new folders and poms for maven build of samples
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/pom.xml
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/pom.xml
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/jsf/pom.xml
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/pom.xml
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/jsp/pom.xml
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/pom.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35850 Tue Jun 04 09:54:58 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobile-jsp
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35851 Tue Jun 04 10:32:22 MDT 2013 judy.guglielmin MOBI-759 new folders and poms for maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/build
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35852 Tue Jun 04 10:32:31 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/build/common-jsp.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35856 Tue Jun 04 10:41:22 MDT 2013 judy.guglielmin MOBI-759 new folders and poms for maven build remove this directory as not needed
        Files Changed
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/build
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35859 Tue Jun 04 10:53:54 MDT 2013 judy.guglielmin MOBI-759 updated poms for jars
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icemobile-jsp.pom
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icemobile-spring.pom
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/README.txt
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icefaces-mobi.pom
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35860 Tue Jun 04 11:00:36 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobilespring
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35881 Tue Jun 04 14:25:34 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/mvc-mediacast
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35902 Tue Jun 04 17:51:23 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mediacast
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35903 Tue Jun 04 17:52:23 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mobileshowcase
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35905 Tue Jun 04 19:07:07 MDT 2013 judy.guglielmin MOBI-759 still a problem with ant build for jsp samples cannot resolve the jar names from dist bundle properties file but mvn and ant builds all deploy and test with new bundle configuration
        Files Changed
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/icemobilespring
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mediacast/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobilespring/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/mvc-mediacast/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mobileshowcase/build.xml
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/mobileshowcase
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icemobile-jsp.pom
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/mvc-mediacast/build.xml
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/mediacast
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mediacast/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icemobile-spring.pom
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobile-jsp/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mobileshowcase/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/build/common.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobile-jsp/pom.xml
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/mvc-mediacast
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/build/common-spring.xml
        Commit graph DEL /icemobile/branches/icemobile-1.3.0/icemobile/samples/icemobile-jsp
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobilespring/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/maven2/icefaces-mobi.pom
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35906 Tue Jun 04 19:09:50 MDT 2013 judy.guglielmin MOBI-759 update tests in other folders to be able to use once jars and sample poms are available on m2 svn repo
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/jsp/tests/jsptagtest/pom.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35910 Wed Jun 05 09:54:36 MDT 2013 judy.guglielmin MOBI-759 had to include properties file from uppermost level so jar names would not have to be redefined.
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mediacast/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/mvc-mediacast/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobilespring/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsp/icemobile-jsp/build.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/build/common.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/build/common-spring.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/mobileshowcase/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35911 Wed Jun 05 10:30:33 MDT 2013 judy.guglielmin MOBI-759 replicate what was done on 1.3.0 branch
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsp
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsf
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35924 Wed Jun 05 11:31:04 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsp/icemobile-jsp
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35926 Wed Jun 05 11:32:49 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsp/icemobilespring
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35927 Wed Jun 05 11:33:22 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsp/mvc-mediacast
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35928 Wed Jun 05 11:35:18 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsf/mediacast
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35929 Wed Jun 05 11:35:44 MDT 2013 judy.guglielmin MOBI-759: move samples to jsf or jsp subfolder to simplify maven build
        Files Changed
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsf/mobileshowcase
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #35931 Wed Jun 05 12:23:37 MDT 2013 judy.guglielmin MOBI-759 for trunk move samples into maven friendly structure and revise ant scripts to match
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/maven2/README.txt
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/mobileshowcase/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/icemobilespring/build.xml
        Commit graph DEL /icemobile/trunk/icemobile/samples/mvc-mediacast
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/icemobile-jsp/build.xml
        Commit graph DEL /icemobile/trunk/icemobile/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/icemobile-jsp/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/build/common-jsf.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/tests/jsptagtest/pom.xml
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsf/pom.xml
        Commit graph ADD /icemobile/trunk/icemobile/samples/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/maven2/icemobile-jsp.pom
        Commit graph DEL /icemobile/trunk/icemobile/samples/mediacast
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/mvc-mediacast/build.xml
        Commit graph DEL /icemobile/trunk/icemobile/samples/mobileshowcase
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/mvc-mediacast/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/maven2/icefaces-mobi.pom
        Commit graph DEL /icemobile/trunk/icemobile/samples/icemobilespring
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/mediacast/build.xml
        Commit graph ADD /icemobile/trunk/icemobile/samples/jsp/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/mediacast/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/build.xml
        Commit graph DEL /icemobile/trunk/icemobile/samples/icemobile-jsp
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/build/common.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/maven2/icemobile-spring.pom
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsp/icemobilespring/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/mobileshowcase/build.xml
        Hide
        Judy Guglielmin added a comment -

        1.3.0 branch rev 35910
        icemobile trunk rev 35931

        Show
        Judy Guglielmin added a comment - 1.3.0 branch rev 35910 icemobile trunk rev 35931
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Ted Goddard [ ted.goddard ] Judy Guglielmin [ judy.guglielmin ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36064 Fri Jun 07 15:03:39 MDT 2013 judy.guglielmin MOBI-759 fixes for myfaces profiles
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/pom.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/pom.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #36065 Fri Jun 07 15:15:01 MDT 2013 judy.guglielmin MOBI-759 fix for my faces profiles
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/jsf/pom.xml
        Commit graph MODIFY /icemobile/branches/icemobile-1.3.0/icemobile/samples/pom.xml

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: