Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.4 Beta
    • Component/s: Faces, Spring
    • Labels:
      None
    • Environment:
      n/a

      Description


      Full review of popup api and impl

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32199 Sun Nov 18 09:01:47 MST 2012 philip.breau MOBI-538 Popup Review
        - add api tests for panelPopup jsf example
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/panelPopup/PanelPopupBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelpopup-example.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32202 Sun Nov 18 10:30:29 MST 2012 philip.breau MOBI-538 Popup Review
        - add api tests for panelPopup jsf example
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/resources/css/showcase.css
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/panelPopup/PanelPopupBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelpopup-example.xhtml
        Migration created issue -
        Hide
        Judy Guglielmin added a comment - - edited

        to have a useful client side panelPopup, need to expose js api. remove the "open" and "close" buttons which were just an initial check to determine that the popup panel would be able to be accessed.
        Original scope of this component did not include client side behaviour.
        removing minHeight and minWidth as not implementing resizable at this time. (doesn't make a lot of sense in mobility sense).
        Implementing width and height if required.
        Would be good to define required behavior of this component rather than specifying what it doesn't do.
        Perhaps it would be good to have an autocenter default to the parent form of the popup, but allow the developer's ability to specify the id of a div they would like the panelpopup to be autocentered to?

        Show
        Judy Guglielmin added a comment - - edited to have a useful client side panelPopup, need to expose js api. remove the "open" and "close" buttons which were just an initial check to determine that the popup panel would be able to be accessed. Original scope of this component did not include client side behaviour. removing minHeight and minWidth as not implementing resizable at this time. (doesn't make a lot of sense in mobility sense). Implementing width and height if required. Would be good to define required behavior of this component rather than specifying what it doesn't do. Perhaps it would be good to have an autocenter default to the parent form of the popup, but allow the developer's ability to specify the id of a div they would like the panelpopup to be autocentered to?
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32288 Thu Nov 22 02:04:05 MST 2012 judy.guglielmin MOBI-546, but disabled only currently working in client. WIll continue with this one.
        MOBI-543, MOBI-542, MOBI-540, MOBI-539, MOBI-538
        Still need to put functional css on wrapper and leave style and style class on container of popup.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.panelpopup/panelpopup.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/panelpopup/PanelPopupMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/panelpopup/PanelPopup.java
        Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/honeycomb/1_modal_panels_ext.css
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/PopupBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/panelpopup/PanelPopupRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelpopup-example.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/component.js
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] User Philip.breau [ philip.breau ]
        Migration made changes -
        Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
        Ted Goddard made changes -
        Fix Version/s 1.3 Beta [ 10373 ]
        Hide
        Ted Goddard added a comment -

        Review component and resolve for 1.3. Additional JIRAs for specific issues can be created if necessary.

        Show
        Ted Goddard added a comment - Review component and resolve for 1.3. Additional JIRAs for specific issues can be created if necessary.
        Judy Guglielmin made changes -
        Fix Version/s 1.4 Beta [ 10874 ]
        Fix Version/s 1.3 Beta [ 10373 ]
        Judy Guglielmin made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Steve Maryka [ steve.maryka ]

          People

          • Assignee:
            Steve Maryka
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: