ICEmobile
  1. ICEmobile
  2. MOBI-527

JSP TabSet not rendering widths on tabs

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.2 Beta
    • Component/s: Faces
    • Labels:
      None
    • Environment:
      n/a

      Description

      The JSP tabset is not rendering the calculated widths on the tabs.

        Activity

        Migration created issue -
        Hide
        Philip Breau added a comment - - edited

        JSP tabs render:
        <div class="mobi-tabset-tabs ">
        ----<ul>
        --------<li style="width:33%;" class="activeTab">Ice Sailer</li>
        --------<li style="width:33%;">Ice Breaker</li>
        --------<li style="width:34%;">Ice Skater</li>
        ----</ul>
        </div>

        JSP tabs render:
        <div class="mobi-tabset-tabs">
        ----<ul data-current="0">
        --------<li id="tabsetOnetab_0" class="activeTab" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this,

        {tIndex: 0}

        );"><span class="mobitab">Desktop</span></li>
        --------<li id="tabsetOnetab_1" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this,

        {tIndex: 1}

        );"><span class="mobitab">Mobile</span></li>
        --------<li id="tabsetOnetab_2" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this,

        {tIndex: 2}

        );"><span class="mobitab">Ultra Mobile</span></li>
        ----</ul>
        </div>

        was:
        The JSP tabset is not rendering the calculated widths on the tabs.

        Show
        Philip Breau added a comment - - edited JSP tabs render: <div class="mobi-tabset-tabs "> ----<ul> --------<li style="width:33%;" class="activeTab">Ice Sailer</li> --------<li style="width:33%;">Ice Breaker</li> --------<li style="width:34%;">Ice Skater</li> ----</ul> </div> JSP tabs render: <div class="mobi-tabset-tabs"> ----<ul data-current="0"> --------<li id="tabsetOnetab_0" class="activeTab" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this, {tIndex: 0} );"><span class="mobitab">Desktop</span></li> --------<li id="tabsetOnetab_1" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this, {tIndex: 1} );"><span class="mobitab">Mobile</span></li> --------<li id="tabsetOnetab_2" onclick="ice.mobi.tabsetController.showContent('tabsetOne', this, {tIndex: 2} );"><span class="mobitab">Ultra Mobile</span></li> ----</ul> </div> was: The JSP tabset is not rendering the calculated widths on the tabs.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32242 Tue Nov 20 01:21:17 MST 2012 judy.guglielmin MOBI-527 for now implement in javascript until core renderer is done and then see if a way to do with tag rendered markup
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/resources/META-INF/icemobile.tld
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/icemobilespring/src/main/webapp/WEB-INF/views/inc/tabset-content.jsp
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/TabSetTag.java
        Hide
        Judy Guglielmin added a comment - - edited

        implemented the autoWidth and checked in updated example. Looks great in large view but must be some application css that is causing the tabs to wrap around on small view .
        may have to review css of either app or component to ensure this attribute renders correctly. Please let me know if this is not the case (on this jira) and re-assign to me if I am missing something. Implemented in javascript for now until core rendering is done and then will see if there is a way using tag class.

        Show
        Judy Guglielmin added a comment - - edited implemented the autoWidth and checked in updated example. Looks great in large view but must be some application css that is causing the tabs to wrap around on small view . may have to review css of either app or component to ensure this attribute renders correctly. Please let me know if this is not the case (on this jira) and re-assign to me if I am missing something. Implemented in javascript for now until core rendering is done and then will see if there is a way using tag class.
        Hide
        Philip Breau added a comment - - edited

        We have MOBI-530 for autoWidth being incompatible with large view themes, if the original bug for this is fixed, please close

        Show
        Philip Breau added a comment - - edited We have MOBI-530 for autoWidth being incompatible with large view themes, if the original bug for this is fixed, please close
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32263 Tue Nov 20 13:46:23 MST 2012 judy.guglielmin MOBI-527 android stock browser and container wrapping when using 100%, all styles are identical to jsf, and can't tell where it's getting an extra padding of 2%. (went right up to pagePanel)..still can't find it. use 98% and the android doesn't wrap and all other devices still look good. When common core rendering is done for tabSet, will relook at this then. (it will become apparent again).
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
        Hide
        Judy Guglielmin added a comment - - edited

        implemented width for style on the list element. (similar to jsf but in js)
        Problem in android stock browser and container (small device) so had to use 98% as there seems to be some padding or margin coming in from somewhere in the spring application that is not in the jsf, although I checked and double-checked all the styles. This will be resolved when go to common core rendering for this component. All other devices and desktop browsers appear good though with this modification.

        Show
        Judy Guglielmin added a comment - - edited implemented width for style on the list element. (similar to jsf but in js) Problem in android stock browser and container (small device) so had to use 98% as there seems to be some padding or margin coming in from somewhere in the spring application that is not in the jsf, although I checked and double-checked all the styles. This will be resolved when go to common core rendering for this component. All other devices and desktop browsers appear good though with this modification.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32308 Thu Nov 22 12:26:58 MST 2012 philip.breau MOBI-527 JSP TabSet not rendering widths on tabs
        - update css
        - fix js not using remainder (was checking for index that didn't exist)
        - return js to dividing by 100
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
        Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/android/1_tabset_ext.css
        Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/iphone/1_tabset_ext.css
        Hide
        Philip Breau added a comment - - edited

        Revision: 32308
        Author: philip.breau
        Date: November-22-12 3:26:58 PM
        Message:
        MOBI-527 JSP TabSet not rendering widths on tabs

        • update css
        • fix js not using remainder (was checking for index that didn't exist)
        • return js to dividing by 100

          Modified : /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
          Modified : /icemobile/trunk/icemobile/resources/themes/android/1_tabset_ext.css
          Modified : /icemobile/trunk/icemobile/resources/themes/iphone/1_tabset_ext.css

        Show
        Philip Breau added a comment - - edited Revision: 32308 Author: philip.breau Date: November-22-12 3:26:58 PM Message: MOBI-527 JSP TabSet not rendering widths on tabs update css fix js not using remainder (was checking for index that didn't exist) return js to dividing by 100 Modified : /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js Modified : /icemobile/trunk/icemobile/resources/themes/android/1_tabset_ext.css Modified : /icemobile/trunk/icemobile/resources/themes/iphone/1_tabset_ext.css
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] User Philip.breau [ philip.breau ]
        Migration made changes -
        Description
        The JSP tabset is not rendering the calculated widths on the tabs.


        The JSP tabset is not rendering the calculated widths on the tabs.
        Migration made changes -
        Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
        Migration made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] User Philip.breau [ philip.breau ]
        Migration made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Migration made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Migration made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Philip Breau made changes -
        Fix Version/s 1.2 Beta [ 10344 ]

          People

          • Assignee:
            Philip Breau
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: