ICEmobile
  1. ICEmobile
  2. MOBI-485

ContentMenuItem rendering 'parent' js argument which isn't used in layoutmenu.js

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.3.1
    • Component/s: Faces
    • Labels:
      None
    • Environment:
      n/a

      Description


      The ContentMenuItem renderer is rendering the argument 'parent' for the js call using the value of the contentNavBar. But this doesn't seemed to be used in the script. We should remove it if it's not needed.


      StringBuilder sb = new StringBuilder("mobi.layoutMenu.showContent('").append(stackClientId);
                          sb.append("', event");
                          sb.append(",{ selectedId: '").append(item.getValue()).append("'");
                          sb.append(",singleSubmit: ").append(item.isSingleSubmit());
                          sb.append(", parent: '").append(navBar.getClientId(facesContext)).append("'");

        Issue Links

          Activity

          Philip Breau made changes -
          Fix Version/s 1.3.1 [ 11376 ]
          Fix Version/s 1.4 Beta [ 10874 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #38344 Wed Oct 02 17:49:25 MDT 2013 philip.breau MOBI-485 ContentMenuItem rendering 'parent' js argument which isn't used in layoutmenu.js
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java
          Philip Breau made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Philip Breau added a comment -

          Revision: 38344
          Author: philip.breau
          Date: October-02-13 8:49:25 PM
          Message:
          MOBI-485 ContentMenuItem rendering 'parent' js argument which isn't used in layoutmenu.js


          Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java

          Show
          Philip Breau added a comment - Revision: 38344 Author: philip.breau Date: October-02-13 8:49:25 PM Message: MOBI-485 ContentMenuItem rendering 'parent' js argument which isn't used in layoutmenu.js Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java
          Philip Breau made changes -
          Assignee Judy Guglielmin [ judy.guglielmin ] Philip Breau [ philip.breau ]
          Hide
          Judy Guglielmin added a comment -

          once client side api is provided for contentStack, there will be no js for contentStackMenu, making this redundant

          Show
          Judy Guglielmin added a comment - once client side api is provided for contentStack, there will be no js for contentStackMenu, making this redundant
          Judy Guglielmin made changes -
          Fix Version/s 1.4 Beta [ 10874 ]
          Fix Version/s 1.3 Beta [ 10373 ]
          Judy Guglielmin made changes -
          Link This issue is duplicated by MOBI-672 [ MOBI-672 ]
          Hide
          Judy Guglielmin added a comment -

          This component is getting totally overhauled for 1.4 Beta with use of mobi:transition and client side api for contentSTack.
          Once that has been completed (see link) this jira will no longer be relevant

          Show
          Judy Guglielmin added a comment - This component is getting totally overhauled for 1.4 Beta with use of mobi:transition and client side api for contentSTack. Once that has been completed (see link) this jira will no longer be relevant
          Steve Maryka made changes -
          Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
          Judy Guglielmin made changes -
          Fix Version/s 1.3 Beta [ 10373 ]
          Fix Version/s 1.2 EE [ 10372 ]
          Philip Breau made changes -
          Fix Version/s 1.2 EE [ 10372 ]
          Fix Version/s 1.2 Final [ 10371 ]
          Philip Breau made changes -
          Fix Version/s 1.2 Final [ 10371 ]
          Fix Version/s 1.2 Beta [ 10344 ]
          Philip Breau made changes -
          Fix Version/s 1.2 Beta [ 10344 ]
          Migration made changes -
          Field Original Value New Value
          Reporter Migration [ remote ] User Philip.breau [ philip.breau ]
          Migration created issue -

            People

            • Assignee:
              Philip Breau
              Reporter:
              Philip Breau
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: