ICEmobile
  1. ICEmobile
  2. MOBI-412

JSP Tab Set Styling issues (was: JSP Tabs have styling issue)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.2 Beta
    • Component/s: Spring
    • Labels:
      None
    • Environment:
      n/a

      Description


      There is application specific styles in the icemobilespring demo that help style the tabs. When these are removed the tabs look broken. All necessary styling for the components should be in the themes and automatically applied without the need for application-level styling.

        Activity

        Migration created issue -
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #32132 Tue Nov 13 10:48:12 MST 2012 judy.guglielmin MOBI-412 patched this up, but still does not have functionality for tabs at bottom. Will require redo of both JSF and JSP tabSet components.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/TabSetTag.java
        Hide
        Judy Guglielmin added a comment - - edited

        to modify the classes is really just a stop gap. Upon reviewing this component, the tabs positioned at the top or the bottom is done strictly in css. The tabs are always rendered first.
        To use a core rendering, it would be best to render them in the flow of where they should be (also, then maybe any browser re-renders with flow may not have the shaking of the buttons?).
        Will patch for now, but when this is done with core renderer so JSP has same ability to put tab headers at bottom, will redo so the tab headers also render at the bottom.

        Show
        Judy Guglielmin added a comment - - edited to modify the classes is really just a stop gap. Upon reviewing this component, the tabs positioned at the top or the bottom is done strictly in css. The tabs are always rendered first. To use a core rendering, it would be best to render them in the flow of where they should be (also, then maybe any browser re-renders with flow may not have the shaking of the buttons?). Will patch for now, but when this is done with core renderer so JSP has same ability to put tab headers at bottom, will redo so the tab headers also render at the bottom.
        Hide
        Judy Guglielmin added a comment - - edited

        done for now. with header top being assumed until redo of JSF and JSP tabSet components such that the tabs are rendered in a correct place and don't rely on css to place them above or below the tabset page contents.

        Show
        Judy Guglielmin added a comment - - edited done for now. with header top being assumed until redo of JSF and JSP tabSet components such that the tabs are rendered in a correct place and don't rely on css to place them above or below the tabset page contents.
        Migration made changes -
        Field Original Value New Value
        Reporter Migration [ remote ] User Philip.breau [ philip.breau ]
        Migration made changes -
        Summary JSP Tabs have styling issue JSP Tab Set Styling issues (was: JSP Tabs have styling issue)
        Migration made changes -
        Assignee Steve Maryka [ steve.maryka ] User Philip.breau [ philip.breau ]
        Migration made changes -
        Fix Version/s 1.2 Beta [ 10344 ]
        Migration made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Philip Breau
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: