ICEmobile
  1. ICEmobile
  2. MOBI-399

Review Accordion CSS

          Details

          • Type: Task Task
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.1 Final
          • Fix Version/s: 1.3 Beta
          • Component/s: Faces, Spring
          • Labels:
            None
          • Environment:
            n/a

            Description


            Review accordion css
            - remove unnecessary cascasing
            - create theme styles that could go into themeroller rules

              Activity

              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32567 Sat Dec 01 15:02:52 MST 2012 judy.guglielmin MOBI-399 remove unnecessary log statement
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32566 Sat Dec 01 14:55:00 MST 2012 judy.guglielmin MOBI-399 ensure that fixedHeight never loses "px" when calculated.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32548 Fri Nov 30 11:19:48 MST 2012 judy.guglielmin MOBI-399 removed unused isFixedHeight var
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32528 Thu Nov 29 16:58:16 MST 2012 judy.guglielmin MOBI-399 try to get rid of disappearing accordion. put timeout around init script as JSF example was not calculating maxHeight on showcase example as div was not ready. remove renderer setting height on content pane wrapper div as it's calculated in the javascript for section.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32516 Thu Nov 29 12:09:45 MST 2012 judy.guglielmin MOBI-399 rename fixedHeight to height attribute renaming
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/icemobilespring/src/main/webapp/WEB-INF/views/inc/accordion-content.jsp
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/resources/META-INF/icemobile.tld
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/IAccordion.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionWithCForEach.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionMeta.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAttributes.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionFixedHeight.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32511 Thu Nov 29 11:34:04 MST 2012 judy.guglielmin MOBI-399 remove style attribute from section element --only goes on contentPane wrp div
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32489 Wed Nov 28 17:06:24 MST 2012 judy.guglielmin MOBI-399 accordion has style attribute applied to wrapper div of contentPane. had to modify example so autoHeight is false.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAttributes.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32484 Wed Nov 28 16:05:39 MST 2012 judy.guglielmin MOBI-399 removed reference from contentPane tags that are now in accordionPaneTag and removed Tei no longer used by carousel
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/ContentPaneTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/ContentTag.java
              Commit graph DEL /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/CarouselItemTei.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32437 Tue Nov 27 16:53:18 MST 2012 judy.guglielmin MOBI-399. Currently JSP version of accordion does not submit the updated selected Id, so unable to test much for values pushed from server -> pretty much strictly client-side component until we allow it to submit it's selected accordionPane.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionTag.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32433 Tue Nov 27 15:36:22 MST 2012 judy.guglielmin MOBI-399 modified code for 1.5 compliance
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32432 Tue Nov 27 15:09:30 MST 2012 judy.guglielmin MOBI-399 for JSF example in mobileshowcase, set contentPanes to server (since dynamically updated via server) for best performance. Ensured updateProperties function is updating all attributes dyamically for proper behavior
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32367 Sun Nov 25 21:20:03 MST 2012 judy.guglielmin MOBI-399 attribute currentId was marked deprecated, but no longer works, so removed it.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/Accordion.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionMeta.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32250 Tue Nov 20 10:03:33 MST 2012 judy.guglielmin MOBI-399 , 449, 442 anything accordion. put paneChangeListener in accordion.jsf test to show it's use->missed layoutBean last time
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32246 Tue Nov 20 09:28:35 MST 2012 judy.guglielmin MOBI-399 , 449, 442 anything accordion. put paneChangeListener in accordion.jsf test to show it's use
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordion.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32191 Fri Nov 16 18:07:58 MST 2012 judy.guglielmin MOBI-399 need check for null in decode...
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32176 Thu Nov 15 22:29:18 MST 2012 judy.guglielmin MOBI-399 , 449, 442 mobileshowcase needs autoHeight to be false in order to have it as default and to use fixedHeight.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32175 Thu Nov 15 21:57:29 MST 2012 judy.guglielmin MOBI-399 , 449, 442 mostly javascript fixes but also came up with strategy to fix hashcode so when client is true, then go back to same panel as server thinks is already selected, the hashcode ensures the script is not wiped out by the domdiff so the update can occur and sync back up the server and client
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/Accordion.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAutoHeight.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/IAccordion.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layoutComponents.html
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordion.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Commit graph ADD /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionFixedHeight.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32142 Tue Nov 13 19:06:53 MST 2012 judy.guglielmin MOBI-399 , 449, 442 clean up and use server side renderer to help save state in between uses for jsf
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionPaneTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32134 Tue Nov 13 11:00:07 MST 2012 judy.guglielmin MOBI-399 , 449, 442 test in mobitest where all contenPanes are client..
              Files Changed
              Commit graph ADD /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAutoHeight.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layoutComponents.html
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32117 Mon Nov 12 14:24:36 MST 2012 judy.guglielmin MOBI-399 , 449, 442 comment out the jsf submit as for some reason (and it shouldn't) JSP tries to process it after the example is out of the veiw (?).
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32100 Sat Nov 10 20:43:10 MST 2012 judy.guglielmin MOBI-399 , 449, 442 and anything related to autoHeight...
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32081 Thu Nov 08 21:39:07 MST 2012 judy.guglielmin MOBI-399 (and all linked jiras to this one). Reworked accordion component using core rendering for both JSF and JSP. Affects ContentPane, Accordion, and ContentStackMenu & contentMenuItem where accordion="true" attribute on the menu. example updated in icemobilespring and examples created and updated in mobitest
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/icemobilespring/src/main/webapp/WEB-INF/views/inc/accordion-content.jsp
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/resources/META-INF/icemobile.tld
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionWithCForEach.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/BaseCoreRenderer.java
              Commit graph ADD /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAttributes.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentstackmenu/ContentStackMenuRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionInMultiRowDataTable.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionInDataTable.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordion.xhtml
              Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/IContentPane.java
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/IResponseWriter.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/TagWriter.java
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/component/IAccordion.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionMeta.java
              Commit graph ADD /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionPaneTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layoutComponents.html
              Commit graph ADD /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPane.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionTag.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneMeta.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/renderkit/ResponseWriterWrapper.java
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #31791 Fri Oct 26 11:31:04 MDT 2012 philip.breau MOBI-399 Review Accordion
              - removing top border for iphone, bb, and android as it looks a little odd
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/iphone/3_accordion.css
              Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/android/2_accordion.css
              Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/bberry/2_accordion.css
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #31468 Mon Oct 15 07:52:50 MDT 2012 philip.breau MOBI-399 Review Accordion CSS
              fix transition-delay (was mistyped 'transition')
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/base3/1_accordion.css

                People

                • Assignee:
                  Philip Breau
                  Reporter:
                  Philip Breau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: