Details
Description
Review accordion css
- remove unnecessary cascasing
- create theme styles that could go into themeroller rules
Activity
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #31468 | Mon Oct 15 07:52:50 MDT 2012 | philip.breau | fix transition-delay (was mistyped 'transition') |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/resources/themes/base3/1_accordion.css
|
Migration
created issue -
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #31791 | Fri Oct 26 11:31:04 MDT 2012 | philip.breau | - removing top border for iphone, bb, and android as it looks a little odd |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/resources/themes/iphone/3_accordion.css
MODIFY /icemobile/trunk/icemobile/resources/themes/android/2_accordion.css MODIFY /icemobile/trunk/icemobile/resources/themes/bberry/2_accordion.css |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32100 | Sat Nov 10 20:43:10 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32117 | Mon Nov 12 14:24:36 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32134 | Tue Nov 13 11:00:07 MST 2012 | judy.guglielmin | |
Files Changed | ||||
ADD
/icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAutoHeight.xhtml
MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layoutComponents.html |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32142 | Tue Nov 13 19:06:53 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionPaneTag.java
MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32176 | Thu Nov 15 22:29:18 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32191 | Fri Nov 16 18:07:58 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32246 | Tue Nov 20 09:28:35 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordion.xhtml
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32250 | Tue Nov 20 10:03:33 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32367 | Sun Nov 25 21:20:03 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/Accordion.java
MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionMeta.java MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32432 | Tue Nov 27 15:09:30 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32433 | Tue Nov 27 15:36:22 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32437 | Tue Nov 27 16:53:18 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/layout/AccordionTag.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32484 | Wed Nov 28 16:05:39 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/ContentPaneTag.java
MODIFY /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/ContentTag.java DEL /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/CarouselItemTei.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32489 | Wed Nov 28 17:06:24 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/accordionAttributes.xhtml
MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32511 | Thu Nov 29 11:34:04 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32528 | Thu Nov 29 16:58:16 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/ContentPaneCoreRenderer.java MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/AccordionCoreRenderer.java |
Migration
made changes -
Field | Original Value | New Value |
---|---|---|
Reporter | Migration [ remote ] | User Philip.breau [ philip.breau ] |
Migration
made changes -
Assignee | Steve Maryka [ steve.maryka ] | User Philip.breau [ philip.breau ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32548 | Fri Nov 30 11:19:48 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
|
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32566 | Sat Dec 01 14:55:00 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.accordion/accordion.js |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #32567 | Sat Dec 01 15:02:52 MST 2012 | judy.guglielmin | |
Files Changed | ||||
MODIFY
/icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
|
Philip Breau
made changes -
Issue Type | Bug [ 1 ] | Task [ 3 ] |
Philip Breau
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Fix Version/s | 1.3 Beta [ 10373 ] | |
Resolution | Fixed [ 1 ] |
Summarized problems with accordion, and working on this one jira (will clos=
e all the others, but fixes will be done on this one as they are all relate=
d).
1) complete domdiff update as before so removed the 'open' and 'closed' cla=
sses from the renderer and put in javascript and re-arranged divs (uses cor=
e renderer, so should not be too difficult to get jsp going once jsf is goo=
d).
2) javascript attempts to update the rule for open and closes with height, =
but new css is much larger and for some reason, it's not able to update the=
rule (could be the @media annotations in css), but since it's not very per=
formant, I went the way to just modifying the divs themselves with the auto=
Height
3) autoHeight cannot be calculated once at initialization since some of the=
divs are empty until that div is selected. (when ui:include is used or fac=
elet=3D"true"), so when it's updated, must re-calculate autoHeight.
4) attributes have changed so tests now must be changed and modifications l=
ike renaming "autoheight" passed in to js as config object to "autoHeight" =
was not propagated through to javascript. Also, changing component attribu=
te to selectId means modification of tests in mobitest as well.
5) tests now first for autoHeight=3D"true'. If so, then calculates autoHei=
ght based on the div height - the calculated height of the handle. (rather=
than 33 which is in the current styling). if autoHeight is false and fixe=
dHeight is set, then that height is set on the divs. This is where the scr=
olling attribute will be set to overflow such that if the fixedHeight does =
not accommodate the content of the div, it will scroll. Still have to test=
the autoHeight =3D false and no fixedHeight set so divs default to whateve=
r their content is. I am not changing the css which has fixed values as th=
at will override anything for the autoHeight=3Dfalse and no fixedHeight...n=
ot sure exactly how this should be dealt with. If they have css which spec=
ifies the height of the div's, should that be the fallback??? _> need clari=
fication on this last point. Should user styling over-ride? Why bother ha=
ving user-defined styling which affect height (transitioning on this attrib=
ute) when we have attributes set to handle them?
=20