ICEmobile
  1. ICEmobile
  2. MOBI-320

NPE thrown when calling UIComponent.findComponent() with empty string id

          Details

          • Type: Bug Bug
          • Status: Resolved
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0 Final
          • Fix Version/s: 1.3.1
          • Component/s: None
          • Labels:
            None
          • Environment:
            ICEfaces 3.1

            Description

            There may be scenarios where a user wants to enclose all content (specifically contentStack/ContentPane) within 1 form tag. Currently the contentStackMenu will only work if a form tag directly surrounds it like so:

            <h:form>
            <h:panelGroup>
            <mobi:contentStackMenu>
            <mobi:contentMenuItem label="Menu" />
            <mobi:contentMenuItem label="Pane 1" value="panel1" />
            .............
            </mobi:contentStackMenu>
            </h:panelGroup>
            </h:form>

            If you were to move the closing form tag to the bottom of the page (below the contentPanes), the following NPE is thrown:

            java.lang.NullPointerException
            at org.icefaces.mobi.component.contentmenuitem.ContentMenuItemRenderer.renderItemAsList(ContentMenuItemRenderer.java:153)
            at org.icefaces.mobi.component.contentmenuitem.ContentMenuItemRenderer.encodeEnd(ContentMenuItemRenderer.java:66)
            at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:875)
            at org.icefaces.mobi.renderkit.BaseLayoutRenderer.renderChild(BaseLayoutRenderer.java:50)
            at org.icefaces.mobi.renderkit.BaseLayoutRenderer.renderChildren(BaseLayoutRenderer.java:35)
            at org.icefaces.mobi.component.contentstackmenu.ContentStackMenuRenderer.encodeEnd(ContentStackMenuRenderer.java:97)
            at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:875)

            Test case demonstrating issue attached. Ready for deployment on Tomcat 7.

              Issue Links

              depends on

              New Feature - A new feature of the product, which has yet to be developed. MOBI-672 Client side api for contentStack using core rendering for JSP as well as JSF implementation

              • Major - Major loss of function.
              • Open

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Judy Guglielmin added a comment -

                work done on MOBI-672 will resolve this.

                Show
                Judy Guglielmin added a comment - work done on MOBI-672 will resolve this.
                Hide
                Permalink
                Philip Breau added a comment -

                Revision: 38315
                Author: philip.breau
                Date: September-30-13 2:16:07 PM
                Message:
                MOBI-836 NPE thrown when calling UIComponent.findComponent() with empty string id

                • guard against all calls to UIComponent.findComponent() with a check for a null or empty string

                  Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/button/CommandButtonRenderer.java
                  Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java
                  Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentstack/ContentStackRenderer.java
                  Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/submitnotification/SubmitNotificationRenderer.java

                Show
                Philip Breau added a comment - Revision: 38315 Author: philip.breau Date: September-30-13 2:16:07 PM Message: MOBI-836 NPE thrown when calling UIComponent.findComponent() with empty string id guard against all calls to UIComponent.findComponent() with a check for a null or empty string Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/button/CommandButtonRenderer.java Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentmenuitem/ContentMenuItemRenderer.java Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/contentstack/ContentStackRenderer.java Modified : /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/submitnotification/SubmitNotificationRenderer.java

                  People

                  • Assignee:
                    Philip Breau
                    Reporter:
                    Tyler Johnson
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: