Details
Description
The resource loading strategy for JSP tags could be improved. Currently, if not using Spring MVC resource mapping the developer must manually include the needed CSS, JavaScript and image resources in the application project structure.
The location of the various tag resources also currently lacks a standard structure. For instance, the iscroll.js resource is located under the JSF component resources, and in the ICEmobile Spring MVC demo. It would be better if there were only one location for this resource.
We may also consider a resource loading utility servlet that could be used in straight JSP (non-Spring MVC) environments, so that users are not forced to manually include the resources in their project structure.
It's also a bit odd that the folder name for the skins is 'org.icefaces.component.skins'. We may want to remove the ICEfaces reference here. I think 'skins' would suffice.
The location of the various tag resources also currently lacks a standard structure. For instance, the iscroll.js resource is located under the JSF component resources, and in the ICEmobile Spring MVC demo. It would be better if there were only one location for this resource.
We may also consider a resource loading utility servlet that could be used in straight JSP (non-Spring MVC) environments, so that users are not forced to manually include the resources in their project structure.
It's also a bit odd that the folder name for the skins is 'org.icefaces.component.skins'. We may want to remove the ICEfaces reference here. I think 'skins' would suffice.
Issue Links
- blocks
-
MOBI-260 Identify Improvements in component implementation strategies for multple platforms.
-
- Closed
-
Activity
Field | Original Value | New Value |
---|---|---|
Assignee | Steve Maryka [ steve.maryka ] | Philip.breau [ philip.breau ] |
Fix Version/s | 1.2 Beta [ 10344 ] |
Summary | JSP Resource Loading Strategy | JSP Resource Loading and Consolidation Strategy |
Comment |
[ In relation to Currently, we have some duplication and overlap with the CSS resources. Source location ***************** jsp\src\main\resources\META-INF\web-resources\org.icefaces.component.skins jsp\src\main\resources\META-INF\web-resources\icemobile.js resources\themes jsf\components\component\resources\org.icefaces.component.util Built ***** CSS resources: icemobile-jsp.jar\META-INF\web-resources\org.icefaces.component.skins\ icefaces-mobi.jar\META-INF\resources\org.icefaces.component.skins\ JS resources: icefaces-mobi.jar\META-INF\resources\org.icefaces.component.util\ combined.js component.js iscroll.js [context root]\resources\org.icefaces.component.util\ iscroll.js ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #30524 | Thu Aug 16 10:59:24 MDT 2012 | philip.breau | - add new resource servlet for jsp resource loading |
Files Changed | ||||
![]() ![]() ![]() ![]() ![]() ![]() ![]() |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #30525 | Thu Aug 16 11:04:55 MDT 2012 | philip.breau | - forgot to remove some sysouts |
Files Changed | ||||
![]() |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #30528 | Thu Aug 16 11:40:50 MDT 2012 | philip.breau | - for spring mvc, fetch jar resources through the default /icemobile-resources path |
Files Changed | ||||
![]() |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #30533 | Thu Aug 16 13:55:27 MDT 2012 | philip.breau | - have jsf build use the shared iscroll.js file |
Files Changed | ||||
![]() ![]() ![]() |
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Revision: 30524
Author: philip.breau
Date: August-16-12 1:59:24 PM
Message:
MOBI-307JSP Resource Loading and Consolidation StrategyAdded : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/servlet
Added : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/servlet/ResourceServlet.java
Modified : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/tags/DeviceResourceTag.java
Added : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/util
Added : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/util/Constants.java
Added : /icemobile/trunk/icemobile/jsp/src/main/java/org/icemobile/jsp/util/Util.java
Modified : /icemobile/trunk/icemobile/samples/icemobilespring/src/main/webapp/WEB-INF/web.xml