ICEmobile
  1. ICEmobile
  2. MOBI-295

mobileshowcase example change of themes disables scrolling of menu in large view

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.1 Beta
          • Fix Version/s: 1.1 Final
          • Component/s: Faces
          • Labels:
            None
          • Environment:
            jsf2 icefaces3 jsf 2

            Description

            When selecting an example on the iPad or desktop browsers, change the theme to Android and the scrolling no longer works on the menu panel.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Patrick Corless added a comment -

              Looks like this is a side effect of MOBI-273 refactoring. The original implementation make an incorrect call:

              window.addEventListener(orientationEvent, resizeElementHeight('#

              {cc.id}

              '), false);

              Where resizeElementHeight is a function. So as Philip noticed resizeElementHeight() would only get called once and not actually get registered as an event listener. The new code addressed the listener assignment by assigning the function to a variable and passing the variable into window.addEventListener().

              The interesting side effect is that resizeElementHeight now only gest called on dom update or on a resize or orientation change. The function should also run on first load to make sure the panel size is correctly calculated.

              Show
              Patrick Corless added a comment - Looks like this is a side effect of MOBI-273 refactoring. The original implementation make an incorrect call: window.addEventListener(orientationEvent, resizeElementHeight('# {cc.id} '), false); Where resizeElementHeight is a function. So as Philip noticed resizeElementHeight() would only get called once and not actually get registered as an event listener. The new code addressed the listener assignment by assigning the function to a variable and passing the variable into window.addEventListener(). The interesting side effect is that resizeElementHeight now only gest called on dom update or on a resize or orientation change. The function should also run on first load to make sure the panel size is correctly calculated.
              Hide
              Permalink
              Patrick Corless added a comment -

              Marking as resolved.

              Show
              Patrick Corless added a comment - Marking as resolved.

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: