Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0 Beta
    • Fix Version/s: 1.1 Final
    • Component/s: Faces, Spring
    • Labels:
      None
    • Environment:
      n/a

      Description

      Carousel is not working in IE9 for both the JSF and JSP tags. Swiping the JSF component appears to change the bottom pager, but the images do not move.

        Activity

        Philip Breau created issue -
        Philip Breau made changes -
        Field Original Value New Value
        Assignee Steve Maryka [ steve.maryka ] Philip.breau [ philip.breau ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30278 Thu Jul 26 13:09:46 MDT 2012 philip.breau MOBI-286 - carousel not working in IE9
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/resources/themes/ipad/default-carousel.css
        Hide
        Philip Breau added a comment -

        Revision: 30278
        Author: philip.breau
        Date: July-26-12 4:09:46 PM
        Message:
        MOBI-286 - carousel not working in IE9


        Modified : /icemobile/trunk/icemobile/resources/themes/ipad/default-carousel.css

        Show
        Philip Breau added a comment - Revision: 30278 Author: philip.breau Date: July-26-12 4:09:46 PM Message: MOBI-286 - carousel not working in IE9 Modified : /icemobile/trunk/icemobile/resources/themes/ipad/default-carousel.css
        Philip Breau made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.1 Beta [ 10320 ]
        Resolution Fixed [ 1 ]
        Hide
        Philip Breau added a comment -

        issue reappears when setting PROJECT_STAGE Production, so it could be related to either CSS or JavaScript minification

        Show
        Philip Breau added a comment - issue reappears when setting PROJECT_STAGE Production, so it could be related to either CSS or JavaScript minification
        Philip Breau made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ted Goddard added a comment -

        Might be worth trying an iScroll update as a fix since that would certainly be in scope for 1.1 Final. Debugging compressed JavaScript is likely out of scope, but could be worth a try for an hour.

        Show
        Ted Goddard added a comment - Might be worth trying an iScroll update as a fix since that would certainly be in scope for 1.1 Final. Debugging compressed JavaScript is likely out of scope, but could be worth a try for an hour.
        Ted Goddard made changes -
        Fix Version/s 1.1 Final [ 10343 ]
        Fix Version/s 1.1 Beta [ 10320 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30351 Wed Aug 01 11:04:28 MDT 2012 judy.guglielmin MOBI-286 test page to show carousel nested in tabSet and contentStack
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/panelStack-tabSet.xhtml
        Hide
        Judy Guglielmin added a comment -

        found this same problem in FF 6.0.2 on Mac OS Lion.
        debug javascript and found an issue in showcase.js
        on line 7 which I changed to
        } else if (body.parentElement && body.parentElement.clientHeight) {

        but this did not fix the issue.

        Noted in mobitest, that carousel examples worked well on the same browser (FF 6.0.2), so went and added carousel into a contentStack and a tabSet within a contentStack. No problem and carousel works.
        Even in mobileshowcase, there are no further javascript errors (other than the one mentioned above which I fixed locally).

        It would appear, that this is specific to either pagePanel or application specific css (as I have tried it within the same configuration in mobitest--but no composite components either so maybe that's a factor?

        page in mobitest/layout/panelStack-tabSet.jsf
        panel1 (of contentStack) with tab panel5 has a carousel and
        panel3 of contentStack has carousel
        Both of these works fine.
        Can someone try it on IE9 to see if this page works there as well?
        Further work may be looked at regarding pagePanel/application css or the composite components used (although I am getting no js or server error)

        Show
        Judy Guglielmin added a comment - found this same problem in FF 6.0.2 on Mac OS Lion. debug javascript and found an issue in showcase.js on line 7 which I changed to } else if (body.parentElement && body.parentElement.clientHeight) { but this did not fix the issue. Noted in mobitest, that carousel examples worked well on the same browser (FF 6.0.2), so went and added carousel into a contentStack and a tabSet within a contentStack. No problem and carousel works. Even in mobileshowcase, there are no further javascript errors (other than the one mentioned above which I fixed locally). It would appear, that this is specific to either pagePanel or application specific css (as I have tried it within the same configuration in mobitest--but no composite components either so maybe that's a factor? page in mobitest/layout/panelStack-tabSet.jsf panel1 (of contentStack) with tab panel5 has a carousel and panel3 of contentStack has carousel Both of these works fine. Can someone try it on IE9 to see if this page works there as well? Further work may be looked at regarding pagePanel/application css or the composite components used (although I am getting no js or server error)
        Hide
        Judy Guglielmin added a comment -

        I downloaded iscroll 4.2 (llatest) and got Cruz to test the sample on IE9 (works). The mobitest page does not.

        Show
        Judy Guglielmin added a comment - I downloaded iscroll 4.2 (llatest) and got Cruz to test the sample on IE9 (works). The mobitest page does not.
        Steve Maryka made changes -
        Assignee Philip.breau [ philip.breau ] Judy Guglielmin [ judy.guglielmin ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30384 Fri Aug 03 13:18:32 MDT 2012 judy.guglielmin MOBI-286 update and support of iscroll v 4.2 libraries
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.carousel/carousel.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/carousel.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/panelStack-tabSet.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/iscroll.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layoutComponents.html
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/carousel/CarouselMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/iscroll-lite.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/carousel/CarouselRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/renderkit/BaseLayoutRenderer.java
        Hide
        Judy Guglielmin added a comment -

        rev 30384 has the new iscroll-4.2 libs checked in and javascript and renderers are modified appropriately. New features include a "next" and "prev" pagination (see mobitest example test page), has "zoom" feature built in
        The pagination features will still have to be styled.
        all mobitest examples pass on Chrome, Safari, IE9 on desktop. and iPhone and iPad.

        mediacast:- problem here is that the upload somehow removes the update script tag. Have to refresh or reload the page to get it back again.

        mobileshowcase:- testing shows that removal of position:absolute; from the contentPane styling makes this work correctly. So Patrick or Phillip I"m sure can come up with something.

        iPad theme seems to be rendering differently this component on desktop browsers and iPad. If I had more time, I would implement a "width" attribute as I think this would help in the rendering (esp IE9).

        Show
        Judy Guglielmin added a comment - rev 30384 has the new iscroll-4.2 libs checked in and javascript and renderers are modified appropriately. New features include a "next" and "prev" pagination (see mobitest example test page), has "zoom" feature built in The pagination features will still have to be styled. all mobitest examples pass on Chrome, Safari, IE9 on desktop. and iPhone and iPad. mediacast:- problem here is that the upload somehow removes the update script tag. Have to refresh or reload the page to get it back again. mobileshowcase:- testing shows that removal of position:absolute; from the contentPane styling makes this work correctly. So Patrick or Phillip I"m sure can come up with something. iPad theme seems to be rendering differently this component on desktop browsers and iPad. If I had more time, I would implement a "width" attribute as I think this would help in the rendering (esp IE9).
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30387 Fri Aug 03 17:03:00 MDT 2012 ted.goddard carousel script element inside carousel region for updates, rebuild iscroll if detached (MOBI-286)
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.carousel/carousel.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/carousel/CarouselRenderer.java
        Hide
        Ted Goddard added a comment -

        Changing mobitest to "Production" breaks the carousel as observed in mediacast earlier.

        A fix for the script update issue is checked in: the script is now a child of the carousel div, causing it to be re-executed if the carousel div is replaced. Further, the iscroll scroller.parent is tested to see if iscroll is still attached to the DOM. If not, it is rebuilt. Likely it needs to be rebuilt every time it is updated, but that requires more change to the code.

        Show
        Ted Goddard added a comment - Changing mobitest to "Production" breaks the carousel as observed in mediacast earlier. A fix for the script update issue is checked in: the script is now a child of the carousel div, causing it to be re-executed if the carousel div is replaced. Further, the iscroll scroller.parent is tested to see if iscroll is still attached to the DOM. If not, it is rebuilt. Likely it needs to be rebuilt every time it is updated, but that requires more change to the code.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30395 Tue Aug 07 09:53:57 MDT 2012 ted.goddard removing iscroll-min.js as it is not a minified version of iscroll.js, it is an unknown previous version (MOBI-286)
        Files Changed
        Commit graph DEL /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/iscroll-min.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/carousel/CarouselRenderer.java
        Hide
        Ted Goddard added a comment -

        Please verify carousel using IE9 in http://labs.icesoft.com/mediacast/mediacast.jsf and close if successful.

        Show
        Ted Goddard added a comment - Please verify carousel using IE9 in http://labs.icesoft.com/mediacast/mediacast.jsf and close if successful.
        Ted Goddard made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Patrick Corless [ patrick.corless ]
        Hide
        Ted Goddard added a comment -

        CarouselRenderer is no longer using iscroll-min.js. This file was out of date and is not minified by our compressor, it was simply checked in. Minification is an optimization that is not strictly necessary.

        Show
        Ted Goddard added a comment - CarouselRenderer is no longer using iscroll-min.js. This file was out of date and is not minified by our compressor, it was simply checked in. Minification is an optimization that is not strictly necessary.
        Hide
        Ted Goddard added a comment -

        Verified working on IE9.

        Show
        Ted Goddard added a comment - Verified working on IE9.
        Ted Goddard made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30406 Wed Aug 08 10:01:48 MDT 2012 philip.breau MOBI-286 - add script delay for FF and IE
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/carousel/CarouselRenderer.java

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: