ICEmobile
  1. ICEmobile
  2. MOBI-251

mobi:ajax execute tests failing

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: Spring 1.0 Alpha
    • Component/s: None
    • Labels:
      None
    • Environment:
      ICEmobile trunk revision #29660
      Chrome19, Firefox13
      (Unable to reproduce on Firefox 3.6)

      Description

      Two tests are failing:
      execute="valueB', render='@all' Test
      and
      execute='valueB valueA',render='@all' Test

      Expected Status = fAjax mobiAjax
      Actual = fAjax

      No errors in the console or on the server.

        Issue Links

          Activity

          Cruz Miraback created issue -
          Cruz Miraback made changes -
          Field Original Value New Value
          Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29887 Mon Jul 09 15:45:40 MDT 2012 judy.guglielmin MOBI-251 modified test page so that button is included in the execute attribute so listener is fired.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/ajax/mobiAjax.xhtml
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/renderkit/CoreRenderer.java
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29889 Mon Jul 09 15:51:51 MDT 2012 judy.guglielmin MOBI-251 fix test for flipswitch
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/ajax/flipswitch.xhtml
          Hide
          Judy Guglielmin added a comment -

          modified test for mobi:ajax such that the button is also included in the execute attribute

          <mobi:ajax execute="@this valueB"......./>

          Show
          Judy Guglielmin added a comment - modified test for mobi:ajax such that the button is also included in the execute attribute <mobi:ajax execute="@this valueB"......./>
          Judy Guglielmin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 1.1 Beta [ 10320 ]
          Resolution Fixed [ 1 ]
          Hide
          Judy Guglielmin added a comment -

          please recheck/test and let me know/open this Jira if there are any further problems.

          Show
          Judy Guglielmin added a comment - please recheck/test and let me know/open this Jira if there are any further problems.
          Judy Guglielmin made changes -
          Assignee Judy Guglielmin [ judy.guglielmin ] Cruz Miraback [ cmiraback ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29909 Tue Jul 10 14:12:52 MDT 2012 judy.guglielmin MOBI-251 cleanup button code and ajaxRequest but still need to fix execute attribute in html5submitFunction
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.util/component.js
          Hide
          Judy Guglielmin added a comment -

          although I (temporarily) fixed the tests for those mobi:ajax tags which did not use @form, @all, or @this for the execute attribute, there still remains a problem here.
          Both f:ajax and ace:ajax modify the execute attribute to include the elementId (similar to @this) that has triggered the ajax event when neither @form, @all or @this is used in the execute attribute.

          This code is used in ICEfaces3 bridge :-

          //ICE-7456: When using singleSubmit, MyFaces does not include the
          // element.name as it does when f:ajax is used. So here
          // we add it if it's a valid value and not there already.
          // The strategy is similar to what Mojarra already does.
          function fixExecuteParameter(execute, element) {
          if (execute && element.name && element.id) {
          var execIds = execute.split(' ');
          for (var i = 0, size = execIds.length; i < size; i++) {
          if (execIds[i] == element.name)

          { return execute; }

          }
          execute = execute + ' ' + element.name;
          }
          return execute;
          }
          ./// from submit.js

          Mobility project uses html5submitFunction(element, event, options) { ....
          in component.js which does not take this in to account.

          Either we need a new strategy or we must implement this same feature in html5submitFunction for mobi:ajax. to ensure the listener gets triggered.

          Show
          Judy Guglielmin added a comment - although I (temporarily) fixed the tests for those mobi:ajax tags which did not use @form, @all, or @this for the execute attribute, there still remains a problem here. Both f:ajax and ace:ajax modify the execute attribute to include the elementId (similar to @this) that has triggered the ajax event when neither @form, @all or @this is used in the execute attribute. This code is used in ICEfaces3 bridge :- // ICE-7456 : When using singleSubmit, MyFaces does not include the // element.name as it does when f:ajax is used. So here // we add it if it's a valid value and not there already. // The strategy is similar to what Mojarra already does. function fixExecuteParameter(execute, element) { if (execute && element.name && element.id) { var execIds = execute.split(' '); for (var i = 0, size = execIds.length; i < size; i++) { if (execIds [i] == element.name) { return execute; } } execute = execute + ' ' + element.name; } return execute; } ./// from submit.js Mobility project uses html5submitFunction(element, event, options) { .... in component.js which does not take this in to account. Either we need a new strategy or we must implement this same feature in html5submitFunction for mobi:ajax. to ensure the listener gets triggered.
          Judy Guglielmin made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Assignee Cruz Miraback [ cmiraback ] Ted Goddard [ ted.goddard ]
          Hide
          Judy Guglielmin added a comment -

          fixed as per MOBI-259

          Show
          Judy Guglielmin added a comment - fixed as per MOBI-259
          Judy Guglielmin made changes -
          Link This issue depends on MOBI-259 [ MOBI-259 ]
          Hide
          Judy Guglielmin added a comment -

          will get verification from qa/Cruz

          Show
          Judy Guglielmin added a comment - will get verification from qa/Cruz
          Judy Guglielmin made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Fix Version/s Spring 1.0 Alpha [ 10334 ]
          Fix Version/s 1.1 Beta [ 10320 ]
          Resolution Fixed [ 1 ]
          Assignee Ted Goddard [ ted.goddard ] Cruz Miraback [ cmiraback ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29929 Wed Jul 11 12:08:46 MDT 2012 judy.guglielmin MOBI-251 changed back ajax calls now that MOBI-259 modifies the execute attribute correctly.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/ajax/mobiAjax.xhtml
          Migration made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Cruz Miraback
              Reporter:
              Cruz Miraback
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: