ICEmobile
  1. ICEmobile
  2. MOBI-196

mobi:ajax support regression on mobi:commandButton

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0 Williams
          • Fix Version/s: EE 1.0 RC1
          • Component/s: None
          • Labels:
            None
          • Environment:
            jsf 2 icefaces 3

            Description

            regression was introduced to mobi:ajax support with introduction of panelConfirmation and submitNotification components
            and was caught with updated tests which include mobi:ajax listener.
            Updated support code and test from ace project for ace:ajax where different and applicable.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #28407 Mon Mar 19 16:39:38 MDT 2012 judy.guglielmin MOBI-196 commandButton testing correctly except for onComplete, onSuccess, onError....so still need to get that working.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/ajax/AjaxBehaviorHandlerMeta.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/ajax/mobiAjax.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/ajax/AjaxBehaviorRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/ajaxComponents.html
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/button/CommandButtonRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.util/component.js
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/java/org/icefaces/mobile/AjaxTestBean.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/ajax/AjaxBehavior.java
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
              Hide
              Permalink
              Judy Guglielmin added a comment - - edited

              also noted that 'onComplete', 'onError' and 'onSuccess' for mobi:ajax also not working correctly, so working on that too.
              This was not adequately tested in previous releases

              noted that code from mobi.AjaxReuqest function(cfg) :-
              ....
              function (onBeforeSubmit, onBeforeUpdate, onAfterUpdate, onNetworkError, onServerError) {
              var context = {};
              onAfterUpdate(function (responseXML) {
              if (cfg.onsuccess && !cfg.onsuccess.call(context, responseXML, null /status/, null /xhr/))

              { return; }

              mobi.AjaxResponse.call(context, responseXML);
              });
              if (cfg.oncomplete) {
              onAfterUpdate(function (responseXML)

              { cfg.oncomplete.call(context, null /*xhr*/, null /*status*/, context.args); }

              );
              }
              if (cfg.onerror) {
              onNetworkError(function (responseCode, errorDescription)

              { cfg.onerror.call(context, null /*xhr*/, responseCode /*status*/, errorDescription /*error description*/) }

              );
              onServerError(function (responseCode, responseText)

              { cfg.onerror.call(context, null /*xhr*/, responseCode /*status*/, responseText /*error description*/) }

              );
              }

              whos that there is a cfg.onerror.call that is not being interpreted correctly. Original ace code has changed considerably and makes us of jquery for the callback,.

              Show
              Judy Guglielmin added a comment - - edited also noted that 'onComplete', 'onError' and 'onSuccess' for mobi:ajax also not working correctly, so working on that too. This was not adequately tested in previous releases noted that code from mobi.AjaxReuqest function(cfg) :- .... function (onBeforeSubmit, onBeforeUpdate, onAfterUpdate, onNetworkError, onServerError) { var context = {}; onAfterUpdate(function (responseXML) { if (cfg.onsuccess && !cfg.onsuccess.call(context, responseXML, null / status /, null / xhr /)) { return; } mobi.AjaxResponse.call(context, responseXML); }); if (cfg.oncomplete) { onAfterUpdate(function (responseXML) { cfg.oncomplete.call(context, null /*xhr*/, null /*status*/, context.args); } ); } if (cfg.onerror) { onNetworkError(function (responseCode, errorDescription) { cfg.onerror.call(context, null /*xhr*/, responseCode /*status*/, errorDescription /*error description*/) } ); onServerError(function (responseCode, responseText) { cfg.onerror.call(context, null /*xhr*/, responseCode /*status*/, responseText /*error description*/) } ); } whos that there is a cfg.onerror.call that is not being interpreted correctly. Original ace code has changed considerably and makes us of jquery for the callback,.
              Hide
              Permalink
              Judy Guglielmin added a comment -

              assigned to Mircea as per Steve's instruction

              Show
              Judy Guglielmin added a comment - assigned to Mircea as per Steve's instruction
              Judy Guglielmin made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Mircea Toma [ mircea.toma ]
              Judy Guglielmin made changes -
              Assignee Mircea Toma [ mircea.toma ] Judy Guglielmin [ judy.guglielmin ]
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Migration made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: