ICEmobile
  1. ICEmobile
  2. MOBI-149

Date/time spinner popup background css class name not correctly set.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0 Beta
    • Fix Version/s: 1.0 Final
    • Component/s: None
    • Labels:
      None
    • Environment:
      Any

      Description

      The date and time spinner components use an empty div with the CSS class name mobi-date-bg to show dark transparent background that hides page content when the spinner popup is visible.

      On first page load the div has no style class and will alter the layout of page in some circumstances because it is in the layout of the page. However when the calendar icon is press to show the popup spinner the style class "mobi-date-bg" dynamically inserted to make the dive appear dark and transparent. And when the dialog is hidden the css class name is then changed to mobi-date.

      Preferred behaviour is as follows:

      1.) Initial style class for the div should by "mobi-date-bg-inv" instead of no style class.
      2.) The style class definition is .mobi-date-bg-inv{ display:none }
      3.) When the popup is made visible the div in question should be given the css class .mobi-date-bg{...}.
      4.) When the popup is hidden the div in question should be given the css class "mobi-date-bg-inv".

      This will insure that the div will truly be invisible and not interrupt page layout. .

        Issue Links

          Activity

          Patrick Corless created issue -
          Patrick Corless made changes -
          Field Original Value New Value
          Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #27344 Tue Jan 24 16:12:31 MST 2012 judy.guglielmin MOBI-149 and missing png for timespinner component.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/ipad/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/honeycomb/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/android/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/bberry/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.datespinner/datespinner.js
          Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/timespinner/iphone/pinstripes.png
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/iphone/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.timespinner/timespinner.js
          Hide
          Judy Guglielmin added a comment -

          rev 27344 contains this fix plus missing png for timespinner (get resource missing error on server).

          Show
          Judy Guglielmin added a comment - rev 27344 contains this fix plus missing png for timespinner (get resource missing error on server).
          Judy Guglielmin made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Judy Guglielmin made changes -
          Link This issue duplicates MOBI-140 [ MOBI-140 ]
          Hide
          John Roll added a comment -

          this is still not working for us (Williams). I still see that <div id="beginDate_bg"> does not have a display:none when I inspect it in Firefox.

          Show
          John Roll added a comment - this is still not working for us (Williams). I still see that <div id="beginDate_bg"> does not have a display:none when I inspect it in Firefox.
          Hide
          John Roll added a comment -

          Here is the contents of MANIFEST.MF of icefaces-mobi.jar I am using:

          Manifest-Version: 1.0
          Ant-Version: Apache Ant 1.7.1
          Created-By: 20.4-b02-402 (Apple Inc.)

          Name: org.icefaces
          Implementation-Title: ICEmobile-Faces Mobile Components
          Implementation-Version: 1.0.0.A-0216
          Build-Number: $

          {build.number}

          Build-Time: 2012-59-16 10:59:21
          Implementation-Vendor: ICEsoft Technologies, Inc.

          Show
          John Roll added a comment - Here is the contents of MANIFEST.MF of icefaces-mobi.jar I am using: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.1 Created-By: 20.4-b02-402 (Apple Inc.) Name: org.icefaces Implementation-Title: ICEmobile-Faces Mobile Components Implementation-Version: 1.0.0.A-0216 Build-Number: $ {build.number} Build-Time: 2012-59-16 10:59:21 Implementation-Vendor: ICEsoft Technologies, Inc.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #27962 Tue Feb 21 14:56:59 MST 2012 patrick.corless MOBI-149 updated the render to default the blackout panel to be hidden. Also update the style class names to be more consistent with other panel based components.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/android/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/iphone/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/honeycomb/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/bberry/default-date.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/ipad/default-date.css
          Hide
          Patrick Corless added a comment -

          The render is not adding the hidden style class on first render for the blackout panel. When the component is shown and hidden the style class is properly inserted. The renderer needs to be touched up to correctly this as the default state should be hidden.

          Show
          Patrick Corless added a comment - The render is not adding the hidden style class on first render for the blackout panel. When the component is shown and hidden the style class is properly inserted. The renderer needs to be touched up to correctly this as the default state should be hidden.
          Patrick Corless made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Patrick Corless added a comment -

          Updated date spinner renderer to correct the class name issue. Will have to check date spinner as well as the other panel type components.

          Show
          Patrick Corless added a comment - Updated date spinner renderer to correct the class name issue. Will have to check date spinner as well as the other panel type components.
          Patrick Corless made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #27970 Wed Feb 22 07:48:53 MST 2012 patrick.corless MOBI-149 updated the time spinner render to default the blackout panel to be hidden. Also update the style class names to be more consistent with other panel based components.
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/iphone/default-time.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/ipad/default-time.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/honeycomb/default-time.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/bberry/default-time.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/android/default-time.css
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
          Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.timespinner/timespinner.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28061 Tue Feb 28 09:13:07 MST 2012 patrick.corless MOBI-149 updated the render to default the blackout panel to be hidden. Also update the style class names to be more consistent with other panel based components.
          Files Changed
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/ipad/default-date.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/bberry/default-date.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/iphone/default-date.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/android/default-date.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/honeycomb/default-date.css
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28063 Tue Feb 28 09:14:30 MST 2012 patrick.corless MOBI-149 updated the time spinner render to default the blackout panel to be hidden. Also update the style class names to be more consistent with other panel based components.
          Files Changed
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/ipad/default-time.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/honeycomb/default-time.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/resources/org.icefaces.component.timespinner/timespinner.js
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/iphone/default-time.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/bberry/default-time.css
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java
          Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/android/default-time.css
          Migration made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Patrick Corless
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: