ICEmobile
  1. ICEmobile
  2. MOBI-1158

mobi:deviceResource android_light theme is loaded for desktop browsers

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE 1.3.1.GA_P03
    • Fix Version/s: EE 1.3.1.GA_P04
    • Component/s: None
    • Labels:
      None
    • Environment:
      Desktop

      Description

      The logic in the deriveTheme() method in CSSUtils causes mobi:deviceResource to load the android_light theme on most desktop browsers. This should be changed to the base theme.

        Issue Links

          Activity

          Arturo Zambrano created issue -
          Arturo Zambrano made changes -
          Field Original Value New Value
          Link This issue blocks ICE-11061 [ ICE-11061 ]
          Arturo Zambrano made changes -
          Assignee Patrick Corless [ patrick.corless ] Arturo Zambrano [ artzambrano ]
          Hide
          Arturo Zambrano added a comment -

          r48970: modified logic in deriveTheme() to load base theme on desktop browsers

          Show
          Arturo Zambrano added a comment - r48970: modified logic in deriveTheme() to load base theme on desktop browsers
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #48970 Wed Jun 22 16:39:31 MDT 2016 art.zambrano MOBI-1158 modified logic in deriveTheme() to load base theme on desktop browsers
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/util/CSSUtils.java
          Hide
          Liana Munroe added a comment -

          Verified ICEmobile trunk r48975. Tomcat 8, IE 11, FF 43, Chrome 51.
          Attaching a screen shot of the base theme of showcasemobile on desktop browser.

          Show
          Liana Munroe added a comment - Verified ICEmobile trunk r48975. Tomcat 8, IE 11, FF 43, Chrome 51. Attaching a screen shot of the base theme of showcasemobile on desktop browser.
          Liana Munroe made changes -
          Attachment autoTheme.PNG [ 22230 ]
          Ken Fyten made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Ken Fyten made changes -
          Fix Version/s EE 1.3.1.GA_P04 [ 12970 ]
          Hide
          Arturo Zambrano added a comment -

          r48981: added a new android_light_desktop theme for desktop browsers, which looks exactly the same as the android_light theme but without the styling that makes dialogs transparent

          Show
          Arturo Zambrano added a comment - r48981: added a new android_light_desktop theme for desktop browsers, which looks exactly the same as the android_light theme but without the styling that makes dialogs transparent
          Arturo Zambrano made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #48981 Fri Jun 24 13:51:36 MDT 2016 art.zambrano MOBI-1158 added a new android_light_desktop theme for desktop browsers, which looks exactly the same as the android_light theme but without the styling that makes dialogs transparent
          Files Changed
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/build.xml
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/2_ui.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_input_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/0_base_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_fieldset_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_accordion_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_modal_panels_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/next.png
          Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/util/CSSUtils.java
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_list_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_date_time_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_tabset_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/back_2x.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_carousel_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/back-active.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/icons-36-white.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/ajax-loader.gif
          Commit graph MODIFY /icemobile/trunk/icemobile/resources/build.xml
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/icons-18-black.png
          Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/deviceresource/DeviceResourceRenderer.java
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/droid-sans.woff
          Commit graph MODIFY /icemobile/trunk/icemobile/samples/jsf/mobileshowcase/src/main/resources/META-INF/resource-dependency.xml
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_button_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/icons-18-white.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/1_flip-switch_ext.css
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/droid-sans-bold.woff
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/icons-36-black.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/back.png
          Commit graph ADD /icemobile/trunk/icemobile/resources/themes/android_light_desktop/spinner.gif
          Hide
          Liana Munroe added a comment -

          Verified icemobile trunk r48986. Tomcat 8, IE edge, 11, 10, FF 43, Chrome 51.

          Show
          Liana Munroe added a comment - Verified icemobile trunk r48986. Tomcat 8, IE edge, 11, 10, FF 43, Chrome 51.

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Arturo Zambrano
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: