[MOBI-1094] Check for theme file name to avoid NPE if no deviceResource tag is present - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.3.1, EE 1.3.1.GA
Fix Version/s: EE 1.3.0.GA_P01
Component/s: Faces
Labels:
None
Environment:
jsf icemobile jsf2

Support Case References:
Support Case 13001 https://icesoft.my.salesforce.com/5007000000kzWeU

Description

NPE occured when redirection to a non-icemobile page which did not have mobi:deviceResource present. the null value should be detected and a theme not loaded instead:-

SEVERE: Error Rendering View[/xhtml/error.xhtml]
java.lang.NullPointerException
        at org.icemobile.util.CSSUtils.getThemeCSSFileName(CSSUtils.java:150)
        at org.icefaces.mobi.component.deviceresource.DeviceResourceRenderer$AddTheme.processEvent(DeviceResourceRenderer.jav
a:382)
        at javax.faces.event.SystemEvent.processListener(SystemEvent.java:106)
        at com.sun.faces.application.ApplicationImpl.processListeners(ApplicationImpl.java:2163)
        at com.sun.faces.application.ApplicationImpl.invokeListenersFor(ApplicationImpl.java:2139)
        at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:303)
        at com.sun.faces.application.ApplicationImpl.publishEvent(ApplicationImpl.java:247)
        at javax.faces.component.UIComponentBase.encodeBegin(UIComponentBase.java:818)
        at javax.faces.component.UIViewRoot.encodeBegin(UIViewRoot.java:954)
        at javax.faces.component.UIComponent.encodeAll(UIComponent.java:1777)
        at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:439)
        at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:124)
        at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:286)
        at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:120)
        at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
        at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139)
        at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594)
        at weblogic.servlet.internal.StubSecurityHelper$ServletServiceAction.run(StubSecurityHelper.java:227)
        at weblogic.servlet.internal.StubSecurityHelper.invokeServlet(StubSecurityHelper.java:125)
        at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:300)
        at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26)
        at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
        at com.icesoft.servlet.MultipartFilter.doFilter(MultipartFilter.java:74)
        at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
        at weblogic.servlet.internal.RequestEventsFilter.doFilter(RequestEventsFilter.java:27)
        at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:56)
        at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.wrapRun(WebAppServletContext.java:3715)
        at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3681)
        at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321)
        at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:120)
        at weblogic.servlet.internal.WebAppServletContext.securedExecute(WebAppServletContext.java:2277)
        at weblogic.servlet.internal.WebAppServletContext.execute(WebAppServletContext.java:2183)
        at weblogic.servlet.internal.ServletRequestImpl.run(ServletRequestImpl.java:1454)
        at weblogic.work.ExecuteThread.execute(ExecuteThread.java:209)
        at weblogic.work.ExecuteThread.run(ExecuteThread.java:178)

Activity

Ascending order - Click to sort in descending order

Judy Guglielmin created issue - 22/Aug/14 10:35 AM

Judy Guglielmin made changes - 22/Aug/14 11:17 AM

Field	Original Value	New Value
Assignee	Steve Maryka [ steve.maryka ]	Philip Breau [ philip.breau ]

Judy Guglielmin made changes - 22/Aug/14 11:18 AM

Fix Version/s

EE 1.3.0.GA_P01 [ 11270 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#42144	Fri Aug 22 15:45:51 MDT 2014	judy.guglielmin	~~MOBI-1094~~. better to have a 404 to load a non-existent css than a NPE. introduce none.css for this purpose.
				Files Changed
				MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/util/CSSUtils.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#42145	Fri Aug 22 15:49:34 MDT 2014	judy.guglielmin	~~MOBI-1094~~
				Files Changed
				MODIFY /icemobile/tags/icemobile-1.3.1_P01/icemobile/core/src/main/java/org/icemobile/util/CSSUtils.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#42147	Fri Aug 22 16:17:19 MDT 2014	judy.guglielmin	~~MOBI-1094~~
				Files Changed
				MODIFY /icemobile/tags/icemobile-1.3.1_P01/icemobile/core/src/main/java/org/icemobile/util/CSSUtils.java

Hide

Permalink

Judy Guglielmin added a comment - 26/Aug/14 8:24 AM

resolved on P01 tag and trunk

Show

Judy Guglielmin added a comment - 26/Aug/14 8:24 AM resolved on P01 tag and trunk

Judy Guglielmin made changes - 26/Aug/14 8:24 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

People

Assignee:

Philip Breau

Reporter:

Judy Guglielmin

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

22/Aug/14 10:35 AM

Updated:

26/Aug/14 8:24 AM

Resolved:

26/Aug/14 8:24 AM