ICEmobile
  1. ICEmobile
  2. MOBI-102

mobi:commandButton move button type specification to a new attribute name

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.0 Beta
          • Fix Version/s: 1.0 Final
          • Component/s: None
          • Labels:
            None
          • Environment:
            any

            Description

            The mobi:commandButton component ues the attribute 'type' to specify the button style type (default, important and attention). This isn't the ideal pratice as the end user can't specify valid html type values (button, submit, img and etc.).

            For final we should probably move a new attribute for button style. I'm thinking buttonType would work well enough.

              Activity

              Ascending order - Click to sort in descending order
              Patrick Corless created issue -
              Steve Maryka made changes -
              Field Original Value New Value
              Assignee Steve Maryka [ steve.maryka ] Patrick Corless [ patrick.corless ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26509 Tue Nov 22 12:52:39 MST 2011 patrick.corless MOBI-102 moved the button type specification off the type attribute and to a new attribute buttonType. This will allows users to use standard html values for type. Also added a disabled style class in the renderer.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/dateSpinnerConverters.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/bberry/default-button.css
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/android/default-button.css
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/numberField.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/CommandButtonMeta.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/development/date/dateEntry.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/CommandButtonRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/dateSpinnerRepeat.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/honeycomb/default-button.css
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/iphone/default-button.css
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/timeSpinner.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/converterInputTest.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/dateSpinnerIscroll.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/inputtextFields.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/CommandButton.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/dateHTML5Field.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/development/date/dateEntry2.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/inputComponents/dateSpinner.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/ipad/default-button.css
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26514 Tue Nov 22 13:38:47 MST 2011 patrick.corless MOBI-102 tweak to button renderer to insure a type=button is used if now type is specified by the user.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/iphone/default-button.css
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/CommandButtonRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/button/ipad/default-button.css
              Hide
              Permalink
              Patrick Corless added a comment -

              Updated the button renderer for the new buttonType attribute. If no type is specified the component will default to "button".

              Show
              Patrick Corless added a comment - Updated the button renderer for the new buttonType attribute. If no type is specified the component will default to "button".
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #26525 Wed Nov 23 11:18:11 MST 2011 patrick.corless MOBI-102 updated showcase with new buttonType attribute.
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/input-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/notification-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/qrcode-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/geolocation-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/dateSpinner-example.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/button-example.xhtml
              Migration made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Patrick Corless
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: