ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-96

Add localization support to Composite Components

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.2.GA_P01
    • Fix Version/s: 1.8.2.GA_P02
    • Component/s: Facelet Components
    • Labels:
      None
    • Environment:
      ICEfaces EE Composite Components

      Description

      A subset of the EE Composite Components have label text used within them that is currently hard-coded to English. All Composite Components should be reviewed and any that use label text internally should be modified to use a standard Java language resource file to provide the ability to easily localize the component by using alternate language resource files.

      1. messages_en.properties
        3 kB
        Carlo Guglielmin
      2. messages_nl.properties
        3 kB
        Marcel Groeneweg
      1. screenshot-1.jpg
        63 kB

        Issue Links

          Activity

          Hide
          Carlo Guglielmin added a comment -

          r23637 - Checked in localization changes for every hardcoded string in the composite components. The German (_de) and Spanish (_es) properties files have all strings, but the newest ones are currently ONLY in English, and will need to be translated over.

          Show
          Carlo Guglielmin added a comment - r23637 - Checked in localization changes for every hardcoded string in the composite components. The German (_de) and Spanish (_es) properties files have all strings, but the newest ones are currently ONLY in English, and will need to be translated over.
          Hide
          Marcel Groeneweg added a comment -

          Hi,

          I will be happy to supply a Dutch translation.
          I guess that ICEpack will not be on the public SVN.
          Where can I get the base resource file so I can translate it into Dutch?
          If I cannot get it myself, please send it to me by email.

          Show
          Marcel Groeneweg added a comment - Hi, I will be happy to supply a Dutch translation. I guess that ICEpack will not be on the public SVN. Where can I get the base resource file so I can translate it into Dutch? If I cannot get it myself, please send it to me by email.
          Hide
          Carlo Guglielmin added a comment - - edited

          Thanks for the offer of a Dutch translation Marcel. Instead of emailing the file I've just attached it here in case any other community members wish to contribute a translation.

          Attached is "messages_en.properties", the current (June 07 2010, revision 23637) messages file for the ICEpack components.

          Show
          Carlo Guglielmin added a comment - - edited Thanks for the offer of a Dutch translation Marcel. Instead of emailing the file I've just attached it here in case any other community members wish to contribute a translation. Attached is "messages_en.properties", the current (June 07 2010, revision 23637) messages file for the ICEpack components.
          Hide
          Marcel Groeneweg added a comment -

          Hi Carlo,

          I think I am missing the tooltip for hiding a column in Rich Data Grid.

          regards,

          Marcel

          Show
          Marcel Groeneweg added a comment - Hi Carlo, I think I am missing the tooltip for hiding a column in Rich Data Grid. regards, Marcel
          Hide
          Marcel Groeneweg added a comment -

          Here is the translated file. Is it possible for me to test the translations before the actual release? Or, could I get a build with the changed XHTMLs and the translation?

          Show
          Marcel Groeneweg added a comment - Here is the translated file. Is it possible for me to test the translations before the actual release? Or, could I get a build with the changed XHTMLs and the translation?
          Hide
          Carlo Guglielmin added a comment -

          Thanks for the translation Marcel. The "Hide Column" text was indeed overlooked, but we'll just get our local Dutch developer to fill that one in.

          I think we'll just run the new bundles through our own internal QA cycle as it's already in place for the Composite Component Showcase. Once everything is good to go we should be updating the live bundle.

          Show
          Carlo Guglielmin added a comment - Thanks for the translation Marcel. The "Hide Column" text was indeed overlooked, but we'll just get our local Dutch developer to fill that one in. I think we'll just run the new bundles through our own internal QA cycle as it's already in place for the Composite Component Showcase. Once everything is good to go we should be updating the live bundle.
          Hide
          Marcel Groeneweg added a comment -

          The component showcase itself does not support Dutch. Or are you going to include Dutch, with English texts for the showcase pages and the translation for the composite components themselves?
          If such a component showcase would be available on icefaces.org, I would really like to see if it all works out, as some texts are larger in Dutch.

          Show
          Marcel Groeneweg added a comment - The component showcase itself does not support Dutch. Or are you going to include Dutch, with English texts for the showcase pages and the translation for the composite components themselves? If such a component showcase would be available on icefaces.org, I would really like to see if it all works out, as some texts are larger in Dutch.
          Hide
          Carlo Guglielmin added a comment - - edited

          I meant the Composite Component Showcase ( http://composite-component-showcase.icefaces.org/ ), which won't have Dutch support for all the descriptive text. It still uses every composite component though which will be internationalized (via your bundle) and testable. The idea is to add Dutch as an available language under the Locale Selector.

          Show
          Carlo Guglielmin added a comment - - edited I meant the Composite Component Showcase ( http://composite-component-showcase.icefaces.org/ ), which won't have Dutch support for all the descriptive text. It still uses every composite component though which will be internationalized (via your bundle) and testable. The idea is to add Dutch as an available language under the Locale Selector.
          Hide
          Marcel Groeneweg added a comment -

          Great! That's what I meant! Will the showcase be updated with each completed fix or only after QA test of the release?

          Show
          Marcel Groeneweg added a comment - Great! That's what I meant! Will the showcase be updated with each completed fix or only after QA test of the release?
          Hide
          Carlo Guglielmin added a comment -

          I imagine we'll update the showcase soon after QA is done with it, although an updated ICEpack bundle might come later since there are other fixes we'll wait for before doing a full release.

          Show
          Carlo Guglielmin added a comment - I imagine we'll update the showcase soon after QA is done with it, although an updated ICEpack bundle might come later since there are other fixes we'll wait for before doing a full release.
          Hide
          Mandeep Hayher added a comment - - edited

          English, German and Spanish look ok. But when Dutch is selected, text is still displayed in English.
          A screenshot is attached.

          Also only Dutch changes are seen on all applicable pages.

          Show
          Mandeep Hayher added a comment - - edited English, German and Spanish look ok. But when Dutch is selected, text is still displayed in English. A screenshot is attached. Also only Dutch changes are seen on all applicable pages.
          Hide
          Mandeep Hayher added a comment -

          repo\icepack\trunk\icepack revision# 23702
          Now Spanish & German language changes are also seen on applicable Pages.
          Also Component names in the Component Tree get updated according to the language selected.

          Show
          Mandeep Hayher added a comment - repo\icepack\trunk\icepack revision# 23702 Now Spanish & German language changes are also seen on applicable Pages. Also Component names in the Component Tree get updated according to the language selected.
          Hide
          Mandeep Hayher added a comment -

          The issue reported earlier where when Dutch was selected the text was still displayed in English, is now fixed too.

          Show
          Mandeep Hayher added a comment - The issue reported earlier where when Dutch was selected the text was still displayed in English, is now fixed too.

            People

            • Assignee:
              Carlo Guglielmin
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: