ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-79

filterTable throws IllegalArgumentException when backing list is empty

          Details

            Description

            If a filterTable list is cleared then it throws the following exception:

            SEVERE: java.lang.IllegalArgumentException: Must provide non-empty list
                    at com.icesoft.faces.facelets.component.table.filter.FilterTableBean.<init>(FilterTableBean.java:45)

            In FilterTableBean class line number 45 it is checking for list size, if it empty it is throwing exception. Instead if list if empty it should not show filters.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Support Case 9051

              Show
              Arran Mccullough added a comment - Support Case 9051
              Arran Mccullough made changes -
              Field Original Value New Value
              Issue Type Bug [ 1 ] Improvement [ 4 ]
              Salesforce Case []
              Brad Kroeger made changes -
              Assignee Brad Kroeger [ brad.kroeger ] Philip Breau [ philip.breau ]
              Arran Mccullough made changes -
              Salesforce Case [5007000000AreRa]
              Patrick Corless made changes -
              Assignee Philip Breau [ philip.breau ] Patrick Corless [ patrick.corless ]
              Patrick Corless made changes -
              Fix Version/s EE-2.0.0.Beta1 [ 10254 ]
              Patrick Corless made changes -
              Fix Version/s EE-2.0.0.Beta2 [ 10256 ]
              Fix Version/s EE-2.0.0.Beta1 [ 10254 ]
              Ken Fyten made changes -
              Fix Version/s EE-2.0.0.Beta1 [ 10254 ]
              Fix Version/s EE-2.0.0 [ 10256 ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2.GA_P03 [ 10253 ]
              Assignee Patrick Corless [ patrick.corless ] Brad Kroeger [ brad.kroeger ]
              Patrick Corless made changes -
              Assignee Brad Kroeger [ brad.kroeger ] Patrick Corless [ patrick.corless ]
              Hide
              Permalink
              Patrick Corless added a comment -

              Fix comprises of adding some null and size checks for the filter data. I didn't make the filters disappear but you can now feed the component an empty list or null and it won't barf.

              SVN -r25723
              IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced.
              /icepack/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java
              /icepack/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java

              Show
              Patrick Corless added a comment - Fix comprises of adding some null and size checks for the filter data. I didn't make the filters disappear but you can now feed the component an empty list or null and it won't barf. SVN -r25723 IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced. /icepack/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java /icepack/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Also made changes to icepack2 composite components. components for JDK 1.5, not currently used but trying to keep the source sinked with compat for now.

              Revision: 25724
              Author: patrick.corless
              Date: 10:12:51 AM, January-13-11
              Message:
              IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced.

              Modified : /icepack2/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java
              Modified : /icepack2/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java

              Show
              Patrick Corless added a comment - Also made changes to icepack2 composite components. components for JDK 1.5, not currently used but trying to keep the source sinked with compat for now. Revision: 25724 Author: patrick.corless Date: 10:12:51 AM, January-13-11 Message: IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced. Modified : /icepack2/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java Modified : /icepack2/trunk/icepack/composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java
              Hide
              Permalink
              Patrick Corless added a comment -

              And finally add the fix to compat components.

              Revision: 25725
              Author: patrick.corless
              Date: 10:14:35 AM, January-13-11
              Message:
              IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced.

              Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java
              Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java

              Show
              Patrick Corless added a comment - And finally add the fix to compat components. Revision: 25725 Author: patrick.corless Date: 10:14:35 AM, January-13-11 Message: IPCK-79 updated bean code to accept a empty or null data list, JDK 1.5 sourced. Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/table/BaseTableBean.java Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/table/filter/FilterTableBean.java
              Hide
              Permalink
              Patrick Corless added a comment -

              Applied to fix to the various locations. Marking as resolved.

              Show
              Patrick Corless added a comment - Applied to fix to the various locations. Marking as resolved.
              Patrick Corless made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Patrick Corless
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: