ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-474

EE Composite Showcase - File Upload cannot handle files containing special characters

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P07
    • Fix Version/s: EE-1.8.2.GA_P08
    • Component/s: Samples
    • Labels:
      None
    • Environment:
      ICEfaces 1.8.2.GA_P07 Build8
      Browser: all
      Server: Tomcat7

      Description

      EE Composite Showcase -> File Upload:
      Files containing special characters are uploaded, but the special characters are altered in the confirmation message rendered on page, and also in the uploaded file on the server.

        Activity

        Carmen Cristurean created issue -
        Carmen Cristurean made changes -
        Field Original Value New Value
        Attachment build8-fileupload.png [ 16164 ]
        Ken Fyten made changes -
        Assignee Ken Fyten [ ken.fyten ] Mark Collette [ mark.collette ]
        Hide
        Mark Collette added a comment -

        Which server OS is this running on, Windows, OS X, Linux, etc?

        Show
        Mark Collette added a comment - Which server OS is this running on, Windows, OS X, Linux, etc?
        Hide
        Carmen Cristurean added a comment -

        Windows 7 Professional.

        Show
        Carmen Cristurean added a comment - Windows 7 Professional.
        Hide
        Mark Collette added a comment -

        I back-ported code from icefaces3 that sets-up the commons-fileupload's characterEncoding based on the HttpServletRequest's characterEncoding, or our parsed from HTTP headers characterEncoding, but both came back null, since the HttpServletRequest is a org.apache.catalina.connector.RequestFacade, and that gave a null characterEncoding, and no "Content-Type" header to parse the "charset" from. Further investigation found the desired "content-type" header (lower case) with the "charset", but only on the regular POSTs and not the file upload POST, so that information was stored in the session in the same place that JSF 1.2+ does, and then retrieved when dealing with the upload.

        icefaces trunk
        Subversion 37233

        Show
        Mark Collette added a comment - I back-ported code from icefaces3 that sets-up the commons-fileupload's characterEncoding based on the HttpServletRequest's characterEncoding, or our parsed from HTTP headers characterEncoding, but both came back null, since the HttpServletRequest is a org.apache.catalina.connector.RequestFacade, and that gave a null characterEncoding, and no "Content-Type" header to parse the "charset" from. Further investigation found the desired "content-type" header (lower case) with the "charset", but only on the regular POSTs and not the file upload POST, so that information was stored in the session in the same place that JSF 1.2+ does, and then retrieved when dealing with the upload. icefaces trunk Subversion 37233
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mark Collette
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: