ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-38

Clean up all threads when shutting down a node or server instance.

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2 Beta
          • Fix Version/s: 1.8.2.GA
          • Component/s: Enterprise Push Server
          • Labels:
            None
          • Environment:
            Tomcat

            Description

            Thread cleanup (mostly noted in Tomcat when using the startup.sh scripts rather than catalina.sh run) still appears to need some investigation to ensure that it's working all the time. It's also important that it is safe on all platforms. The problem seems to affect the push server as well so

              Activity

              Ascending order - Click to sort in descending order
              Deryk Sinotte created issue -
              Hide
              Permalink
              Deryk Sinotte added a comment -

              Noted that during shutdown of timezone-failover, that there could be some threads not being removed gracefully:

              INFO: Servlet Context Name: ICEfaces Tutorial: Timezone Part 2, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967
              Nov 6, 2009 3:41:19 PM com.icesoft.faces.util.event.servlet.ContextEventRepeater contextDestroyed
              INFO: Servlet Context Name: Push Servlet, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967
              Exception in thread "MessageReceiver Thread [1]" java.lang.NullPointerException
              at com.icesoft.net.messaging.jms.JMSSubscriberConnection$MessageReceiver.run(JMSSubscriberConnection.java:418)
              at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
              at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:691)
              at java.lang.Thread.run(Thread.java:619)

              and

              INFO: Servlet Context Name: ICEfaces Tutorial: Timezone Part 2, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967
              Nov 6, 2009 4:21:52 PM com.icesoft.faces.util.event.servlet.ContextEventRepeater contextDestroyed
              INFO: Servlet Context Name: Push Servlet, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967
              Exception in thread "MessageReceiver Thread [1]" java.lang.NoClassDefFoundError: com/icesoft/net/messaging/DefaultMessageService$ReconnectTask
              at com.icesoft.net.messaging.DefaultMessageService.reconnectNow(DefaultMessageService.java:231)
              at com.icesoft.net.messaging.jms.JMSSubscriberConnection$MessageReceiver.run(JMSSubscriberConnection.java:418)
              at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
              at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:691)
              at java.lang.Thread.run(Thread.java:619)

              Show
              Deryk Sinotte added a comment - Noted that during shutdown of timezone-failover, that there could be some threads not being removed gracefully: INFO: Servlet Context Name: ICEfaces Tutorial: Timezone Part 2, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967 Nov 6, 2009 3:41:19 PM com.icesoft.faces.util.event.servlet.ContextEventRepeater contextDestroyed INFO: Servlet Context Name: Push Servlet, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967 Exception in thread "MessageReceiver Thread [1] " java.lang.NullPointerException at com.icesoft.net.messaging.jms.JMSSubscriberConnection$MessageReceiver.run(JMSSubscriberConnection.java:418) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:691) at java.lang.Thread.run(Thread.java:619) and INFO: Servlet Context Name: ICEfaces Tutorial: Timezone Part 2, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967 Nov 6, 2009 4:21:52 PM com.icesoft.faces.util.event.servlet.ContextEventRepeater contextDestroyed INFO: Servlet Context Name: Push Servlet, Server Info: WebLogic Server 10.3 Fri Jul 25 16:30:05 EDT 2008 1137967 Exception in thread "MessageReceiver Thread [1] " java.lang.NoClassDefFoundError: com/icesoft/net/messaging/DefaultMessageService$ReconnectTask at com.icesoft.net.messaging.DefaultMessageService.reconnectNow(DefaultMessageService.java:231) at com.icesoft.net.messaging.jms.JMSSubscriberConnection$MessageReceiver.run(JMSSubscriberConnection.java:418) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:691) at java.lang.Thread.run(Thread.java:619)
              Deryk Sinotte made changes -
              Field Original Value New Value
              Description Thread cleanup (mostly noted in Tomcat when using the startup.sh scripts rather than catalina.sh run) still appears to need some investigation to ensure that it's working all the time. It's also important that it is safe on all platforms.
              		 Thread cleanup (mostly noted in Tomcat when using the startup.sh scripts rather than catalina.sh run) still appears to need some investigation to ensure that it's working all the time. It's also important that it is safe on all platforms. The problem seems to affect the push server as well so
              Jack Van Ooststroom made changes -
              Assignee Ken Fyten [ ken.fyten ] Jack Van Ooststroom [ jack.van.ooststroom ]
              Jack Van Ooststroom made changes -
              Status Open [ 1 ] In Progress [ 3 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              Changed Fix Version(s) to 1.8.2

              Show
              Jack Van Ooststroom added a comment - Changed Fix Version(s) to 1.8.2
              Jack Van Ooststroom made changes -
              Fix Version/s 1.8.2 [ 10201 ]
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The stuck thread issues have been addressed in the following JIRAs:

              Show
              Jack Van Ooststroom added a comment - The stuck thread issues have been addressed in the following JIRAs: http://jira.icefaces.org/browse/ICE-5133 http://jira.icefaces.org/browse/ICE-5134 http://jira.icefaces.org/browse/ICE-5135
              Hide
              Permalink
              Jack Van Ooststroom added a comment -

              The EPS fixes in result to the mentioned JIRAs have been committed as well. Marking this one as FIXED.

              Show
              Jack Van Ooststroom added a comment - The EPS fixes in result to the mentioned JIRAs have been committed as well. Marking this one as FIXED.
              Jack Van Ooststroom made changes -
              Status In Progress [ 3 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Jack Van Ooststroom
                  Reporter:
                  Deryk Sinotte
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: