ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-256

RichDataBooleanRowProperty needs to be set to false in Row Object to allow the row to be editable

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.8.2.GA_P02
          • Fix Version/s: EE-2.0.0
          • Component/s: Samples
          • Labels:
            None
          • Environment:
            All
          • Affects:
            Sample App./Tutorial
          • Workaround Exists:
            Yes
          • Workaround Description:
            Set the editable value associated with the RichDataBooleanRowProperty to false to allow the row to be editable. True to allow the row to be non-editable.

            Description

            Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers.

            Upon review this seems like a logic error in the Composite Showcase app. bean itself (Employee class). The "editable" property on that bean is using "false" to make things editable, and "true" to disable editing. This logic should be reversed in the showcase app code.

            Note that it is important not to change the component logic itself as to avoid breaking backwards compatibility with existing apps.
            1. Java Source File
              Employee.java
              2 kB
              Arran Mccullough
            2. Java Source File
              TestBean.java
              4 kB
              Arran Mccullough

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Arran Mccullough made changes -
              Field Original Value New Value
              Salesforce Case [5007000000GASdR]
              Brad Kroeger made changes -
              Assignee Brad Kroeger [ brad.kroeger ] Ken Fyten [ ken.fyten ]
              Arran Mccullough made changes -
              Attachment Employee.java [ 12924 ]
              Attachment TestBean.java [ 12925 ]
              Ken Fyten made changes -
              Component/s Samples [ 10034 ]
              Component/s Facelet Components [ 10031 ]
              Fix Version/s EE-2.0.0 [ 10256 ]
              Affects [Sample App./Tutorial]
              Assignee Priority P3
              Description Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers. Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers.

              Upon review this seems like a logic error in the Composite Showcase app. bean itself (Employee class). The "editable" property on that bean is using "false" to make things editable, and "true" to disable editing. This logic should be reversed in the showcase app code.

              Note that it is important not to change the component logic itself as to avoid breaking backwards compatibility with existing apps.
              Assignee Ken Fyten [ ken.fyten ] Philip Breau [ philip.breau ]
              Ken Fyten made changes -
              Fix Version/s 1.8.2.GA_P03 [ 10253 ]
              Philip Breau made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.8.2.GA_P03 [ 10253 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]
              Assignee Priority P3

                People

                • Assignee:
                  Philip Breau
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: