Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.8.2.GA_P02
-
Fix Version/s: EE-2.0.0
-
Component/s: Samples
-
Labels:None
-
Environment:All
-
Affects:Sample App./Tutorial
-
Workaround Exists:Yes
-
Workaround Description:Set the editable value associated with the RichDataBooleanRowProperty to false to allow the row to be editable. True to allow the row to be non-editable.
Description
Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers.
Upon review this seems like a logic error in the Composite Showcase app. bean itself (Employee class). The "editable" property on that bean is using "false" to make things editable, and "true" to disable editing. This logic should be reversed in the showcase app code.
Note that it is important not to change the component logic itself as to avoid breaking backwards compatibility with existing apps.
Upon review this seems like a logic error in the Composite Showcase app. bean itself (Employee class). The "editable" property on that bean is using "false" to make things editable, and "true" to disable editing. This logic should be reversed in the showcase app code.
Note that it is important not to change the component logic itself as to avoid breaking backwards compatibility with existing apps.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Salesforce Case | [5007000000GASdR] |
| Assignee | Brad Kroeger [ brad.kroeger ] | Ken Fyten [ ken.fyten ] |
| Attachment | Employee.java [ 12924 ] | |
| Attachment | TestBean.java [ 12925 ] |
| Component/s | Samples [ 10034 ] | |
| Component/s | Facelet Components [ 10031 ] | |
| Fix Version/s | EE-2.0.0 [ 10256 ] | |
| Affects | [Sample App./Tutorial] | |
| Assignee Priority | P3 | |
| Description | Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers. |
Currently the RichDataBooleanRowProperty object uses a "false" value to allow rows to be editable. This should be "true" as this can cause confusion for developers. Upon review this seems like a logic error in the Composite Showcase app. bean itself (Employee class). The "editable" property on that bean is using "false" to make things editable, and "true" to disable editing. This logic should be reversed in the showcase app code. Note that it is important not to change the component logic itself as to avoid breaking backwards compatibility with existing apps. |
| Assignee | Ken Fyten [ ken.fyten ] | Philip Breau [ philip.breau ] |
| Fix Version/s | 1.8.2.GA_P03 [ 10253 ] |
This seems to be resolved in the ICEfaces EE 2.0 beta release.
Show
Arran Mccullough
added a comment - This seems to be resolved in the ICEfaces EE 2.0 beta release.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | 1.8.2.GA_P03 [ 10253 ] | |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
| Assignee Priority | P3 |
The more I think about it the more I think this isn't an issue with the RichDataBooleanRowProperty but with the RichDataGridBean object. Possibly there is an issue in the row selection logic. No matter what the row object editable value is called setting it to true should allow it to be editable and false should be non-editable.