Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-2.0.0.Alpha1
-
Fix Version/s: EE-2.0.0.Beta1
-
Component/s: Core Extensions
-
Labels:None
-
Environment:ICEfaces 2, both compat and regular
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration
Description
<h:panelGrid columns="1">
<center>
<h:inputText .../>
</center>
</h:panelGrid>
You might think that the <center> tag will be a component which is the only child of the <h:panelGrid>, and the parent of the <h:inputText>, but what will instead happen is that <h:panelGrid> will have 3 children: a UIInstructions child corresponding to the opening <center> tag, the <h:inputText>, and a UIInstructions child corresponding to the closing </center> tag.
The h:panelGrid component will then render each if it's children into a separate <TD> tag, which will confuse the browser, since the starting <center> will be in a separate <TD> then the ending </center>. This is illustrated here: http://jira.icefaces.org/browse/ICE-5735
In ICEfaces 1.8.x and before, we had code that specifically made the HTML tags become like components, instead of becoming UIInstructions, so that they would behave as expected. This jira is for replicating that functionality into ICEfaces 2.
This is a jira for some of that previous work: http://jira.icefaces.org/browse/ICE-1092
These are the relevant classes:
com.icesoft.faces.facelets.UIXhtmlTagLibrary
com.icesoft.faces.facelets.UIXhtmlTagDecorator
com.icesoft.faces.facelets.UIXhtmlComponentHandler
com.icesoft.faces.component.UIXhtmlComponent
Issue Links
- blocks
-
ICE-5323
Regression: ICE-3147 not working as expected
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
Not all extension points are available in JSF 2.0, but a similar technique should be possible:
com.icesoft.faces.facelets.UIXhtmlTagLibrary
- not available
com.icesoft.faces.facelets.UIXhtmlTagDecorator
- can implement javax.faces.view.facelets.TagDecorator
com.icesoft.faces.facelets.UIXhtmlComponentHandler
- The API javax.faces.view.facelets.ComponentHandler is present but no longer provides the key method createComponent() (instead this is handled by Application.createComponent())
com.icesoft.faces.component.UIXhtmlComponent
- Custom components can easily be added in JSF 2.0
A test application is also required that clearly illustrates this feature is working (or not) for QA to adopt as a future regression test.
Attached test page requires no backing bean.
Implementation has been checked in and verified. Application requires addition of icefaces-xhtml.jar to benefit from this feature.
The attached test page can function with no backing beans. Mandeep, please use this to create a test case. The test passes when the optional icefaces-xhtml.jar is present if a value of "1" is displayed in the outputText.
To enable this feature will require the following added to web.xml:
<context-param>
<param-name>javax.faces.FACELETS_DECORATORS</param-name>
<param-value>com.icesoft.facelets.HtmlTagDecorator</param-value>
</context-param>
Checked in to icefaces-ee.
The test case is failing on ICEfaces2 trunk revision# 23981.
NOTE: The test case was seen passing around Icefaces # 23929
Tested by adding test.xhtml and the FACELETS_DECORATORS to a sample application and the "1" was displayed as expected.
The feature was working in my test, could you verify the test case?
Icefaces-ee2 revision# 26294
Icefaces2 revision# 23983
Server: Tomcat6
Browser: FF3.6, IE7 & googlechrome8
Application tested successfully.
Need a feasibility assessment for this.