ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-201

Updated tabView to use the new ace component

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-2.0.0.Alpha1
    • Fix Version/s: EE-2.0.0
    • Component/s: Facelet Components
    • Labels:
      None
    • Environment:
      JSF 2.0, ICEfaces 2.0

      Description

      In a move to remove the yui dependences in the cc's the last step is to migrate the tab components to use the new ace component. This should allow us to remove the yui libraries from the cc jar.

      Just to be clear the driving force behind this is that yui is used by the ace components and if an application is allready loading the yui libraries we get into a namespace and loadding issue with the different instances of the library.

        Activity

        Patrick Corless created issue -
        Patrick Corless made changes -
        Field Original Value New Value
        Salesforce Case []
        Component/s Facelet Components [ 10031 ]
        Fix Version/s EE-2.0.0.Beta1 [ 10254 ]
        Affects Version/s EE-2.0.0.Alpha1 [ 10260 ]
        Hide
        Patrick Corless added a comment -

        It turns out that the richTabs and tabView components are are now working correctly as is now that the yui libraries have been removed. I would still like to replace the main demo tabset with the new ace tabset but will wait and see how the new file upload component works in the existing setup.

        Following commit for the removal of the remaining yui dependencies.

        Revision: 25830
        Author: patrick.corless
        Date: 10:20:25 AM, January-20-11
        Message:
        IPCK-201 removed remaining yui libraries which get the cc tabset working again.


        Modified : /icepack2/trunk/icepack/compat-composite-components/conf/faces-config.xml
        Modified : /icepack2/trunk/icepack/compat-composite-components/conf/tld/icecc.tld
        Deleted : /icepack2/trunk/icepack/compat-composite-components/resources/js/yui_2.8.0r4
        Deleted : /icepack2/trunk/icepack/compat-composite-components/resources/js/yui_3.0.0
        Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/ResourceLoadingComponent.java
        Modified : /icepack2/trunk/icepack/compat-composite-components/web/theme/_inlineCSS.xhtml

        Show
        Patrick Corless added a comment - It turns out that the richTabs and tabView components are are now working correctly as is now that the yui libraries have been removed. I would still like to replace the main demo tabset with the new ace tabset but will wait and see how the new file upload component works in the existing setup. Following commit for the removal of the remaining yui dependencies. Revision: 25830 Author: patrick.corless Date: 10:20:25 AM, January-20-11 Message: IPCK-201 removed remaining yui libraries which get the cc tabset working again. Modified : /icepack2/trunk/icepack/compat-composite-components/conf/faces-config.xml Modified : /icepack2/trunk/icepack/compat-composite-components/conf/tld/icecc.tld Deleted : /icepack2/trunk/icepack/compat-composite-components/resources/js/yui_2.8.0r4 Deleted : /icepack2/trunk/icepack/compat-composite-components/resources/js/yui_3.0.0 Modified : /icepack2/trunk/icepack/compat-composite-components/src/com/icesoft/faces/facelets/component/ResourceLoadingComponent.java Modified : /icepack2/trunk/icepack/compat-composite-components/web/theme/_inlineCSS.xhtml
        Hide
        Patrick Corless added a comment -

        I was also planning to remove the old 1.8.2 compat tabset but as it turns out there are two many differences with theming etc to make the change worth while. The file upload component works as expect.

        Show
        Patrick Corless added a comment - I was also planning to remove the old 1.8.2 compat tabset but as it turns out there are two many differences with theming etc to make the change worth while. The file upload component works as expect.
        Patrick Corless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Reopening this JIRA as the actual task of migrating to the ace:tabSet has not been accomplished.

        Show
        Ken Fyten added a comment - Reopening this JIRA as the actual task of migrating to the ace:tabSet has not been accomplished.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Ken Fyten [ ken.fyten ] Patrick Corless [ patrick.corless ]
        Ken Fyten made changes -
        Salesforce Case []
        Fix Version/s EE-2.0.0 [ 10256 ]
        Fix Version/s EE-2.0.0.Beta1 [ 10254 ]
        Ken Fyten made changes -
        Assignee Patrick Corless [ patrick.corless ] Brad Kroeger [ brad.kroeger ]
        Hide
        Brad Kroeger added a comment -

        Removing Rich Tab from the title, it does not use YUI

        Show
        Brad Kroeger added a comment - Removing Rich Tab from the title, it does not use YUI
        Brad Kroeger made changes -
        Summary Updated tabView and Rich tab to use the new ace component Updated tabView to use the new ace component
        Salesforce Case []
        Hide
        Brad Kroeger added a comment -

        Revision: 27159

        Remove YUI javascript and CSS references in faces-config. Component now wraps ace:tabSet

        Show
        Brad Kroeger added a comment - Revision: 27159 Remove YUI javascript and CSS references in faces-config. Component now wraps ace:tabSet
        Brad Kroeger made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Brad Kroeger
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: