ICEfaces
  1. ICEfaces
  2. ICE-9974

ice:selectOneRadio causes error when attempting to submit form in IE7

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P01
          • Fix Version/s: EE-3.3.0.GA_P02
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            Any
          • Assignee Priority:
            P2

            Description

            Whenever trying to submit a form that contains an ice:selectOneRadio component, a Javascript error appears in the console, and the from cannot be submitted. The error that appears is the following:

            SCRIPT5007: Unable to get property 'indexOf' of undefined or null reference
            File: jsf.js.jsf, Line: 1, Column: 14523

            This was initially reported in ICE-9731, as the Rich Text demo of the component-showcase app was failing. It was found that the problem was with ice:selectOneRadio. To reproduce, simply go to the Rich Text demo in component-showcase and click on the save button of the editor or try to select a different option in the radio control. This can also be reproduced in the Extended Components > Selection demo by trying to enter any value in any component. These issues don't occur when removing the ice:selectOneRadio components from the pages.

              Activity

              Ascending order - Click to sort in descending order
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Description Whenever trying to submit a form that contains an ice:selectOneRadio component, a Javascript error appears in the console, and the from cannot be submitted. The error that appears is the following:

              {noformat}
              SCRIPT5007: Unable to get property 'indexOf' of undefined or null reference
              File: jsf.js.jsf, Line: 1, Column: 14523
              {noformat}

              This was initially reported in ICE-9731, as the Rich Text demo of the component-showcase app was failing. It was found that the problem was with ice:selectOneRadio. To reproduce, simply go to the Rich Text demo in component-showcase and click on the save button of the editor or try to select a different option in the radio control. This can also be reproduced in the Extended Components > Selection demo by trying to enter any value in any component. These issues don't occur when removing the ice:selectOneRadio components from the pages.               		Whenever trying to submit a form that contains an ice:selectOneRadio component, a Javascript error appears in the console, and the from cannot be submitted. The error that appears is the following:

              SCRIPT5007: Unable to get property 'indexOf' of undefined or null reference
              File: jsf.js.jsf, Line: 1, Column: 14523

              This was initially reported in ICE-9731, as the Rich Text demo of the component-showcase app was failing. It was found that the problem was with ice:selectOneRadio. To reproduce, simply go to the Rich Text demo in component-showcase and click on the save button of the editor or try to select a different option in the radio control. This can also be reproduced in the Extended Components > Selection demo by trying to enter any value in any component. These issues don't occur when removing the ice:selectOneRadio components from the pages.
              Ken Fyten made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Assignee Priority P2 [ 10011 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              The fix adds 'name' attribute to the submitting fieldset element to avoid JS error in Mojarra bridge. Mojarra is trying to access the 'name' attribute when serialising the form.

              Show
              Mircea Toma added a comment - The fix adds 'name' attribute to the submitting fieldset element to avoid JS error in Mojarra bridge. Mojarra is trying to access the 'name' attribute when serialising the form.
              Mircea Toma made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Re-opening issue.

              ICE-9970 was re-opened, reporting this same issue on IE9/10. Upon closer inspection on this JIRA and on subversion, it seems that there were no commits related to this fix.

              Show
              Arturo Zambrano added a comment - Re-opening issue. ICE-9970 was re-opened, reporting this same issue on IE9/10. Upon closer inspection on this JIRA and on subversion, it seems that there were no commits related to this fix.
              Arturo Zambrano made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Commit #40822 which modifies SelectManyCheckboxListRenderer is the one that fixes this issue. The fix is for the maintenance branch only.

              Show
              Mircea Toma added a comment - - edited Commit #40822 which modifies SelectManyCheckboxListRenderer is the one that fixes this issue. The fix is for the maintenance branch only.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Reopening this JIRA because of this comment in http://jira.icesoft.org/browse/ICE-9970
              "2) IE9/10: JS error when entering text and click Save icon:
              Message: Unable to get value of the property 'indexOf': object is null or undefined
              Line: 43
              Char: 9
              Code: 0
              URI: http://10.18.39.149:8080/component-showcase/javax.faces.resource/ckeditor_ext.js.jsf?ln=inputrichtext
              This issue is not related to this JIRA. It's the same as ICE-9974. Marking this JIRA (ICE-9970) as fixed."

              Issue is present in Component showcase Icefaces ee-3.3.0 IE only
              RichText Demo
              IE9/10: JS error when entering text and click Save icon:
              Message: Unable to get value of the property 'indexOf': object is null or undefined
              Line: 43
              Char: 9
              Code: 0
              URI: http://10.18.39.149:8080/component-showcase/javax.faces.resource/ckeditor_ext.js.jsf?ln=inputrichtext

              Show
              Liana Munroe added a comment - Reopening this JIRA because of this comment in http://jira.icesoft.org/browse/ICE-9970 "2) IE9/10: JS error when entering text and click Save icon: Message: Unable to get value of the property 'indexOf': object is null or undefined Line: 43 Char: 9 Code: 0 URI: http://10.18.39.149:8080/component-showcase/javax.faces.resource/ckeditor_ext.js.jsf?ln=inputrichtext This issue is not related to this JIRA. It's the same as ICE-9974 . Marking this JIRA (ICE-9970) as fixed." Issue is present in Component showcase Icefaces ee-3.3.0 IE only RichText Demo IE9/10: JS error when entering text and click Save icon: Message: Unable to get value of the property 'indexOf': object is null or undefined Line: 43 Char: 9 Code: 0 URI: http://10.18.39.149:8080/component-showcase/javax.faces.resource/ckeditor_ext.js.jsf?ln=inputrichtext
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Adding a 'name' attribute to the fieldset element fixed the issue just in HTML5 pages. In non-HTML5 pages the fieldset does not have the name attribute defined in IE since it's not in the spec, hence the error when trying to call indexOf function on an undefined object.

              Show
              Mircea Toma added a comment - Adding a 'name' attribute to the fieldset element fixed the issue just in HTML5 pages. In non-HTML5 pages the fieldset does not have the name attribute defined in IE since it's not in the spec, hence the error when trying to call indexOf function on an undefined object.
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified RadioRenderer and SelectManyCheckboxListRenderer to stop using "fieldset" element for grouping the input elements, thus avoding triggering the JS error when Mojarra bridge tries to serialise the fieldset element.

              Show
              Mircea Toma added a comment - Modified RadioRenderer and SelectManyCheckboxListRenderer to stop using "fieldset" element for grouping the input elements, thus avoding triggering the JS error when Mojarra bridge tries to serialise the fieldset element.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Confirmed fixed Icefaces ee-3.3.0 maintenance branch r40876. IE, 7,8, 9, 10, 11. Tomcat 7.

              Show
              Liana Munroe added a comment - Confirmed fixed Icefaces ee-3.3.0 maintenance branch r40876. IE, 7,8, 9, 10, 11. Tomcat 7.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: