ICEfaces
  1. ICEfaces
  2. ICE-9952

Styling of showcase examples problematic in Liferay 6.2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01, 4.0.BETA
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      Liferay 6.2
    • Assignee Priority:
      P1

      Description

      While there have always been some relatively minor styling conflicts between our showcase portlet examples and Liferay, the current version (Liferay 6.2 and ICEfaces 4.0 Beta) is significant.

        Activity

        Deryk Sinotte created issue -
        Hide
        Deryk Sinotte added a comment -

        Putting all portlets in a single column prevents most of the styling issues but, as seen in the screen snapshot, once multiple columns are enabled, the layout and styling makes the portlets nearly impossible to use.

        Show
        Deryk Sinotte added a comment - Putting all portlets in a single column prevents most of the styling issues but, as seen in the screen snapshot, once multiple columns are enabled, the layout and styling makes the portlets nearly impossible to use.
        Deryk Sinotte made changes -
        Field Original Value New Value
        Attachment liferay62-styling.png [ 17011 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Fix Version/s 4.0 [ 11382 ]
        Assignee Priority P1 [ 10010 ]
        Ken Fyten made changes -
        Assignee Priority P1 [ 10010 ] P2 [ 10011 ]
        Deryk Sinotte made changes -
        Affects Version/s EE-3.3.0.GA_P01 [ 11174 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Hide
        Arturo Zambrano added a comment - - edited

        Are there any CSS style class naming specifications for portlet applications? I ask this because the main issue (examples having more width than they should) can simply be fixed by changing a style class name in our component showcase facelets. In main-template.xhtml we only need to change the 'container' class name to something else, like 'ice-container' (and of course change the name in the CSS file as well). It seems that Liferay 6.2 is using a class named 'container' as well for their UI, which happens to be the same name we're using. So, if there's no requirement to name CSS style classes in a certain way we can simply change this class name.

        Show
        Arturo Zambrano added a comment - - edited Are there any CSS style class naming specifications for portlet applications? I ask this because the main issue (examples having more width than they should) can simply be fixed by changing a style class name in our component showcase facelets. In main-template.xhtml we only need to change the 'container' class name to something else, like 'ice-container' (and of course change the name in the CSS file as well). It seems that Liferay 6.2 is using a class named 'container' as well for their UI, which happens to be the same name we're using. So, if there's no requirement to name CSS style classes in a certain way we can simply change this class name.
        Hide
        Deryk Sinotte added a comment -

        The Portlet specifications (http://download.oracle.com/otn-pub/jcp/portlet-2.0-edr-oth-JSpec/portlet-2_0-edr.pdf) do outline a few CSS style naming guidelines but they are fairly basic and all names start with "portlet-" so in this case, container should be find to change.

        Show
        Deryk Sinotte added a comment - The Portlet specifications ( http://download.oracle.com/otn-pub/jcp/portlet-2.0-edr-oth-JSpec/portlet-2_0-edr.pdf ) do outline a few CSS style naming guidelines but they are fairly basic and all names start with "portlet-" so in this case, container should be find to change.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #41223 Tue May 27 15:22:23 MDT 2014 art.zambrano ICE-9952 renamed container CSS class name, in order to avoid conflicts with Liferay 6.2
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase-portlet/src/main/webapp/resources/templates/main-template.xhtml
        Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase-portlet/src/main/webapp/resources/ice.samples.showcase/demo_template.css
        Hide
        Arturo Zambrano added a comment -

        Committed fix to 4.0 trunk at revision 41223 and to 3.3 EE maintenance branch at revision 41222. Renamed 'container' CSS class name to 'ice-container' in the portlet showcase, in order to avoid conflicts with Liferay 6.2.

        Show
        Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 41223 and to 3.3 EE maintenance branch at revision 41222. Renamed 'container' CSS class name to 'ice-container' in the portlet showcase, in order to avoid conflicts with Liferay 6.2.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Deryk Sinotte added a comment -

        Confirm that this looks much better now and that portlets are usable in multicolumn layouts.

        Show
        Deryk Sinotte added a comment - Confirm that this looks much better now and that portlets are usable in multicolumn layouts.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: