Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.0
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Any
-
Support Case References:Support Case #12884 - https://icesoft.my.salesforce.com/5007000000dBcLq
Description
The recent update to CKEditor 4.3.3 (ICE-9731) comes with only one editor skin, which is different than the three skins that we previously had with versions 3.6.6.1 and earlier. It would be nice to offer some additional skins for the editor. There are some skins offered as add-ons on the CKEditor website:
http://ckeditor.com/addons/skins/all
http://ckeditor.com/addons/skins/all
Issue Links
- depends on
-
ICE-9731
Update CKEditor to version 4.3
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Arturo Zambrano [ artzambrano ] |
| Support Case References | Support Case #12884 - https://icesoft.my.salesforce.com/5007000000dBcLq |
| Fix Version/s | 4.0 [ 11382 ] | |
| Fix Version/s | EE-3.3.0.GA_P03 [ 11572 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #42056 | Thu Jul 31 16:37:42 MDT 2014 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/richtextentry/richTextEntryOverview.xhtml
|
Well done. I suggest change also default skin from moono to moonocolor or moonoblue.
They look much better.
BTW. In showcase skin change directly in richTextEntryOverview.xhtml didn't work until showcase restart.
Show
Krashan Brahmanjara
added a comment - Well done. I suggest change also default skin from moono to moonocolor or moonoblue.
They look much better.
BTW. In showcase skin change directly in richTextEntryOverview.xhtml didn't work until showcase restart.
According to QA, the console is logging the following as a result of the new skins:
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/moono-dark/readme.md. To resolve this, add a mime-type mapping to the applications web.xml. Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/moono-dark/readme.md. To resolve this, add a mime-type mapping to the applications web.xml. Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/readme.md. To resolve this, add a mime-type mapping to the applications web.xml. Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/readme.md. To resolve this, add a mime-type mapping to the applications web.xml. Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/scss/browser-specific/gecko/editor_gecko.scss. To resolve this, add a mime-type mapping to the applications web.xml. Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/scss/browser-specific/gecko/editor_gecko.scss. To resolve this, add a mime-type mapping to the applications web.xml.......
So it may be necessary to either remove the files if they are not needed or add these types to the showcase web.xml file:
<mime-mapping>
<extension>md</extension>
<mime-type>text/x-markdown</mime-type>
</mime-mapping>
<mime-mapping>
<extension>scss</extension>
<mime-type>text/css</mime-type>
</mime-mapping>
Show
Deryk Sinotte
added a comment - According to QA, the console is logging the following as a result of the new skins:
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/moono-dark/readme.md. To resolve this, add a mime-type mapping to the applications web.xml.
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/moono-dark/readme.md. To resolve this, add a mime-type mapping to the applications web.xml.
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/readme.md. To resolve this, add a mime-type mapping to the applications web.xml.
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/readme.md. To resolve this, add a mime-type mapping to the applications web.xml.
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/scss/browser-specific/gecko/editor_gecko.scss. To resolve this, add a mime-type mapping to the applications web.xml.
Aug 05, 2014 11:41:21 AM com.sun.faces.context.ExternalContextImpl getMimeType
WARNING: JSF1091: No mime type could be found for file richtextentry/ckeditor/skins/bootstrapck/scss/browser-specific/gecko/editor_gecko.scss. To resolve this, add a mime-type mapping to the applications web.xml.......
So it may be necessary to either remove the files if they are not needed or add these types to the showcase web.xml file:
<mime-mapping>
<extension>md</extension>
<mime-type>text/x-markdown</mime-type>
</mime-mapping>
<mime-mapping>
<extension>scss</extension>
<mime-type>text/css</mime-type>
</mime-mapping>
Also the documentation should be updated to reflect the new set of skins that are available:
Show
Deryk Sinotte
added a comment - Also the documentation should be updated to reflect the new set of skins that are available:
http://www.icesoft.org/wiki/display/ICE/RichTextEntry
Krashan Brahmanjara I was able to change the skin attribute in the page and simply reload in the browser. No restart required. Perhaps you need to force reload to avoid the cache.
Show
Deryk Sinotte
added a comment - Krashan Brahmanjara I was able to change the skin attribute in the page and simply reload in the browser. No restart required. Perhaps you need to force reload to avoid the cache.
| Fix Version/s | EE-4.0.0.GA [ 11171 ] | |
| Fix Version/s | 4.0 [ 11382 ] | |
| Fix Version/s | EE-3.3.0.GA_P03 [ 11572 ] |
Server warnings are no longer seen. ICEfaces 4 trunk r42880. Tomcat 7, IE 11, FF 31, Chrome 37.
Show
Liana Munroe
added a comment - Server warnings are no longer seen. ICEfaces 4 trunk r42880. Tomcat 7, IE 11, FF 31, Chrome 37.
| Fix Version/s | 4.0 [ 11382 ] | |
| Fix Version/s | EE-4.0.0.GA [ 11171 ] |
Assigned to Art for 4.0 to update richTextEntry wiki docs to indicate additional skins.
Updated wiki docs for ace:richTextEntry to include the new skins in ICEfaces 4.0, also updated URLs for the CKEditor 4.3.3 API and keyboard shortcuts.
Show
Arturo Zambrano
added a comment - Updated wiki docs for ace:richTextEntry to include the new skins in ICEfaces 4.0, also updated URLs for the CKEditor 4.3.3 API and keyboard shortcuts.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Added 6 CKEditor skins to the 4.0 trunk at revision 42055. The new skins are moonocolor, moonodark, moonoblue, office2013, kama, and bootstrap.
For the purposes of the 4.0 release, this JIRA can be considered resolved.