ICEfaces
  1. ICEfaces
  2. ICE-9943

Several Ace components use a faulty findComponent method that does not search into facets

          Details

            Description

            When using an ace:tooltip that references an ace:delegate for an ace:dataTable, the tooltip can't find the delegate defined for it and throws the following error:

            Cannot find delegate component "tooltipDelegate" in view or it is not an instance of <ace:tooltipDelegate>.

            The components are located in a mobi:pagePanel. Removing the mobi component, the error is no longer thrown.

              Activity

              Ascending order - Click to sort in descending order
              Arran Mccullough created issue -
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case source code that shows the issue. War file is larger than 10mb so can be provided on request.

              Show
              Arran Mccullough added a comment - Attached test case source code that shows the issue. War file is larger than 10mb so can be provided on request.
              Arran Mccullough made changes -
              Field Original Value New Value
              Attachment Case12719Example2.zip [ 17006 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Fix Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Philip Breau [ philip.breau ]
              Philip Breau made changes -
              Summary ace:tooltip - Can't use ace:delegate in a mobi:pagePanel Several Ace component use a faulty findComponent method
              Philip Breau made changes -
              Summary Several Ace component use a faulty findComponent method Several Ace components use a faulty findComponent method that does not search into facets
              Hide
              Permalink
              Philip Breau added a comment - - edited

              I've fixed the toolTipRenderer in the IF 3.3 EE maintenance branch, but the root issue was that the toolTip component was not searching into facet children and thus, couldn't see within the PagePanel, which uses <f:facet>. But this problem would have shown up with the use of any facet, not just with the PagePanel.

              I haven't closed this, and widened the scope of it, as it appears that the same findComponentCustom() method is copied in several other Ace components, and will have the same issue:

              ContextMenu
              DataExporter
              Dialog
              Droppable

              We should look into this a bit more and possibly change all of these to use CoreComponentUtils.findComponentInView(), if suitable, and remove all of the duplicated code.

              Show
              Philip Breau added a comment - - edited I've fixed the toolTipRenderer in the IF 3.3 EE maintenance branch, but the root issue was that the toolTip component was not searching into facet children and thus, couldn't see within the PagePanel, which uses <f:facet>. But this problem would have shown up with the use of any facet, not just with the PagePanel. I haven't closed this, and widened the scope of it, as it appears that the same findComponentCustom() method is copied in several other Ace components, and will have the same issue: ContextMenu DataExporter Dialog Droppable We should look into this a bit more and possibly change all of these to use CoreComponentUtils.findComponentInView(), if suitable, and remove all of the duplicated code.
              Philip Breau made changes -
              Assignee Philip Breau [ philip.breau ] Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40721 Fri Apr 04 18:24:15 MDT 2014 art.zambrano ICE-9943 replaced occurrences of findComponentCustom() for CoreComponentUtils.findComponentInView(); removed findComponentCustom() implementations
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dnd/DroppableRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dataexporter/DataExporter.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tooltip/TooltipRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/dialog/DialogRenderer.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/contextmenu/ContextMenuRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Replaced occurrences of findComponentCustom() for CoreComponentUtils.findComponentInView() and removed findComponentCustom() implementations.

              Committed fix to 4.0 trunk at revision 40721 and to 3.3 EE maintenance branch at revision 40722.

              Show
              Arturo Zambrano added a comment - Replaced occurrences of findComponentCustom() for CoreComponentUtils.findComponentInView() and removed findComponentCustom() implementations. Committed fix to 4.0 trunk at revision 40721 and to 3.3 EE maintenance branch at revision 40722.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Issue found in Showcase > Context Menu> Overview (All browsers) r40726.
              Left clicking anywhere on the page to dismiss a context menu only works the first time. When you subsequently right click to get another context menu, a left click will not dismiss it. This is not the case when you are left clicking on a menu item, it only happens when you are left clicking outside of the menu.

              Show
              Liana Munroe added a comment - Issue found in Showcase > Context Menu> Overview (All browsers) r40726. Left clicking anywhere on the page to dismiss a context menu only works the first time. When you subsequently right click to get another context menu, a left click will not dismiss it. This is not the case when you are left clicking on a menu item, it only happens when you are left clicking outside of the menu.
              Liana Munroe made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Affects Sample App./Tutorial [ 10001 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40798 Fri Apr 11 14:45:55 MDT 2014 art.zambrano ICE-9943, ICE-9879 removed namespace from click event registration, so that the event can be triggered multiple times
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Issue found in Showcase > Context Menu> Overview (All browsers) r40726.
              Left clicking anywhere on the page to dismiss a context menu only works the first time. When you subsequently right click to get another context menu, a left click will not dismiss it. This is not the case when you are left clicking on a menu item, it only happens when you are left clicking outside of the menu.

              This issue was most likely not related to this JIRA, but a separate issue more related to ICE-9879.

              Committed fix to 4.0 trunk at revision 40798 and to 3.3 EE maintenance branch at revision 40799. Removed the namespace from the click event handler, so that the event can be triggered multiple times.

              Show
              Arturo Zambrano added a comment - Issue found in Showcase > Context Menu> Overview (All browsers) r40726. Left clicking anywhere on the page to dismiss a context menu only works the first time. When you subsequently right click to get another context menu, a left click will not dismiss it. This is not the case when you are left clicking on a menu item, it only happens when you are left clicking outside of the menu. This issue was most likely not related to this JIRA, but a separate issue more related to ICE-9879 . Committed fix to 4.0 trunk at revision 40798 and to 3.3 EE maintenance branch at revision 40799. Removed the namespace from the click event handler, so that the event can be triggered multiple times.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Liana Munroe added a comment -

              Showcase > Context Menu> Overview Left click issue is confirmed fixed. Icefaces ee-3.3.0 maintenance branch and Icefaces 4 trunk r40799. Tomcat 7, all browsers.

              Show
              Liana Munroe added a comment - Showcase > Context Menu> Overview Left click issue is confirmed fixed. Icefaces ee-3.3.0 maintenance branch and Icefaces 4 trunk r40799. Tomcat 7, all browsers.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: