ICEfaces
  1. ICEfaces
  2. ICE-9912

ace:autoCompleteEntry - Keyboard arrow key navigation issue in Firefox

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Firefox

      Description

      In Firefox, after entering text to the autoCompleteEntry input field, using the arrow keys to navigate to an option, each single keypress causes the focus/highlight to move down two options.

      This makes selecting a value via the keyboard in FF some what difficult. This issue can be reproduced with the Showcase demo.

        Activity

        Arran Mccullough created issue -
        Ken Fyten made changes -
        Field Original Value New Value
        Assignee Carmen Cristurean [ ccristurean ]
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Fix Version/s 4.0 [ 11382 ]
        Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Assignee Priority P2 [ 10011 ]
        Hide
        Carmen Cristurean added a comment -

        This issue is reproducible in FF27/17/3.6 with EE-3.3.0.GA_P01 release code, EE-3.3.0.GA-maintenance branch# 40368, and IF4 trunk# 40367 (using showcase > autoCompleteEntry demos, and component QA test app).

        This issue was missed by automation, most of the automated tests passing for showcase > autoCompleteEntry. However none of our tests use the arrow keys, because arrow keys movements and submits are unreliable in selenium1. This type of tests will be added to the WebDriver tests for autoCompleteEntry ACE tests.
        Manual testing failed to catch this issue, probably because of the way we all performed this testing. In order to see this issue, one must press the keys at a slower pace, and we probably failed to do this.

        Show
        Carmen Cristurean added a comment - This issue is reproducible in FF27/17/3.6 with EE-3.3.0.GA_P01 release code, EE-3.3.0.GA-maintenance branch# 40368, and IF4 trunk# 40367 (using showcase > autoCompleteEntry demos, and component QA test app). This issue was missed by automation, most of the automated tests passing for showcase > autoCompleteEntry. However none of our tests use the arrow keys, because arrow keys movements and submits are unreliable in selenium1. This type of tests will be added to the WebDriver tests for autoCompleteEntry ACE tests. Manual testing failed to catch this issue, probably because of the way we all performed this testing. In order to see this issue, one must press the keys at a slower pace, and we probably failed to do this.
        Ken Fyten made changes -
        Assignee Carmen Cristurean [ ccristurean ] Mircea Toma [ mircea.toma ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40453 Thu Mar 27 14:38:00 MDT 2014 mircea.toma ICE-9912 Unbind 'onkeyup' callback when 'keypress' callback is invoked already.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Hide
        Mircea Toma added a comment -

        The issue occurs because there are two callbacks registered for key events. This is a regression introduced by the fix for ICE-9327.

        Show
        Mircea Toma added a comment - The issue occurs because there are two callbacks registered for key events. This is a regression introduced by the fix for ICE-9327 .
        Hide
        Mircea Toma added a comment - - edited

        The applied fix unbinds the 'onkeyup' callback in case the 'onkeypress' callback is invoked. In the use case described by ICE-9327 when the 'onkeypress' is not invoked the additional 'onkeyup' will be the one (and only one) invoking the callback.

        Show
        Mircea Toma added a comment - - edited The applied fix unbinds the 'onkeyup' callback in case the 'onkeypress' callback is invoked. In the use case described by ICE-9327 when the 'onkeypress' is not invoked the additional 'onkeyup' will be the one (and only one) invoking the callback.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Carmen Cristurean added a comment -

        Verified with EE4 trunk/EE-3.3.0-maintenance branch # 40474 using showcase > ace:autoCompleteEntry, in FF27, IE10, Chrome33.

        Show
        Carmen Cristurean added a comment - Verified with EE4 trunk/EE-3.3.0-maintenance branch # 40474 using showcase > ace:autoCompleteEntry, in FF27, IE10, Chrome33.
        Hide
        Liana Munroe added a comment -

        Verified with ACE regressions on ee-3.3.0 maintenance branch, revision #40475.

        Show
        Liana Munroe added a comment - Verified with ACE regressions on ee-3.3.0 maintenance branch, revision #40475.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: