Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0.BETA, 4.0
    • Component/s: MOBI-Components
    • Labels:
      None
    • Environment:
      ICEfaces 4
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      The mobi:flipswitch component provides a control that toggles between on and off states (boolean).

        Issue Links

          Activity

          Hide
          Cruz Miraback added a comment -

          Test Results

          1) Is there a reason why the value attribute is an Object type in the docs? Is there another use case besides a regular boolean?

          2) The flipswitch value can still be changed and submitted when readonly=true. However, if both readonly and disabled are true then the flipswitch value cannot be changed (which I believe should be the default behaviour for readonly by itself). If disabled=true then the flipswitch can still be changed but the value cannot be submitted (I believe this is expected behaviour).

          3) Inherited attributes converter, required, validator (and their messages) should likely be removed from the component since there is no reasonable use case for these.

          Show
          Cruz Miraback added a comment - Test Results 1) Is there a reason why the value attribute is an Object type in the docs? Is there another use case besides a regular boolean? 2) The flipswitch value can still be changed and submitted when readonly=true. However, if both readonly and disabled are true then the flipswitch value cannot be changed (which I believe should be the default behaviour for readonly by itself). If disabled=true then the flipswitch can still be changed but the value cannot be submitted (I believe this is expected behaviour). 3) Inherited attributes converter, required, validator (and their messages) should likely be removed from the component since there is no reasonable use case for these.
          Hide
          Cruz Miraback added a comment - - edited

          Issue (ICEfaces4/trunk revision# 40047):

          4) The value printed on the page does not update when changing the flipswitch value inside nested ace:dataTables. No issues when inside nested h:dataTables.

          Show
          Cruz Miraback added a comment - - edited Issue (ICEfaces4/trunk revision# 40047): 4) The value printed on the page does not update when changing the flipswitch value inside nested ace:dataTables. No issues when inside nested h:dataTables.
          Show
          Cruz Miraback added a comment - Test application is located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/flipswitch
          Hide
          Arturo Zambrano added a comment -

          r40081: fixed issue with extra comma init script.

          Show
          Arturo Zambrano added a comment - r40081: fixed issue with extra comma init script.
          Hide
          Arturo Zambrano added a comment -

          The last issue reported on ace:dataTable's seems to be only due to the fact that the data objects do not override the equals() and hashCode() methods with their own implementations. So, please try adding them, and then testing again to see if the issue is fixed.

          Show
          Arturo Zambrano added a comment - The last issue reported on ace:dataTable's seems to be only due to the fact that the data objects do not override the equals() and hashCode() methods with their own implementations. So, please try adding them, and then testing again to see if the issue is fixed.
          Hide
          Cruz Miraback added a comment -

          For issue #4, after overriding the equals() and hashCode() methods I am getting the same results, the flipswitch value does not update.

          Show
          Cruz Miraback added a comment - For issue #4, after overriding the equals() and hashCode() methods I am getting the same results, the flipswitch value does not update.
          Hide
          Arturo Zambrano added a comment -

          Changed type of value attribute from Object to Boolean type, as in the case of h:selectBooleanCheckbox, at revision 40092. As for, the attributes converter, validator, etc., they'll just stay there, since they are part of the JSF contract, and h:selectBooleanCheckbox also keeps them.

          Show
          Arturo Zambrano added a comment - Changed type of value attribute from Object to Boolean type, as in the case of h:selectBooleanCheckbox, at revision 40092. As for, the attributes converter, validator, etc., they'll just stay there, since they are part of the JSF contract, and h:selectBooleanCheckbox also keeps them.
          Hide
          Arturo Zambrano added a comment -

          Fixed readonly and disabled behaviour.

          The correct behaviour should be as follows:

          • If either disabled or readonly or both are set to true, then the value of the flip switch cannot be changed by the user.
          • If disabled is true, then the value of the component (clientId + "_hidden") is not submitted in the request, otherwise it is submitted normally.
          Show
          Arturo Zambrano added a comment - Fixed readonly and disabled behaviour. The correct behaviour should be as follows: If either disabled or readonly or both are set to true, then the value of the flip switch cannot be changed by the user. If disabled is true, then the value of the component (clientId + "_hidden") is not submitted in the request, otherwise it is submitted normally.
          Hide
          Cruz Miraback added a comment -

          ICEfaces4 trunk revision# 40111

          Confirmed #1 fixed (Object changed to Boolean type)
          Confirmed #2 fixed, component behaves as expected.
          Nothing to confirm for #3, no changes required.

          #4 still remains.

          Show
          Cruz Miraback added a comment - ICEfaces4 trunk revision# 40111 Confirmed #1 fixed (Object changed to Boolean type) Confirmed #2 fixed, component behaves as expected. Nothing to confirm for #3, no changes required. #4 still remains.
          Hide
          Ken Fyten added a comment -

          Remaining issue #4 with nested ace:dataTables has been spun off to ICE-9895.

          Marking Resolved.

          Show
          Ken Fyten added a comment - Remaining issue #4 with nested ace:dataTables has been spun off to ICE-9895 . Marking Resolved.

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Ken Fyten
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: