Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Component/s: MOBI-Components
-
Labels:None
-
Environment:ICEfaces 4
-
Affects:Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial
Description
Issue Links
- depends on
-
MOBI-882
Refactor flipSwitch into ACE compatible form
-
- Resolved
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
mobi:dataView component renders a table region for iterative output using columns defined with the required DataViewColumns component child, and a detail region for extensive viewing (and editing) of the row objects of the table model. The detail region is defined with the DataViewDetails child component and it's contents are displayed when a row of table region is activated, typically by a row tap.
mobi:dataViewColumns defines a column in the table region of the DataView component. mobi:dataViewColumns component defines the table region of the DataView component either by its DataViewColumn child components or by attaching an implementationof DataViewColumnsModel to the 'value' attribute of this component. mobi:dataViewDetail - The child components of this component define the region to be displayed when a row object of DataView table region is activated. When DataView 'activationMode' is set to 'server' the child components of this region may be arbitrary JSF components. When 'activationMode' is set to 'client' the child components of this region are prerendered and have their dynamic attributes cached on the client to allow instantaneous activation. Client activation mode is restricted to particular components and only particular attributes of these components may be dynamic, the specifics are documented on our wiki. |
The mobi:flipswitch component provides a control that toggles between on and off states (boolean). |
| Component/s | MOBI-Components [ 10270 ] | |
| Component/s | ACE-Components [ 10050 ] |
Issue (ICEfaces4/trunk revision# 40047):
4) The value printed on the page does not update when changing the flipswitch value inside nested ace:dataTables. No issues when inside nested h:dataTables.
Test application is located at: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Manual/flipswitch
r40081: fixed issue with extra comma init script.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #40081 | Tue Feb 25 15:16:08 MST 2014 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java
|
The last issue reported on ace:dataTable's seems to be only due to the fact that the data objects do not override the equals() and hashCode() methods with their own implementations. So, please try adding them, and then testing again to see if the issue is fixed.
For issue #4, after overriding the equals() and hashCode() methods I am getting the same results, the flipswitch value does not update.
Changed type of value attribute from Object to Boolean type, as in the case of h:selectBooleanCheckbox, at revision 40092. As for, the attributes converter, validator, etc., they'll just stay there, since they are part of the JSF contract, and h:selectBooleanCheckbox also keeps them.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #40092 | Wed Feb 26 15:16:08 MST 2014 | art.zambrano | |
| Files Changed | ||||
|
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchMeta.java
|
Fixed readonly and disabled behaviour.
The correct behaviour should be as follows:
- If either disabled or readonly or both are set to true, then the value of the flip switch cannot be changed by the user.
- If disabled is true, then the value of the component (clientId + "_hidden") is not submitted in the request, otherwise it is submitted normally.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #40094 | Wed Feb 26 18:35:12 MST 2014 | art.zambrano | |
| Files Changed | ||||
|
MODIFY
/icefaces4/trunk/icefaces/mobi/component/src/org/icefaces/mobi/component/flipswitch/FlipSwitchRenderer.java
|
ICEfaces4 trunk revision# 40111
Confirmed #1 fixed (Object changed to Boolean type)
Confirmed #2 fixed, component behaves as expected.
Nothing to confirm for #3, no changes required.
#4 still remains.
Remaining issue #4 with nested ace:dataTables has been spun off to ICE-9895.
Marking Resolved.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 4.0 [ 11382 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Test Results
1) Is there a reason why the value attribute is an Object type in the docs? Is there another use case besides a regular boolean?
2) The flipswitch value can still be changed and submitted when readonly=true. However, if both readonly and disabled are true then the flipswitch value cannot be changed (which I believe should be the default behaviour for readonly by itself). If disabled=true then the flipswitch can still be changed but the value cannot be submitted (I believe this is expected behaviour).
3) Inherited attributes converter, required, validator (and their messages) should likely be removed from the component since there is no reasonable use case for these.