ICEfaces
  1. ICEfaces
  2. ICE-9742

Support for IE10 clear icon for inputFields in ace:dataTable filter input field

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ace components IE10
    • Assignee Priority:
      P3
    • Salesforce Case Reference:

      Description

      in IE10 an input field will render with a little 'x' icon at the right side of the input field.
      For ace:dataTable filter inputs, the x will clear the field but the dataTable will not reset to a blank filter value.

      The javascript for the filter event (change) only listens for the following events:-
       else if (this.cfg.filterEvent == "change")
              this.element.on('keyup', this.filterSelector, function (event) {
                  var _event = event;
                  if (event.which == 8 || event.which == 13 || event.which > 40 || event.isTrigger) {
                      if (_self.delayedFilterCall)

      ....
      note that all of these are for keyboard manipulation (keypress, backspace, etc).
      might want to check the event 'oninput" as per this link:- http://stackoverflow.com/questions/14700466/attach-event-to-clear-icon-in-ie10-textbox
      or more comprehensive apporach that will also include mobile devices (?).

        Activity

        Judy Guglielmin created issue -
        Hide
        Judy Guglielmin added a comment -

        snap showing the icon rendered automatically by IE10

        Show
        Judy Guglielmin added a comment - snap showing the icon rendered automatically by IE10
        Judy Guglielmin made changes -
        Field Original Value New Value
        Attachment IE10cleanInput.png [ 16620 ]
        Judy Guglielmin made changes -
        Salesforce Case Reference 5007000000Y4mYEAAZ
        Hide
        Judy Guglielmin added a comment -

        feature to consider for filtering with ace:dataTable. also linked to support case 12547

        Show
        Judy Guglielmin added a comment - feature to consider for filtering with ace:dataTable. also linked to support case 12547
        Judy Guglielmin made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Judy Guglielmin made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Ken Fyten made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Judy Guglielmin made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Ken Fyten made changes -
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Fix Version/s 4.0 [ 11382 ]
        Fix Version/s 4.1 [ 11375 ]
        Ken Fyten made changes -
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Assignee Priority P3 [ 10012 ]
        Hide
        Liana Munroe added a comment -

        IF4 and ee-3.3.0.GA Maintenance Branch
        Two scenarios are listed where change events are involved for *Entry components in IE 10/11.
        The following scenarios are examples from autoCompleteEntry
        Scenario 1 using the x icon.
        Place cursor in field.
        Type a few chars.
        The autoCompleteEntry list drops down.
        Press the x icon.
        Typed chars in input field are removed.
        List remains.
        Press TAB.
        List is removed.

        Scenario 2 using backspace.
        Place cursor in field.
        Type a few chars.
        The autoCompleteEntry list drops down.
        Press backspace to remove typed chars.
        Typed chars in input field are removed.
        List is removed.

        This type of behavior is evident in all the *Entry components and dataTable Filtering.

        Show
        Liana Munroe added a comment - IF4 and ee-3.3.0.GA Maintenance Branch Two scenarios are listed where change events are involved for *Entry components in IE 10/11. The following scenarios are examples from autoCompleteEntry Scenario 1 using the x icon. Place cursor in field. Type a few chars. The autoCompleteEntry list drops down. Press the x icon. Typed chars in input field are removed. List remains. Press TAB. List is removed. Scenario 2 using backspace. Place cursor in field. Type a few chars. The autoCompleteEntry list drops down. Press backspace to remove typed chars. Typed chars in input field are removed. List is removed. This type of behavior is evident in all the *Entry components and dataTable Filtering.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40696 Thu Apr 03 10:22:46 MDT 2014 mircea.toma ICE-9742 Use 'oninput' callback to detect when entry is cleared using the built-in button.
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
        Hide
        Mircea Toma added a comment -

        Registered 'oninput' callback to detect when entry is cleared using the built-in button, and then submit back the value.

        Show
        Mircea Toma added a comment - Registered 'oninput' callback to detect when entry is cleared using the built-in button, and then submit back the value.
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ken Fyten added a comment -

        Re-open to complete this addition for the other applicable *Entry components.

        Show
        Ken Fyten added a comment - Re-open to complete this addition for the other applicable *Entry components.
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Liana Munroe added a comment -

        The fix works as expected with ICEfaces 4, but not with ee-3.3.0 maintenance branch. To see an example:
        Launch showcase in IE on the windows 8 test machine with IE 11.
        The test machine is at 10.18.39.107, usual login credentials.
        Use showcase from ee-3.3.0 maintenance branch
        Navigate to ace:dataTable Overview.
        In the "Name" input box type the letters "en".
        The column will be filtered down to 3 rows.
        Click the x icon to clear the field.
        The rows are not returned to their unfiltered state.

        Show
        Liana Munroe added a comment - The fix works as expected with ICEfaces 4, but not with ee-3.3.0 maintenance branch. To see an example: Launch showcase in IE on the windows 8 test machine with IE 11. The test machine is at 10.18.39.107, usual login credentials. Use showcase from ee-3.3.0 maintenance branch Navigate to ace:dataTable Overview. In the "Name" input box type the letters "en". The column will be filtered down to 3 rows. Click the x icon to clear the field. The rows are not returned to their unfiltered state.
        Hide
        Mircea Toma added a comment - - edited

        Fixed search string used for searching filter input elements in ee-3.3.0 maintenance branch.

        Show
        Mircea Toma added a comment - - edited Fixed search string used for searching filter input elements in ee-3.3.0 maintenance branch.
        Hide
        Mircea Toma added a comment -

        Detect when clear icon is pressed by registering an 'oninput' callback with the autocomplete's input element.

        Show
        Mircea Toma added a comment - Detect when clear icon is pressed by registering an 'oninput' callback with the autocomplete's input element.
        Hide
        Ken Fyten added a comment -

        ace:selectMenu has similar functionality to autocomplete and may also need this fix. Please review.

        Show
        Ken Fyten added a comment - ace:selectMenu has similar functionality to autocomplete and may also need this fix. Please review.
        Hide
        Mircea Toma added a comment -

        IE will not show the 'clear' button when selectMenu is modified, most probably because you cannot enter text instead you need to select an option.

        Show
        Mircea Toma added a comment - IE will not show the 'clear' button when selectMenu is modified, most probably because you cannot enter text instead you need to select an option.
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Confirmed fixed, Icefaces ee-3.3.0 maintenance branch r40796, IE 10/11.

        Show
        Liana Munroe added a comment - Confirmed fixed, Icefaces ee-3.3.0 maintenance branch r40796, IE 10/11.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: