ICEfaces
  1. ICEfaces
  2. ICE-9720

ace:autoCompleteEntry Rendering List Outside Viewable Region

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Tomcat 7 / JBoss
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      The attached war file which runs in Tomcat 7 shows the ace:autoCompleteEntry list rendering outside the visible area of the browser (you must scroll to the right).

      In the test application, go to the main tabset at the top and select 'My Customer Pricing' -> 'Change Request List'. In the top ace:dataTable, the ace:autoCompleteEntry works. In the bottom ace:dataTable, which is nested inside a second tabset, scroll to the right to get to the ace:autoCompleteEntry column. Type '1'. The browser scrollbar appears and if you scroll right, you will see the drop down.
      1. IF4Chrome.png
        33 kB
      2. withScroll.png
        9 kB

        Activity

        Brad Kroeger created issue -
        Brad Kroeger made changes -
        Field Original Value New Value
        Attachment Test.war [ 16609 ]
        Brad Kroeger made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Brad Kroeger made changes -
        Salesforce Case Reference 5007000000UaCTLAA3
        Arturo Zambrano made changes -
        Fix Version/s 4.0 [ 10770 ]
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #39103 Wed Dec 04 16:16:47 MST 2013 art.zambrano ICE-9720 changed popup positioning to 'fixed' and relative to the browser window, in order to avoid issues with ancestor absolute/relative-positioned elements
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Hide
        Arturo Zambrano added a comment -

        r39103:
        Committed fix to 4.0 trunk.
        r39104:
        Committed fix to 3.3 EE maintenance branch.

        The positioning procedure was modified to use 'fixed' positioning and coordinates relative to the browser window, in order to avoid issues with absolute/relative parent elements.

        Show
        Arturo Zambrano added a comment - r39103: Committed fix to 4.0 trunk. r39104: Committed fix to 3.3 EE maintenance branch. The positioning procedure was modified to use 'fixed' positioning and coordinates relative to the browser window, in order to avoid issues with absolute/relative parent elements.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment - - edited

        No issues with popup list in regression test apps in either EE-3.3.0 maintenance branch or icefaces 4. revisions 39255 and 39252. All browsers, Tomcat 7.

        Show
        Liana Munroe added a comment - - edited No issues with popup list in regression test apps in either EE-3.3.0 maintenance branch or icefaces 4. revisions 39255 and 39252. All browsers, Tomcat 7.
        Hide
        Brad Kroeger added a comment -

        Seeing two things with the latest changes:

        1 - When you retrieve a list and then change the input to shorten the list, the list stays in it's initial position and concatenates the filtered items. So, the list is shorter but in the same spot creating a gap between the list and the component

        2 - The list scrolls with scrollbars

        Show
        Brad Kroeger added a comment - Seeing two things with the latest changes: 1 - When you retrieve a list and then change the input to shorten the list, the list stays in it's initial position and concatenates the filtered items. So, the list is shorter but in the same spot creating a gap between the list and the component 2 - The list scrolls with scrollbars
        Brad Kroeger made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        Committed fix to 4.0 trunk at revision 39270 and to 3.3 EE branch at revision 39271. Changed the approach to render the popup from fixed position to absolute position and placed text field and popup under the same positioned container.

        Show
        Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 39270 and to 3.3 EE branch at revision 39271. Changed the approach to render the popup from fixed position to absolute position and placed text field and popup under the same positioned container.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #39270 Tue Dec 10 16:59:41 MST 2013 art.zambrano ICE-9720 changed approach to render popup from fixed position to absolute position and placed text field and popup under the same positioned container
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
        Hide
        Liana Munroe added a comment - - edited

        Icefaces - ee-3.3.0 maintenance branch revision #39271.
        IE 8, 9, 10 - ace dataTable renders list below and ( > 10mm) to the left of expected position.
        In all other apps the list is rendered 5 - 6 mm below the expected position. If the list renders on top, it sits a 3-4 mms into the text field

        Chrome - list renders 1-2 mm below expected position, if the list is to render above the text field, it sits a mm or 2 into the text field.

        FF 3.6, 21, 25 - ace dataTable renders list below and ( > 10mm) to the left of expected position.
        In all apps the list renders 1-2 mm below expected position, if the list is to render above the text field, it sits a mm or 2 into the text field.

        Similar issues seen on Icefaces 4 trunk ACE regression tests and in showcase. revision #39276

        Show
        Liana Munroe added a comment - - edited Icefaces - ee-3.3.0 maintenance branch revision #39271. IE 8, 9, 10 - ace dataTable renders list below and ( > 10mm) to the left of expected position. In all other apps the list is rendered 5 - 6 mm below the expected position. If the list renders on top, it sits a 3-4 mms into the text field Chrome - list renders 1-2 mm below expected position, if the list is to render above the text field, it sits a mm or 2 into the text field. FF 3.6, 21, 25 - ace dataTable renders list below and ( > 10mm) to the left of expected position. In all apps the list renders 1-2 mm below expected position, if the list is to render above the text field, it sits a mm or 2 into the text field. Similar issues seen on Icefaces 4 trunk ACE regression tests and in showcase. revision #39276
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #39415 Wed Dec 11 17:19:57 MST 2013 art.zambrano ICE-9720 adjusted coordinates to better position the popup list with the new markup structure
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Hide
        Arturo Zambrano added a comment -

        Committed fix to trunk and maintenance branch at revisions 39415 and 39416. Adjusted the top and left coordinates to better position the popup list.

        Show
        Arturo Zambrano added a comment - Committed fix to trunk and maintenance branch at revisions 39415 and 39416. Adjusted the top and left coordinates to better position the popup list.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Arturo Zambrano added a comment -

        Committed another fix to the 3.3 EE branch and to the 4.0 trunk at revisions 39438 and 39440. The markup structure was modified once more to avoid having the need to explicitly position the popup list.

        Show
        Arturo Zambrano added a comment - Committed another fix to the 3.3 EE branch and to the 4.0 trunk at revisions 39438 and 39440. The markup structure was modified once more to avoid having the need to explicitly position the popup list.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #39454 Thu Dec 19 03:17:41 MST 2013 art.zambrano ICE-9720 modified markup structure to position popup list more reliably across different scenarios
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
        Hide
        Arturo Zambrano added a comment -

        Re-committed fixes above, since the SVN issues on Monday caused those commits to be lost.

        Show
        Arturo Zambrano added a comment - Re-committed fixes above, since the SVN issues on Monday caused those commits to be lost.
        Liana Munroe made changes -
        Attachment IF4Chrome.png [ 16625 ]
        Attachment withScroll.png [ 16626 ]
        Hide
        Liana Munroe added a comment -

        Issues as noted above are fixed for Icefaces4 revision# 39434 and ee-3.3.0 maintenance branch revision #39457 in all browsers. The only issue that remains is that the list (in all configurations)renders slightly wider (1 mm or less)than the input field.
        See screen shots IF4Chrome.png and withScroll.png

        Show
        Liana Munroe added a comment - Issues as noted above are fixed for Icefaces4 revision# 39434 and ee-3.3.0 maintenance branch revision #39457 in all browsers. The only issue that remains is that the list (in all configurations)renders slightly wider (1 mm or less)than the input field. See screen shots IF4Chrome.png and withScroll.png
        Hide
        Brad Kroeger added a comment - - edited

        I am still seeing this with the latest build:

        1 - When you retrieve a list and then change the input to shorten the list, the list stays in it's initial position and truncates the filtered items. So, the list is shorter but in the same spot creating a gap between the list and the component

        Let me know if you would like me to open a separate issue for this.

        Show
        Brad Kroeger added a comment - - edited I am still seeing this with the latest build: 1 - When you retrieve a list and then change the input to shorten the list, the list stays in it's initial position and truncates the filtered items. So, the list is shorter but in the same spot creating a gap between the list and the component Let me know if you would like me to open a separate issue for this.
        Brad Kroeger made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Fix Version/s 4.0.BETA [ 10770 ]
        Ken Fyten made changes -
        Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #40388 Thu Mar 20 13:34:32 MDT 2014 art.zambrano ICE-9720 adjusted list width to exactly match the width of the input element
        Files Changed
        Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Hide
        Arturo Zambrano added a comment - - edited

        Committed fix to 4.0 trunk at revision 40388 and to the 3.3 EE maintenance branch at revision 40389. Adjusted the list width to exactly match the width of the input element, by subtracting the width of the borders and paddings.

        I couldn't reproduce the last issue reported by Brad.

        Show
        Arturo Zambrano added a comment - - edited Committed fix to 4.0 trunk at revision 40388 and to the 3.3 EE maintenance branch at revision 40389. Adjusted the list width to exactly match the width of the input element, by subtracting the width of the borders and paddings. I couldn't reproduce the last issue reported by Brad.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Brad Kroeger
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: