ICEfaces
  1. ICEfaces
  2. ICE-9715

ace:dataTable - Corresponding body columns to header columns for property inheritance

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0.BETA, EE-3.3.0.GA_P02
          • Fix Version/s: 4.3
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ACE DataTable, header ColumnGroup, Column

            Description

            There are cases with ICE-9471 where there is no direct way to infer which header column corresponds to a specific body column, from which to inherit properties, and we should add a property to the body column to explicitly declare its corresponding header column.
            1. File
              dataTableLazyLoading.xhtml
              5 kB
              Mark Collette
            2. File
              dataTableLazyLoading.xhtml.rtf
              4 kB
              Mark Collette
            3. File
              Phase 2 Plan.rtf
              18 kB
              Mark Collette
            1. 1. miscorresponded.png
              136 kB
            2. 2. corresponded like for.png
              150 kB
            3. 3. bodyColumnsInheritHeaderColumnProperties eq false.png
              155 kB
            4. Phase 2 cases.jpg
              465 kB

              Issue Links

              blocks

              Improvement - An improvement or enhancement to an existing feature or task. ICE-9471 ace:tableConfigPanel - Add built in support for ace:columnGroup

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Mark Collette created issue -
                Mark Collette made changes -
                Field Original Value New Value
                Assignee Mark Collette [ mark.collette ]
                Fix Version/s 4.0 [ 10770 ]
                Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
                Assignee Priority P2 [ 10011 ]
                Mark Collette made changes -
                Link This issue blocks ICE-9471 [ ICE-9471 ]
                Mark Collette made changes -
                Security Private [ 10001 ]
                Mark Collette made changes -
                Attachment dataTableLazyLoading.xhtml [ 16601 ]
                Attachment dataTableLazyLoading.xhtml.rtf [ 16602 ]
                Attachment Phase 2 Plan.rtf [ 16603 ]
                Mark Collette made changes -
                Attachment 1. miscorresponded.png [ 16604 ]
                Attachment 2. corresponded like for.png [ 16605 ]
                Attachment 3. bodyColumnsInheritHeaderColumnProperties eq false.png [ 16606 ]
                Attachment Phase 2 cases.jpg [ 16607 ]
                Hide
                Permalink
                Mark Collette added a comment -

                The complete nature of the problem is discussed in "Phase 2 Plan.rtf" and illustrated in "Phase 2 cases.jpg".

                On the branch, in revision 39065, I committed changes to the showcase application that improve its use as a demo of lazy loading, and how that would integrate with sorting and filtering. That would benefit from being merged to trunk. It also gives everything necessary for taking the attached "dataTableLazyLoading.xhtml" and putting that into:
                icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableLazyLoading.xhtml

                In "dataTableLazyLoading.xhtml.rtf" there is the main code from "dataTableLazyLoading.xhtml" that uses highlighting to show the 4 key parts of code that illustrate the mis-correspondence issue [where the header column for "Chassis" using grouping but the body column for Name mis-inherits the grouping], and how to use the new ace:dataTable columnsInheritProperties="false" to half fix it. It's not a full fix, because with mis-corresponded columns, one can't use the tableConfigPanel to re-order columns without corrupting the view. Only the for property fix would completely fix everything.

                Show
                Mark Collette added a comment - The complete nature of the problem is discussed in "Phase 2 Plan.rtf" and illustrated in "Phase 2 cases.jpg". On the branch, in revision 39065, I committed changes to the showcase application that improve its use as a demo of lazy loading, and how that would integrate with sorting and filtering. That would benefit from being merged to trunk. It also gives everything necessary for taking the attached "dataTableLazyLoading.xhtml" and putting that into: icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableLazyLoading.xhtml In "dataTableLazyLoading.xhtml.rtf" there is the main code from "dataTableLazyLoading.xhtml" that uses highlighting to show the 4 key parts of code that illustrate the mis-correspondence issue [where the header column for "Chassis" using grouping but the body column for Name mis-inherits the grouping] , and how to use the new ace:dataTable columnsInheritProperties="false" to half fix it. It's not a full fix, because with mis-corresponded columns, one can't use the tableConfigPanel to re-order columns without corrupting the view. Only the for property fix would completely fix everything.
                Ken Fyten made changes -
                Summary Corresponding body columns to header columns for property inheritance ace:dataTable - Corresponding body columns to header columns for property inheritance
                Ken Fyten made changes -
                Issue Type New Feature [ 2 ] Improvement [ 4 ]
                Ken Fyten made changes -
                Assignee Mark Collette [ mark.collette ]
                Fix Version/s 4.1 [ 11375 ]
                Fix Version/s 4.0.BETA [ 10770 ]
                Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
                Assignee Priority P2 [ 10011 ]
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Hide
                Permalink
                Ken Fyten added a comment -

                Keeping this private due to Williams references in the attachments.

                Show
                Ken Fyten added a comment - Keeping this private due to Williams references in the attachments.
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Ken Fyten made changes -
                Fix Version/s 4.2 [ 12870 ]
                Fix Version/s 4.1 [ 11375 ]
                Ken Fyten made changes -
                Fix Version/s EE-4.2.0.GA [ 13071 ]
                Fix Version/s 4.2 [ 12870 ]
                Ken Fyten made changes -
                Fix Version/s 4.3 [ 13096 ]
                Fix Version/s EE-4.2.0.GA [ 13071 ]
                Ken Fyten made changes -
                Assignee Arturo Zambrano [ artzambrano ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #52215 Tue Jan 16 15:17:09 MST 2018 art.zambrano ICE-9715 added improvement to be able to inherit properties in body columns from a specific header column
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/model/table/ColumnModel.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ProxiedBodyColumn.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ColumnMeta.java
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r52215: added improvement to be able to inherit properties in body columns from a specific header column
                r48935: added test pages to the datatable QA test app

                Show
                Arturo Zambrano added a comment - r52215: added improvement to be able to inherit properties in body columns from a specific header column r48935: added test pages to the datatable QA test app
                Ken Fyten made changes -
                Security Private [ 10001 ]
                Repository Revision Date User Message
                ICEsoft Public SVN Repository #52216 Wed Jan 17 11:51:25 MST 2018 art.zambrano ICE-9715 changed name of 'for' property to 'inheritFrom', in order to more precisely convey its true purpose
                Files Changed
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/model/table/ColumnModel.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ProxiedBodyColumn.java
                Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/column/ColumnMeta.java
                Hide
                Permalink
                Arturo Zambrano added a comment -

                r52216: changed name of 'for' property to 'inheritFrom', in order to more precisely convey its true purpose

                Show
                Arturo Zambrano added a comment - r52216: changed name of 'for' property to 'inheritFrom', in order to more precisely convey its true purpose
                Arturo Zambrano made changes -
                Status Open [ 1 ] Resolved [ 5 ]
                Resolution Fixed [ 1 ]
                Ken Fyten made changes -
                Status Resolved [ 5 ] Closed [ 6 ]

                  People

                  • Assignee:
                    Arturo Zambrano
                    Reporter:
                    Mark Collette
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: