ICEfaces
  1. ICEfaces
  2. ICE-9686

Application defined resources (CSS, JavaScript) are loaded first in the head tag

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      All
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      When defining application specific CSS and JavaScript files in the h:head tag, these resources are rendered first and then the ICEfaces CSS/Script is loaded after. In the EE 3.2.0 release these resources were loaded last, therefore allowing style/script to override the default ICEfaces resources if required.

        Activity

        Arran Mccullough created issue -
        Hide
        Arran Mccullough added a comment -

        Attached test case war and source code that reproduced this issue. Note: the icefaces.jar, icefaces-ace.jar, and icefaces-compat.jar need to be added back into the war for it to run.

        Also attached two screen shots showing the differences between EE 3.2.0 and EE 3.3.0 P01.

        Show
        Arran Mccullough added a comment - Attached test case war and source code that reproduced this issue. Note: the icefaces.jar, icefaces-ace.jar, and icefaces-compat.jar need to be added back into the war for it to run. Also attached two screen shots showing the differences between EE 3.2.0 and EE 3.3.0 P01.
        Arran Mccullough made changes -
        Field Original Value New Value
        Attachment Case12483Example.war [ 16562 ]
        Attachment Case12483Example.zip [ 16563 ]
        Attachment Test-EE-3.2.0.jpg [ 16564 ]
        Attachment Test-EE-3.3.0-P01.jpg [ 16565 ]
        Arran Mccullough made changes -
        Assignee Ken Fyten [ ken.fyten ]
        Arran Mccullough made changes -
        Salesforce Case Reference 5007000000XQJaSAAX
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 10770 ]
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Assignee Priority P1 [ 10010 ]
        Hide
        Mircea Toma added a comment -

        The problem does not reside in ICEfaces but in application code. The welcome page needs to h:outputScript and h:outputStylesheet component to define the extra resources that the application needs. This way it is ensured that resources are taken into account by JSF and later on by our resource ordering feature.

        The fix applied to welcomeICEfaces.xhtml should look like this:

        .....
            <h:head>
                <title>ICEfaces 3</title>
                <h:outputStylesheet name="style.css" library="css" target="head"/>
                <h:outputScript name="script.js" library="js" target="head"/>
            </h:head>
        .....
        
        Show
        Mircea Toma added a comment - The problem does not reside in ICEfaces but in application code. The welcome page needs to h:outputScript and h:outputStylesheet component to define the extra resources that the application needs. This way it is ensured that resources are taken into account by JSF and later on by our resource ordering feature. The fix applied to welcomeICEfaces.xhtml should look like this: ..... <h:head> <title>ICEfaces 3</title> <h:outputStylesheet name= "style.css" library= "css" target= "head" /> <h:outputScript name= "script.js" library= "js" target= "head" /> </h:head> .....
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Ken Fyten made changes -
        Affects Version/s 4.0.BETA [ 10770 ]
        Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: