ICEfaces
  1. ICEfaces
  2. ICE-9579

Regression - ace:dateTimeEntry wrong styling

    Details

    • Assignee Priority:
      P2

      Description

      Component styling issues are visible in the ACE regression tests for ace:dateTimeEntry (FF23, IE10, Chrome29).
      These issues cannot be reproduced in showcase.

      1) when multiple dateTimeEntry pages are displayed (popup or inline component) - screen shot 1.png.
      2) when the dateTimeEntry component is displayed inline for a single month (pages=1) - see attached 2.png.

      Steps to reproduce:
      - build and deploy the dateTimeEntry test application located here: http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dateTimeEntry
      - issue1) can be reproduced by loading in any browser http://localhost:8080/dateTimeEntry/calendarAttribute.jsf and opening the popup calendar on the demo page, without changing any of the attributes.
      - issue2) can be seen by loading in any browser: http://localhost:8080/dateTimeEntry/calendarOnly.jsf


      Last revision number where both issues pass is trunk rev# 36978.
      On rev# 36979 only issue 1) dateTimeEntry with multiple pages - fails; issue 2) passes.
      On rev# 37062 both issues 1) and 2) fail, but the wrong styling is different from what it is now with the current revision #

      1. 1.PNG
        42 kB
      2. 2.PNG
        23 kB
      3. before-after.png
        72 kB
      4. dateTimeChrome.PNG
        22 kB
      5. dateTimeEntryAlign.PNG
        112 kB
      6. screenshot-1.jpg
        269 kB

        Activity

        Carmen Cristurean created issue -
        Carmen Cristurean made changes -
        Field Original Value New Value
        Attachment 1.PNG [ 16421 ]
        Attachment 2.PNG [ 16422 ]
        Ken Fyten made changes -
        Assignee Arturo Zambrano [ artzambrano ]
        Assignee Priority P1 [ 10010 ]
        Arturo Zambrano made changes -
        Attachment before-after.png [ 16425 ]
        Hide
        Arturo Zambrano added a comment -

        Attaching before-after screenshot.

        The cause of the first issue is that revision 36979 (ICE-9143) introduced some localisation changes, and the weekdays went from being displayed as "Su Mo Tu We Th Fr Sa" to being displayed as "Sun Mon Tue Wed Thu Fri Sat", taking more width, while the width of the container remained the same, as seen in the before-after screenshot.

        This issue is easily fixed with custom app styling, but this is prone to change depending on the locale. The names of the week and other labels could take more or less space. Perhaps, we could programmatically set the width of the container, based on the width of its inner elements. We could make this behaviour configurable as well.

        The second issue started at revision 37048, when the fixed width of the container was removed from the CSS file, making the calendar take as much space as possible. Again, this is easily fixed at the app level, and if can also be fixed with the approach described in the previous paragraph.

        Show
        Arturo Zambrano added a comment - Attaching before-after screenshot. The cause of the first issue is that revision 36979 ( ICE-9143 ) introduced some localisation changes, and the weekdays went from being displayed as "Su Mo Tu We Th Fr Sa" to being displayed as "Sun Mon Tue Wed Thu Fri Sat", taking more width, while the width of the container remained the same, as seen in the before-after screenshot. This issue is easily fixed with custom app styling, but this is prone to change depending on the locale. The names of the week and other labels could take more or less space. Perhaps, we could programmatically set the width of the container, based on the width of its inner elements. We could make this behaviour configurable as well. The second issue started at revision 37048, when the fixed width of the container was removed from the CSS file, making the calendar take as much space as possible. Again, this is easily fixed at the app level, and if can also be fixed with the approach described in the previous paragraph.
        Hide
        Arturo Zambrano added a comment -

        Committed fix to trunk at revision 38041. Added display:inline-block styling to calendar and removed code from jQuery-UI to programmatically set datepicker width.

        Show
        Arturo Zambrano added a comment - Committed fix to trunk at revision 38041. Added display:inline-block styling to calendar and removed code from jQuery-UI to programmatically set datepicker width.
        Arturo Zambrano made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38041 Mon Sep 16 14:48:20 MDT 2013 art.zambrano ICE-9579 added display:inline-block styling to calendar and removed code to programmatically set datepicker width to fix styling issues
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/timepicker.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datetimeentry/DateTimeEntryRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/readme.txt
        Hide
        Cruz Miraback added a comment -

        Icefaces3 trunk revision #38050

        The popup calendar has styling issues in IE7 when it is rendered that are different to what was initially reported here. The calender is the size of the page, the hour/minute sliders are not being rendered correctly, and the cursor in the popup input can be seen flashing on top of the rendered calendar. See screenshot.

        This can be reproduced on the Attribute test page in the same test app.

        Show
        Cruz Miraback added a comment - Icefaces3 trunk revision #38050 The popup calendar has styling issues in IE7 when it is rendered that are different to what was initially reported here. The calender is the size of the page, the hour/minute sliders are not being rendered correctly, and the cursor in the popup input can be seen flashing on top of the rendered calendar. See screenshot. This can be reproduced on the Attribute test page in the same test app.
        Cruz Miraback made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Cruz Miraback made changes -
        Attachment screenshot-1.jpg [ 16482 ]
        Hide
        Arturo Zambrano added a comment -

        Committed fixes at revision 38060: added inline-block hacks for IE7; re-applied width calculations for IE7 only, using a longer width.

        Show
        Arturo Zambrano added a comment - Committed fixes at revision 38060: added inline-block hacks for IE7; re-applied width calculations for IE7 only, using a longer width.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38060 Tue Sep 17 12:52:23 MDT 2013 art.zambrano ICE-9579 added inline-block hacks for IE7; re-applied width calculations for IE7 only, using a longer width
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.css
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/timepicker.css
        Hide
        Liana Munroe added a comment -

        Minor styling issue still exists when calendars are side by side. Chrome, IE 9. Headers with dropdowns are vertically smaller, calendars are too close together. see screen: dateTimeChrome.PNG

        Show
        Liana Munroe added a comment - Minor styling issue still exists when calendars are side by side. Chrome, IE 9. Headers with dropdowns are vertically smaller, calendars are too close together. see screen: dateTimeChrome.PNG
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment dateTimeChrome.PNG [ 16496 ]
        Hide
        Arturo Zambrano added a comment -

        Added more space between calendars at revision 38291.

        Couldn't reproduce header height issue on any browser. Please check if you still see it.

        Show
        Arturo Zambrano added a comment - Added more space between calendars at revision 38291. Couldn't reproduce header height issue on any browser. Please check if you still see it.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38291 Thu Sep 26 11:46:56 MDT 2013 art.zambrano ICE-9579 added more space between calendars when rendering multiple calendars
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/timepicker.css
        Hide
        Liana Munroe added a comment -

        The header that contains the select box is vertically smaller than the other 2 headers when 2 or 3 calendars are displayed side by side.
        This can be seen in all browsers and has been reproduced on ICEPC4 as well as on my local machine by following the steps in the JIRA . see attached screenshot dateTimeEntryAlign.PNG

        Show
        Liana Munroe added a comment - The header that contains the select box is vertically smaller than the other 2 headers when 2 or 3 calendars are displayed side by side. This can be seen in all browsers and has been reproduced on ICEPC4 as well as on my local machine by following the steps in the JIRA . see attached screenshot dateTimeEntryAlign.PNG
        Liana Munroe made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Liana Munroe made changes -
        Attachment dateTimeEntryAlign.PNG [ 16501 ]
        Liana Munroe made changes -
        Comment [ The latest screenshot ]
        Ken Fyten made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Assignee Priority P1 [ 10010 ] P2 [ 10011 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Fix Version/s 4.0 [ 11382 ]
        Fix Version/s 4.0.BETA [ 10770 ]
        Ken Fyten made changes -
        Security Private [ 10001 ]
        Liana Munroe made changes -
        Environment ICEfaces trunk rev# 36979 / 37828
        Server: Tomcat7
        Browser: all
        Test app: http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dateTimeEntry
        ICEfaces trunk rev# 36979 / 37828
        EE-3.3.0.GA Maintenance Branch
        Server: Tomcat7
        Browser: all
        Test app: http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/dateTimeEntry
        Liana Munroe made changes -
        Affects Version/s EE-3.3.0.GA_P01 [ 11174 ]
        Hide
        Arturo Zambrano added a comment -

        Committed fix for header issue to 3.3 EE maintenance branch at revision 40895. I could never reproduce this issue with the 4.0 trunk.

        Modified the datepicker code to add a span with an "invisible" character (non-breaking space) to the first calendar header in order to align its height with the other headers that contain text. Also slightly reduced the width of the month-year drop-downs in order to make this character fit.

        Show
        Arturo Zambrano added a comment - Committed fix for header issue to 3.3 EE maintenance branch at revision 40895. I could never reproduce this issue with the 4.0 trunk. Modified the datepicker code to add a span with an "invisible" character (non-breaking space) to the first calendar header in order to align its height with the other headers that contain text. Also slightly reduced the width of the month-year drop-downs in order to make this character fit.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Confirmed fixed Icefaces ee-3.3.0 maintenance branch r40900. Tomcat 7, all browsers.

        Show
        Liana Munroe added a comment - Confirmed fixed Icefaces ee-3.3.0 maintenance branch r40900. Tomcat 7, all browsers.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: