Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA
-
Fix Version/s: EE-3.3.0.GA_P01, 4.0.BETA, 4.0
-
Component/s: ACE-Components
-
Labels:None
-
Environment:Any
Description
ace:autoCompleteEntry, ace:comboBox, ace:selectMenu, and ace:simpleSelectOneMenu have some flaws in the way they handle conversion.
These components need to convert the values in option items when rendering their lists of results. This is to support complex objects being converted to a string and vice versa. When the values are plain strings or objects that translate easily to a string, there are usually no issues, but when using a custom object as the value, the conversion might not go as expected.
In short, all rendered values (not labels) of option items need to go through conversion from object to string at render time. The current value of the component will have to go through the same process. After decoding, the Renderer superclass methods can handle properly the conversion from string to object, so we don't have to interfere or override those methods.
These components need to convert the values in option items when rendering their lists of results. This is to support complex objects being converted to a string and vice versa. When the values are plain strings or objects that translate easily to a string, there are usually no issues, but when using a custom object as the value, the conversion might not go as expected.
In short, all rendered values (not labels) of option items need to go through conversion from object to string at render time. The current value of the component will have to go through the same process. After decoding, the Renderer superclass methods can handle properly the conversion from string to object, so we don't have to interfere or override those methods.
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Arturo Zambrano [ artzambrano ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #37712 | Thu Aug 29 09:53:27 MDT 2013 | art.zambrano | |
| Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenu.java
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
MODIFY
/icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java
|
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Fix Version/s | EE-3.3.0.GA_P01 [ 11174 ] | |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 3.4 [ 10770 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Linking to ICE-9564 to track the validation issue with ace:simpleSelectOneMenu.
Show
Arturo Zambrano
added a comment - Linking to ICE-9564 to track the validation issue with ace:simpleSelectOneMenu.
Found error in SimpleSelectOneMenuRenderer.populateList():
if (!selectedFound && value != null && value.toString().equals((String) itemValue))
{ selected = " selected=\"selected\""; selectedFound = true; }value should be converted by getConvertedValueForClient(), not by simple toString(). Currently it's impossible to update selected value from the bean for lookups containing objects.
Show
Denis Utkin
added a comment - Found error in SimpleSelectOneMenuRenderer.populateList():
if (!selectedFound && value != null && value.toString().equals((String) itemValue))
{
selected = " selected=\"selected\"";
selectedFound = true;
}
value should be converted by getConvertedValueForClient(), not by simple toString(). Currently it's impossible to update selected value from the bean for lookups containing objects.
Denis,
Thank you for your tip. That issue is now fixed as part of ICE-9564.
Show
Arturo Zambrano
added a comment - Denis,
Thank you for your tip. That issue is now fixed as part of ICE-9564 .
| Fix Version/s | 4.0 [ 11382 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Committed fixes to trunk at revision 37712 and to p01 tag at revision 37713.