ICEfaces
  1. ICEfaces
  2. ICE-9542

showcase - dataTable - Grouping demo - row expansion issues when applying filters

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA
          • Fix Version/s: EE-3.3.0.GA_P02, 4.0
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            EE ICEfaces 3.3.0.GA_P01 rev# 37461/ EE ICEfaces 3.3.0.GA Release code
            Server: Tomcat7
            Browsers: all
          • Assignee Priority:
            P2

            Description

            In showcase -> Grouping: if applying a filter on the "Weight" column, the expansion of the rows does not appear to work properly.
            The automated test is successful because it does not test row expansion combined with filtering.

            Issue1: unable to expand a row for certain applied filters
            1. Enter '4' in 'Weight' filtering input text -> two rows will be rendered.
            2. Try to expand each row -> only first row can be expanded.
            Removing followed by re-applying the filter will render the second row being expanded.

            Issue2: first row duplication
            1. Enter '1' for 'Weight' filtering text -> 15 rows rendered.
            2. Try to expand first row (ID=4) -> this row will be expanded but it is rendered twice, each instance calculating different values for the Cost Per Pound.
            3. Trying to expand a different row will still duplicate the first row, and the row fails to expand.
            Removing the filter and then re-entering the filter removes the duplicated row.

            Row expansion is functional on this demo if no filters are applied.

              Activity

              Ascending order - Click to sort in descending order
              Carmen Cristurean created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Fix Version/s 3.4 [ 10770 ]
              Ken Fyten made changes -
              Assignee Nils Lundquist [ nils.lundquist ]
              Ken Fyten made changes -
              Assignee Nils Lundquist [ nils.lundquist ] Arturo Zambrano [ artzambrano ]
              Security Private [ 10001 ]
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Assignee Priority P2 [ 10011 ]
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 11382 ]
              Fix Version/s 4.0.BETA [ 10770 ]
              Hide
              Permalink
              Arturo Zambrano added a comment -

              This issue seems to only occur with Mojarra and not with Myfaces.

              Show
              Arturo Zambrano added a comment - This issue seems to only occur with Mojarra and not with Myfaces.
              Hide
              Permalink
              Arturo Zambrano added a comment - - edited

              The problem starts at revision 31485 (ICE-7952), with a fix for a MyFaces compatibility issue in the showcase app code. Using the latest revision in either the 4.0 trunk or 3.3 EE branch, the problem is fixed by changing the scope of the class DataTableBindings.java in the showcase from @RequestScoped to @CustomScoped(value="#{window}"). However, this might cause issues with MyFaces.

              Show
              Arturo Zambrano added a comment - - edited The problem starts at revision 31485 ( ICE-7952 ), with a fix for a MyFaces compatibility issue in the showcase app code. Using the latest revision in either the 4.0 trunk or 3.3 EE branch, the problem is fixed by changing the scope of the class DataTableBindings.java in the showcase from @RequestScoped to @CustomScoped(value="#{window}"). However, this might cause issues with MyFaces.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40966 Thu May 08 15:24:58 MDT 2014 art.zambrano ICE-9542 modified ace:dataTable Grouping demo to use a DataTable binding either in a request-scoped bean or in a window-scoped bean, depending whether MyFaces is being used or not; this is related to ICE-7952
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableGrouping.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableGrouping.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableBindings.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix to 4.0 trunk at revision 40966 and to 3.3 EE maintenance branch at revision 40967. The fix is in the showcase app code. Modified the ace:dataTable Grouping demo to use a DataTable binding either in a request-scoped bean or in a window-scoped bean, depending whether MyFaces is being used or not. This modification only affects the Grouping demo.

              Tested this demo, using MyFaces and no issues were found related to this fix.

              Show
              Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 40966 and to 3.3 EE maintenance branch at revision 40967. The fix is in the showcase app code. Modified the ace:dataTable Grouping demo to use a DataTable binding either in a request-scoped bean or in a window-scoped bean, depending whether MyFaces is being used or not. This modification only affects the Grouping demo. Tested this demo, using MyFaces and no issues were found related to this fix.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              On Grouping demo, rows cannot be expanded anymore (EE-3.3.0-maintenance rev. 40984).

              Show
              Carmen Cristurean added a comment - On Grouping demo, rows cannot be expanded anymore (EE-3.3.0-maintenance rev. 40984).
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40987 Fri May 09 16:09:48 MDT 2014 art.zambrano ICE-9542 reverted previous fix
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableGrouping.java
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableGrouping.xhtml
              Commit graph MODIFY /icefaces4/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableBindings.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Reverted previous fixes at revisions 40987 and 40988.

              Show
              Arturo Zambrano added a comment - Reverted previous fixes at revisions 40987 and 40988.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40989 Fri May 09 16:21:04 MDT 2014 art.zambrano ICE-9542 fix to reapply filtering and sorting to data model at render phase when using Mojarra, in order to solve inconsistency issues
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed new fix at revisions 40989 and 40990. This fix is in the ace:dataTable code and consists in reapplying filtering and sorting to the data model at render phase when using Mojarra, in order to solve inconsistency issues.

              The root of the problem was that after sending a filter request, the subsequent requests weren't based on the filtered data set, but on the original, unfiltered one, and that was causing unpredictable, odd behaviour when interacting with the table.

              Show
              Arturo Zambrano added a comment - Committed new fix at revisions 40989 and 40990. This fix is in the ace:dataTable code and consists in reapplying filtering and sorting to the data model at render phase when using Mojarra, in order to solve inconsistency issues. The root of the problem was that after sending a filter request, the subsequent requests weren't based on the filtered data set, but on the original, unfiltered one, and that was causing unpredictable, odd behaviour when interacting with the table.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              Verified with EE-3.3.0-maintenance branch/ ICEfaces4 trunk rev. 40990 (Mojarra and MyFaces) in FF28, Chrome34, IE10, and all issues above appear to be resolved. Also, none of the issues from ICE-9946 could be reproduced anymore.

              Show
              Carmen Cristurean added a comment - - edited Verified with EE-3.3.0-maintenance branch/ ICEfaces4 trunk rev. 40990 (Mojarra and MyFaces) in FF28, Chrome34, IE10, and all issues above appear to be resolved. Also, none of the issues from ICE-9946 could be reproduced anymore.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Carmen Cristurean
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: