ICEfaces
  1. ICEfaces
  2. ICE-9534

Make showcase ACE DataTable cell selection sample use simplified EL

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      showcase
    • Assignee Priority:
      P2
    • Affects:
      Sample App./Tutorial

      Description

      The EL we're using for the showcase ACE DataTable Selection sample's cell selection interface uses method calling, which isn't supported by older EL, such as that provided in Tomcat 6. We need to code to a lowest common denominator in our sample app.

        Activity

        Mark Collette created issue -
        Mark Collette made changes -
        Field Original Value New Value
        Assignee Mark Collette [ mark.collette ]
        Fix Version/s 3.4 [ 10770 ]
        Affects Sample App./Tutorial [ 10001 ]
        Assignee Priority P2 [ 10011 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #37461 Wed Aug 21 01:02:16 MDT 2013 mark.collette ICE-9534 : Make showcase ACE DataTable cell selection sample use simplified EL
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableSelector.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableSelector.xhtml
        Hide
        Mark Collette added a comment -

        Replaced the Map usage and EL method invocations with a List of a custom object type, and replaced the dynamic DataTable Column value evaluation with a static evaluation of the 'Car' data type. Propagated the comma delimited list EL into the row selection so it will now match the cell selection.

        Was originally going to use a cached List, that would only get cleared on cell selection events, but since we support a mode without ace:ajax, there was no event for the full form submit of deferred cell selections, so just re-build the List on every access, like the Map code used to do. Caching would be simpler if there was an easy way to detect different lifecycles from a getter method, instead of having to wire up a PhaseListener.

        icefaces3 trunk
        Subversion 37461

        Show
        Mark Collette added a comment - Replaced the Map usage and EL method invocations with a List of a custom object type, and replaced the dynamic DataTable Column value evaluation with a static evaluation of the 'Car' data type. Propagated the comma delimited list EL into the row selection so it will now match the cell selection. Was originally going to use a cached List, that would only get cleared on cell selection events, but since we support a mode without ace:ajax, there was no event for the full form submit of deferred cell selections, so just re-build the List on every access, like the Map code used to do. Caching would be simpler if there was an easy way to detect different lifecycles from a getter method, instead of having to wire up a PhaseListener. icefaces3 trunk Subversion 37461
        Mark Collette made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P01 [ 11174 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P01 [ 11174 ]
        Ken Fyten made changes -
        Assignee Mark Collette [ mark.collette ] Arturo Zambrano [ artzambrano ]
        Hide
        Carmen Cristurean added a comment -

        In showcase > dataTable > Selection demo: selected rows/cells cannot be submitted in non-ajax mode; button to submit selections is not enabled when 'Instant Status Update via Ajax' check box is deselected.

        Show
        Carmen Cristurean added a comment - In showcase > dataTable > Selection demo: selected rows/cells cannot be submitted in non-ajax mode; button to submit selections is not enabled when 'Instant Status Update via Ajax' check box is deselected.
        Carmen Cristurean made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Arturo Zambrano added a comment -

        Committed fix at revision 38226. Simply fixed the markup.

        Show
        Arturo Zambrano added a comment - Committed fix at revision 38226. Simply fixed the markup.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38226 Thu Sep 19 10:52:25 MDT 2013 art.zambrano ICE-9534 fixed markup to show submit button when no-ajax mode is on
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableSelector.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38267 Mon Sep 23 18:11:43 MDT 2013 art.zambrano ICE-9600 re-added h:panelGroup that was removed in an ICE-9534 commit, used to update with the list of selected rows and cells
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableSelector.xhtml
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Ken Fyten made changes -
        Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
        Ken Fyten made changes -
        Fix Version/s 4.0 [ 11382 ]
        Fix Version/s 4.0.BETA [ 10770 ]
        Hide
        Arturo Zambrano added a comment -

        Committed backport to 3.3 EE maintenance branch at revision 40806.

        Show
        Arturo Zambrano added a comment - Committed backport to 3.3 EE maintenance branch at revision 40806.
        Arturo Zambrano made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Liana Munroe added a comment -

        Confirmed fixed Icefaces 4 trunk, Icefaces ee-3.3.0 maintenance branch r40818. All browsers.

        Show
        Liana Munroe added a comment - Confirmed fixed Icefaces 4 trunk, Icefaces ee-3.3.0 maintenance branch r40818. All browsers.
        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: