ICEfaces
  1. ICEfaces
  2. ICE-9534

Make showcase ACE DataTable cell selection sample use simplified EL

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      showcase
    • Assignee Priority:
      P2
    • Affects:
      Sample App./Tutorial

      Description

      The EL we're using for the showcase ACE DataTable Selection sample's cell selection interface uses method calling, which isn't supported by older EL, such as that provided in Tomcat 6. We need to code to a lowest common denominator in our sample app.

        Activity

        Hide
        Mark Collette added a comment -

        Replaced the Map usage and EL method invocations with a List of a custom object type, and replaced the dynamic DataTable Column value evaluation with a static evaluation of the 'Car' data type. Propagated the comma delimited list EL into the row selection so it will now match the cell selection.

        Was originally going to use a cached List, that would only get cleared on cell selection events, but since we support a mode without ace:ajax, there was no event for the full form submit of deferred cell selections, so just re-build the List on every access, like the Map code used to do. Caching would be simpler if there was an easy way to detect different lifecycles from a getter method, instead of having to wire up a PhaseListener.

        icefaces3 trunk
        Subversion 37461

        Show
        Mark Collette added a comment - Replaced the Map usage and EL method invocations with a List of a custom object type, and replaced the dynamic DataTable Column value evaluation with a static evaluation of the 'Car' data type. Propagated the comma delimited list EL into the row selection so it will now match the cell selection. Was originally going to use a cached List, that would only get cleared on cell selection events, but since we support a mode without ace:ajax, there was no event for the full form submit of deferred cell selections, so just re-build the List on every access, like the Map code used to do. Caching would be simpler if there was an easy way to detect different lifecycles from a getter method, instead of having to wire up a PhaseListener. icefaces3 trunk Subversion 37461
        Hide
        Carmen Cristurean added a comment -

        In showcase > dataTable > Selection demo: selected rows/cells cannot be submitted in non-ajax mode; button to submit selections is not enabled when 'Instant Status Update via Ajax' check box is deselected.

        Show
        Carmen Cristurean added a comment - In showcase > dataTable > Selection demo: selected rows/cells cannot be submitted in non-ajax mode; button to submit selections is not enabled when 'Instant Status Update via Ajax' check box is deselected.
        Hide
        Arturo Zambrano added a comment -

        Committed fix at revision 38226. Simply fixed the markup.

        Show
        Arturo Zambrano added a comment - Committed fix at revision 38226. Simply fixed the markup.
        Hide
        Arturo Zambrano added a comment -

        Committed backport to 3.3 EE maintenance branch at revision 40806.

        Show
        Arturo Zambrano added a comment - Committed backport to 3.3 EE maintenance branch at revision 40806.
        Hide
        Liana Munroe added a comment -

        Confirmed fixed Icefaces 4 trunk, Icefaces ee-3.3.0 maintenance branch r40818. All browsers.

        Show
        Liana Munroe added a comment - Confirmed fixed Icefaces 4 trunk, Icefaces ee-3.3.0 maintenance branch r40818. All browsers.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Mark Collette
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: