ICEfaces
  1. ICEfaces
  2. ICE-9528

ace:dataTable > Pinned Columns Lose Styling When Styled Via rowStyleClass

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA, 4.0.BETA
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces3 trunk revision# 37447
      ICEfaces-ee-3.3.0.GA_P01 tag revision# 37450
      All browsers
    • Assignee Priority:
      P2

      Description

      When columns are pinned in a dataTable that uses the rowStyleClass attribute the columns loose all applied styling. See screenshot.

        Issue Links

          Activity

          Cruz Miraback created issue -
          Cruz Miraback made changes -
          Field Original Value New Value
          Attachment screenshot-1.jpg [ 16382 ]
          Ken Fyten made changes -
          Assignee Nils Lundquist [ nils.lundquist ]
          Fix Version/s 3.4 [ 10770 ]
          Assignee Priority P2 [ 10011 ]
          Ken Fyten made changes -
          Fix Version/s 4.0 [ 10770 ]
          Hide
          Carmen Cristurean added a comment -

          This is still an issue with IF4 trunk rev# 39869, in all browsers (tested with FF26, Chrome32, IE10).
          Also, if decreasing the size of the browser window and then maximize it, the table header becomes stretched to the left side of the table as in attached image (chrome-rev39869.png).

          Show
          Carmen Cristurean added a comment - This is still an issue with IF4 trunk rev# 39869, in all browsers (tested with FF26, Chrome32, IE10). Also, if decreasing the size of the browser window and then maximize it, the table header becomes stretched to the left side of the table as in attached image (chrome-rev39869.png).
          Carmen Cristurean made changes -
          Attachment chrome-rev39869.PNG [ 16662 ]
          Ken Fyten made changes -
          Fix Version/s 4.1 [ 11375 ]
          Ken Fyten made changes -
          Assignee Nils Lundquist [ nils.lundquist ]
          Ken Fyten made changes -
          Summary ace:dataTable > Pinned Columns Loose Styling When Styled Via rowStyleClass ace:dataTable > Pinned Columns Lose Styling When Styled Via rowStyleClass
          Ken Fyten made changes -
          Link This issue blocks ICE-8888 [ ICE-8888 ]
          Hide
          Carmen Cristurean added a comment -

          This issue has been found also with EE-3.3.0-maintenance branch # 40474 (all browsers):
          1) Column Pinning
          Columns become miss-aligned after pinning/un-pinning columns followed by re-sizing the window.
          2) Dynamic Row Styling via rowStyle Attribute
          Columns become misaligned after pinning/un-pinning columns.

          Show
          Carmen Cristurean added a comment - This issue has been found also with EE-3.3.0-maintenance branch # 40474 (all browsers): 1) Column Pinning Columns become miss-aligned after pinning/un-pinning columns followed by re-sizing the window. 2) Dynamic Row Styling via rowStyle Attribute Columns become misaligned after pinning/un-pinning columns.
          Ken Fyten made changes -
          Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
          Fix Version/s 4.0 [ 11382 ]
          Fix Version/s 4.1 [ 11375 ]
          Ken Fyten made changes -
          Assignee Arturo Zambrano [ artzambrano ]
          Hide
          Arturo Zambrano added a comment -

          It's tricky to apply a row style class to pinned columns. When a column is pinned, it becomes absolute positioned, and since absolute positioning allows us to remove an element from the typical flow, CSS styles and classes are not inherited. That's the same reason why pinned columns aren't highlighted when hovering over the row.

          A possible solution that has already been tested is to temporarily set the rowStyle class to all pinned table cells. So far, this works for preserving the rowStyle class, but it overrides the hover highlight.

          Show
          Arturo Zambrano added a comment - It's tricky to apply a row style class to pinned columns. When a column is pinned, it becomes absolute positioned, and since absolute positioning allows us to remove an element from the typical flow, CSS styles and classes are not inherited. That's the same reason why pinned columns aren't highlighted when hovering over the row. A possible solution that has already been tested is to temporarily set the rowStyle class to all pinned table cells. So far, this works for preserving the rowStyle class, but it overrides the hover highlight.
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #40913 Thu May 01 15:34:17 MDT 2014 art.zambrano ICE-9528 applied rowStyleClass and hover state class to child td elements of a row tr element
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRowRenderer.java
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Hide
          Arturo Zambrano added a comment -

          Committed fix to 4.0 trunk at revision 40913 and to 3.3 EE maintenance branch at revision 40912. Applied the rowStyleClass classes and the hover state class to the child td elements of a row tr element.

          Show
          Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 40913 and to 3.3 EE maintenance branch at revision 40912. Applied the rowStyleClass classes and the hover state class to the child td elements of a row tr element.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Carmen Cristurean added a comment -

          Verified with EE-3.3.0-maintenance # 40944 and IF4 trunk # 40946 in FF28, IE10, Chrome34.

          Show
          Carmen Cristurean added a comment - Verified with EE-3.3.0-maintenance # 40944 and IF4 trunk # 40946 in FF28, IE10, Chrome34.
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Cruz Miraback
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: