Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.0.BETA
-
Fix Version/s: 4.0
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ACE
-
Assignee Priority:P1
Description
Our first step needs to be to take all the components that already use lazy initialise, and integrate that to work with ice.ace.instance, as the switch to lazy init had meant that one couldn't count on accessing their widgetVar.
Issue Links
- depends on
-
ICE-8475
Implement client instance look up mechanism for the ace:dataTable
-
- Closed
-
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
r41525: Committed fix to show dialog when visible=true.
Since ace:dialog is not lazily initialized, it was necessary to add a call to the show() function when visible=true, so that the component gets initialized right away and displayed. This fixes both issues above.
Issue 1) is partially resolved only, as the ace:dialog opens up now however the inputText is missing the focus (Chrome35/ rev.41525).
Issue 2) is resolved.
r41527: wrapped input focus function inside a timeout function, in order to allow the child components to be loaded first before applying focus to them.
This fixes issue #1 above.
Re-opening this JIRA because of the following regressions in showcase (Icefaces 4 trunk rev. 41557/all browsers):
messages/ textEntry/ textAreaEntry (all browsers)
> All: demos are not functional: messages are not rendered when tabbing through without text being entered; when tabbing through after typing text, the focus jumps back to the input entry at the end of the typed text (no errors seen).
Steps:
- type at least one character in one of the inputs.
- press Tab - > focus is initially visible on the next input entry, but it goes back to the first input entry, at the end of the typed text.
The last issues reported are not caused by this fix. They became visible after the changes made for ICE-10100. More information can be found on that JIRA.
Committed new feature at revision 38540. Modified core.js to initialize lazy init components when calling ice.ace.instance so an object reference can be obtained for lazy init components as well.
The way this was made was by adding a global object ice.ace.lazy.registry to register all lazy init components on the page. They keys of this object are client ids, and the values are functions that call ice.ace.lazy(). So, when calling ice.ace.instance, the registry is checked to see if there's a registered lazy init component. In such case, the component is initialized before returning the object reference. The component is removed from the registry as well.
The only components using ice.ace.lazy at the moment are ace:checkboxButton, ace:linkButton, ace:pushButton, and ace:tableconfigPanel. The first three were adjusted to this change. As for ace:tableconfigPanel, it doesn't expose a client API, so no adjustment was made in this case.
Other components that could now be made lazy init include the following: