ICEfaces
  1. ICEfaces
  2. ICE-9499

Revamp required/optional styling in showcase to not conflict with themeroller error styling

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.3
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: Sample Apps
          • Labels:
            None
          • Environment:
            showcase
          • Assignee Priority:
            P1
          • Affects:
            Sample App./Tutorial

            Description

            When demonstrating the ACE components' functionality of required and optional, there is some application specified background colour styling (aqua, yellow, red, green) where the red styling interferes with the red foreground text colouring to make the text invisibly red on red. ace:textEntry and ace:textAreaEntry's Required Styling sections break from the aqua/yellow colouring to use red/green colouring, which causes problems. Other components' samples might have a similar problem.

            This became evident when we fixed some CSS ordering issues.

              Activity

              Ascending order - Click to sort in descending order
              Mark Collette created issue -
              Mark Collette made changes -
              Field Original Value New Value
              Assignee yip.ng [ yip.ng ]
              Fix Version/s 3.4 [ 10770 ]
              Assignee Priority P2 [ 10011 ]
              Mark Collette made changes -
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Mark Collette made changes -
              Assignee yip.ng [ yip.ng ] Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37366 Mon Aug 12 12:10:01 MDT 2013 art.zambrano ICE-9499 changed required/optional styling to only affect the border and not the background of the input fields
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/override_header.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/showcase_styles.css
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed changes in required/optional styling at revision 37366.

              This summarizes the changes made:

              • The background colours of the input fields are no longer styled by the application, leaving them to use the default theme background.
              • The border colours are now modified by the application to indicate required, optional, and error statuses.
              • Borders were made thicker (2px) to make the colours more noticeable.
              • When there's a validation error, the border is made even thicker (3px) and the colour more intense.
              • The colour palette was modified as well. Now, we only use "web colours". Required styling colours are more intense than optional styling colours. The default optional colour is no longer yellow, since yellow wasn't very noticeable as a border colour; it was changed to gray to communicate that the field is not particularly important.

              These changes play well with all of our pre-packaged Themeroller themes, as well as sam and rime.

              The situation described in this JIRA was present in all text input components, not only ace:textEntry and ace:textAreaEntry.

              Show
              Arturo Zambrano added a comment - Committed changes in required/optional styling at revision 37366. This summarizes the changes made: The background colours of the input fields are no longer styled by the application, leaving them to use the default theme background. The border colours are now modified by the application to indicate required, optional, and error statuses. Borders were made thicker (2px) to make the colours more noticeable. When there's a validation error, the border is made even thicker (3px) and the colour more intense. The colour palette was modified as well. Now, we only use "web colours". Required styling colours are more intense than optional styling colours. The default optional colour is no longer yellow, since yellow wasn't very noticeable as a border colour; it was changed to gray to communicate that the field is not particularly important. These changes play well with all of our pre-packaged Themeroller themes, as well as sam and rime. The situation described in this JIRA was present in all text input components, not only ace:textEntry and ace:textAreaEntry.
              Hide
              Permalink
              Arturo Zambrano added a comment - - edited

              Committed changes at revision 37420 and 37421:

              • Restricted required/optional styling to only Required Styling demos and to Overview textEntry and textAreaEntry demos.
              • Added 'None (Use theme)' checkbox in Required Styling demos (autoCompleteEntry, comboBox, dateTimeEntry, maskedEntry, selectMenu, simpleSelectOneMenu, textEntry, textAreaEntry).
              • Expanded explanation in Required Styling demos.
              • Added background and text colours to error classes.
              Show
              Arturo Zambrano added a comment - - edited Committed changes at revision 37420 and 37421: Restricted required/optional styling to only Required Styling demos and to Overview textEntry and textAreaEntry demos. Added 'None (Use theme)' checkbox in Required Styling demos (autoCompleteEntry, comboBox, dateTimeEntry, maskedEntry, selectMenu, simpleSelectOneMenu, textEntry, textAreaEntry). Expanded explanation in Required Styling demos. Added background and text colours to error classes.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37420 Thu Aug 15 09:44:29 MDT 2013 art.zambrano ICE-9499 restricted required/optional styling to only Overview and Required Styling demos; added 'None (Use theme)' checkbox in Required Styling demos; added background and text colours to error classes
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/maskedEntry/maskedIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/combobox/ComboBoxReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textEntry/textEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/showcase_styles.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/textEntry/TextEntryReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/autocompleteentry/AutoCompleteEntryReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/selectmenu/SelectMenuReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/date/DateReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/simpleselectonemenu/SimpleSelectOneMenuReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/simpleselectonemenu/simpleSelectOneMenuIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/selectmenu/selectMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/simpleselectonemenu/simpleSelectOneMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datereqstyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/selectmenu/selectMenuIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/maskedEntry/maskedReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/textAreaEntry/TextAreaEntryReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/override_header.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textEntry/textEntryIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/autocompleteentry/autoCompleteEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textEntry/textEntryLabel.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textAreaEntry/textAreaEntryLabel.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/dateindicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/autocompleteentry/autoCompleteEntryIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/maskedEntry/MaskedReqStyleBean.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textAreaEntry/textAreaEntryIndicator.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textAreaEntry/textAreaEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/example/ace/chart/ChartExportBean.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37421 Thu Aug 15 10:00:08 MDT 2013 art.zambrano ICE-9499 expanded explanation in Required Styling demos
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37441 Mon Aug 19 14:24:06 MDT 2013 art.zambrano ICE-9499 changed demo explanation and removed 'Default' option from required styling demos
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/maskedEntry/maskedReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textAreaEntry/textAreaEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/autocompleteentry/autoCompleteEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/resources/org/icefaces/samples/showcase/view/resources/messages.properties
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textEntry/textEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/simpleselectonemenu/simpleSelectOneMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/selectmenu/selectMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/showcase_styles.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datereqstyle.xhtml
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37442 Mon Aug 19 15:14:43 MDT 2013 art.zambrano ICE-9499 added CSS source pane to required styling demos
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/maskedEntry/maskedReqStyle.xhtml
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/reqStyleCss.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/ice.samples.showcase/override_header.css
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textAreaEntry/textAreaEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/combobox/comboBoxReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/autocompleteentry/autoCompleteEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/textEntry/textEntryReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/simpleselectonemenu/simpleSelectOneMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/selectmenu/selectMenuReqStyle.xhtml
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/examples/ace/date/datereqstyle.xhtml
              Hide
              Permalink
              Ken Fyten added a comment -

              The final set of changes to remove the "default" entry from the custom style color list and the addition of the CSS viewer look good. Marking resolved.

              Show
              Ken Fyten added a comment - The final set of changes to remove the "default" entry from the custom style color list and the addition of the CSS viewer look good. Marking resolved.
              Ken Fyten made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Affects Sample App./Tutorial [ 10001 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Mark Collette
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: