Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.3
-
Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
-
Component/s: None
-
Labels:None
-
Environment:ICEfaces
-
Assignee Priority:P2
Description
onElementUpdate feature needs an clean old DOM when it tries to find the elements that have to have their callbacks invoked. To have a clean old DOM we currently clone the entire DOM since later on the original old DOM modified by the subtree rendering process.
Instead, we could clone just the yet to be modified DOM trees and have the subtree rendering process work with them. The onElementUpdate feature will be free to use the old DOM as it is (unmodified). Hopefully this can save some memory and processing time since we need to clone fewer elements.
Instead, we could clone just the yet to be modified DOM trees and have the subtree rendering process work with them. The onElementUpdate feature will be free to use the old DOM as it is (unmodified). Hopefully this can save some memory and processing time since we need to clone fewer elements.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Mircea Toma [ mircea.toma ] |
| Fix Version/s | 3.4 [ 10770 ] |
| Affects Version/s | 3.3 [ 10370 ] |
| Assignee Priority | P2 [ 10011 ] |
Modified DOMPartialViewContext to capture all the subtree modification of the document and then apply them at the end of the process to the old document. The result is a proper new document that can be used for the next partial render cycle.
The change also got rid of the document cloning, now only the new subtrees need to be imported into the old document and have Element.setIdAttribute invoked on the ID-ed elements.
Show
Mircea Toma
added a comment - - edited Modified DOMPartialViewContext to capture all the subtree modification of the document and then apply them at the end of the process to the old document. The result is a proper new document that can be used for the next partial render cycle.
The change also got rid of the document cloning, now only the new subtrees need to be imported into the old document and have Element.setIdAttribute invoked on the ID-ed elements.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #37337 | Thu Aug 08 11:48:02 MDT 2013 | mircea.toma | |
| Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
MODIFY
/icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java
|
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #37339 | Thu Aug 08 12:06:15 MDT 2013 | mircea.toma | |
| Files Changed | ||||
|
MODIFY
/icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
|
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Fix Version/s | EE-3.3.0.GA_P02 [ 11371 ] |
Back-ported fixes.
Show
Mircea Toma
added a comment - Back-ported fixes.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Fix Version/s | 4.0 [ 11382 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
What is the reason for clearing the old DOM fragment corresponding to the rendered component subtree? Why not just pass into the diff process a new document as the new DOM fragment and use the unmodified old DOM to lookup the old DOM fragment?