Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-3.3.0.GA
-
Fix Version/s: EE-3.3.0.GA_P01, 4.0.BETA, 4.0
-
Component/s: Framework, ICE-Components
-
Labels:None
-
Environment:Compat themes
-
Assignee Priority:P1
Description
Using both ICEfaces EE 3.3.0.GA and current trunk, PanelTabSet background images that comes from rime.css are broken links. Reproduced with Mojarra 2.2 and 2.1.23, and MyFaces.
In this file we link to the rime.css file:
icefaces3/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
Using this component:
<h:outputStylesheet library="ice.compat" name="rime/rime.css"/>
Which renders this output:
<link type="text/css" rel="stylesheet" href="/showcase/javax.faces.resource/rime/rime.css.jsf?ln=ice.compat&v=3_4_0_130712">
The rime.css image links are of this form:
'../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
Which resolve to this in the browser:
http://localhost:8080/showcase/javax.faces.resource/xmlhttp/css/rime/css-images/Tab_LftTop.gif
In this file we link to the rime.css file:
icefaces3/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
Using this component:
<h:outputStylesheet library="ice.compat" name="rime/rime.css"/>
Which renders this output:
<link type="text/css" rel="stylesheet" href="/showcase/javax.faces.resource/rime/rime.css.jsf?ln=ice.compat&v=3_4_0_130712">
The rime.css image links are of this form:
'../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
Which resolve to this in the browser:
http://localhost:8080/showcase/javax.faces.resource/xmlhttp/css/rime/css-images/Tab_LftTop.gif
Issue Links
- depends on
-
ICE-9338
Resource coalescing omitting fileentry.js
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
PanelTabSet background images that comes from rime.css are broken links with Mojarra 2.2 and 2.1.23, and MyFaces.
In this file we link to the rime.css file: icefaces3/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml Using this component: <h:outputStylesheet library="ice.compat" name="rime/rime.css"/> Which renders this output: <link type="text/css" rel="stylesheet" href="/showcase/javax.faces.resource/rime/rime.css.jsf?ln=ice.compat&v=3_4_0_130712"> The rime.css image links are of this form: '../xmlhttp/css/rime/css-images/Tab_LftTop.gif' Which resolve to this in the browser: http://localhost:8080/showcase/javax.faces.resource/xmlhttp/css/rime/css-images/Tab_LftTop.gif |
Using both ICEfaces EE 3.3.0.GA and current trunk, PanelTabSet background images that comes from rime.css are broken links. Reproduced with Mojarra 2.2 and 2.1.23, and MyFaces.
In this file we link to the rime.css file: icefaces3/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml Using this component: <h:outputStylesheet library="ice.compat" name="rime/rime.css"/> Which renders this output: <link type="text/css" rel="stylesheet" href="/showcase/javax.faces.resource/rime/rime.css.jsf?ln=ice.compat&v=3_4_0_130712"> The rime.css image links are of this form: '../xmlhttp/css/rime/css-images/Tab_LftTop.gif' Which resolve to this in the browser: http://localhost:8080/showcase/javax.faces.resource/xmlhttp/css/rime/css-images/Tab_LftTop.gif |
Inside of:
icefaces3/compat/core/src/main/resources/META-INF/resources/ice.compat/rime/rime.css
I tested changing all links of the form:
'../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
To:
'../../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
Testing with main-template.xhtml using either the newer h:outputStylesheet or the older ice:outputStyle, both gave valid image links.
Show
Mark Collette
added a comment - Inside of:
icefaces3/compat/core/src/main/resources/META-INF/resources/ice.compat/rime/rime.css
I tested changing all links of the form:
'../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
To:
'../../xmlhttp/css/rime/css-images/Tab_LftTop.gif'
Testing with main-template.xhtml using either the newer h:outputStylesheet or the older ice:outputStyle, both gave valid image links.
| Summary | Compat broken theme image links | Compat broken theme image links in CSS |
| Assignee | Mircea Toma [ mircea.toma ] | |
| Fix Version/s | EE-3.3.0.GA_P01 [ 11174 ] | |
| Fix Version/s | 3.4 [ 10770 ] | |
| Assignee Priority | P1 [ 10010 ] |
| Security | Private [ 10001 ] |
This is a regression caused by the commit for ICE-9338.
When merging the resources for the rendered views the list of ordered resources build off the dependency metadata. rime.css resource is not defined and thus the merging code skips its addition.
The fix makes sure to also add the unordered resources at the end of the list of merged resources.
Show
Mircea Toma
added a comment - This is a regression caused by the commit for ICE-9338 .
When merging the resources for the rendered views the list of ordered resources build off the dependency metadata. rime.css resource is not defined and thus the merging code skips its addition.
The fix makes sure to also add the unordered resources at the end of the list of merged resources.
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #36976 | Tue Jul 16 15:13:34 MDT 2013 | mircea.toma | |
| Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/CoalescingResourceHandler.java
|
| Fix Version/s | 4.0 [ 11382 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
==> This works:
<ice:outputStyle href="./xmlhttp/css/rime/rime.css" />
Which renders:
<link type="text/css" rel="stylesheet" href="./xmlhttp/css/rime/rime.css">
==> Trying different orderings of the servlets and servlet mappings didn't help. Likely, the ResourceServlet itself is delegating to the "/javax.faces.resource/" resource handling, which is taking precedence, so that the image links containing it will try to be served via regular JSF 2 resource handling, instead of the resource servlet's special handling.