[ICE-9416] Ensure all ICEfaces core and components use of hidden fields specify "autocomplete=false" to avoid Safari bug - ICEsoft JIRA Issue Tracker

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.3
Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
Component/s: ACE-Components, Bridge, ICE-Components
Labels:
None
Environment:
ICEfaces 3.x

Assignee Priority:
P2
Affects:

Compatibility/Configuration

Description

This turned out to be a rather strange bug: ~~ICE-9285~~

The problem is that Safari is applying autocomplete to our
ice.view and ice.window values resulting in old values being
used even though the page is refreshed. autocomplete is
now disabled for these hidden fields (autocomplete="off"),
but there could be other places in our code where hidden fields
behave strangely due to this (such as in components).

(I didn't test other browsers extensively -- Safari may be unusual
in its application of autocomplete to hidden fields.)

Task is to either audit all the source code to ensure that "autocomplete='off'" is specified for any hidden fields being used, or build in an automatic "autocomplete='off'" mechanism into the bridge, if feasible.

Activity

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#36643	Thu Jul 11 13:24:39 MDT 2013	mircea.toma	~~ICE-9416~~ Add autocomplete=off attribute to hidden input elements.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/sliderentry/SliderEntryRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tabset/tabset.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/panel/PanelRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/accordion/AccordionRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tableconfigpanel/TableConfigPanelRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/fileentry/fileEntry.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tree/TreeRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/gmap/GMapAutocompleteRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/list/ListRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/tabset/TabSetProxy.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#36642	Thu Jul 11 13:10:52 MDT 2013	mircea.toma	~~ICE-9416~~ Add autocomplete=off attribute to hidden input elements.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/application.js MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/submit.js

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#36641	Thu Jul 11 13:06:54 MDT 2013	mircea.toma	~~ICE-9416~~ Add autocomplete=off attribute to hidden input elements.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/menupopup/MenuPopupRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/gmap/GMapRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelpopup/PanelPopupRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/tree/TreeRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelconfirmation/PanelConfirmationRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/GroupRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/HiddenRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/panelcollapsible/PanelCollapsibleRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/FormRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/paneldivider/PanelDividerRenderer.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/renderkit/dom_html_basic/TableRenderer.java

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#36640	Thu Jul 11 12:54:56 MDT 2013	mircea.toma	~~ICE-9416~~ Add autocomplete=off attribute to hidden input elements.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/FormSubmit.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/NavigationNotifier.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/DefaultAction.java MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/submit.js

People

Assignee:

Mircea Toma

Reporter:

Ken Fyten

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

10/Jul/13 10:58 AM

Updated:

14/Nov/14 5:18 PM

Resolved:

12/Dec/13 10:51 AM