Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
-
Component/s: ICE-Components
-
Labels:None
-
Environment:Compat components
-
Assignee Priority:P1
-
ICEsoft Forum Reference:
Description
As reported in the forum, this renderer uses instance fields that they read from and write to during rendering:
- SelectInputTextRenderer
Additionally, auditing found a problem with:
- OutputStyleRenderer
Renderers are application scoped, and can be used simultaneously by different requests / lifecycles. They should never use instance fields that are written to and then read from during a discrete render, since the same Renderer instance is used across threads for different views and users.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | ICE Renderers have thrread unsafe instance field | ICE Renderers have thread unsafe instance field |
| Assignee | Mark Collette [ mark.collette ] |
| Assignee Priority | P1 [ 10010 ] |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
No Issues found in IE7 & 9, FF 3.6 or Chrome
WebSphere Application Server 8.x doesn't like the FacesContext.getInstance() invocation in a static context:
private static final String ID_SUFFIX = UINamingContainer.getSeparatorChar(FacesContext.getCurrentInstance()) + "j_idcl";
This either needs to be a non-static, or the assignment needs to be done on a JSF thread in a non-static context.
| Resolution | Fixed [ 1 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
See ICE-7772 for additional info.
Sending icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
Transmitting file data .
Committed revision 36439.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #36439 | Thu Jun 27 14:43:06 MDT 2013 | jack.van.ooststroom | Fixed JIRA |
| Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/selectinputdate/SelectInputDateRenderer.java
|
As ID_SUFFIX needs to be and static and final as a class member, I removed the class member altogether and replaced the two references to it with the actual code. Marking this one as FIXED again.
| Status | Reopened [ 4 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Works on Tomcat7, IE 8, FF21, build 24
| Fix Version/s | 4.0 [ 11382 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Only these two were actually broken:
icefaces3/compat/components/src/main/java/com/icesoft/faces/component/style/OutputStyleRenderer.java
browserSpecificFilename
/Users/mark/Documents/ICEsoft/trunk/icefaces3/compat/components/src/main/java/com/icesoft/faces/component/selectinputtext/SelectInputTextRenderer.java
domUpdateMap
The rest were ones that were alright but failed the stringent test set by
ICE-9358.icefaces3 trunk
Subversion 36235
icefaces EE 3.3 branch tag
Subversion 36240