Details
Description
After fixing ICE-9331, it became apparent that similar problems could occur when coalescing custom application resources. The error was produced because a source file, that didn't end with a blank line and whose last statement didn't end with a semi-colon, was being concatenated immediately before another resource file, without inserting any characters in between, so the final result contained a syntax error, which was preventing the browser from interpreting the rest of the coalesced resource, causing undefined/"not found" type of errors.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might ignore this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might ignore this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors.
Activity
Arturo Zambrano
created issue -
Arturo Zambrano
made changes -
Field | Original Value | New Value |
---|---|---|
Description |
After fixing ICE-9331, it became apparent that similar problems could occur when coalescing custom application resources. The error was produced because a source file, that didn't end with a blank line and its last statement didn't end with a semi-colon, was being concatenated immediately before another resource file, without inserting any characters in between, so the final result contained a syntax error, which was preventing the browser from interpreting the rest of the coalesced resource.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might foresee this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors. |
After fixing ICE-9331, it became apparent that similar problems could occur when coalescing custom application resources. The error was produced because a source file, that didn't end with a blank line and whose last statement didn't end with a semi-colon, was being concatenated immediately before another resource file, without inserting any characters in between, so the final result contained a syntax error, which was preventing the browser from interpreting the rest of the coalesced resource, causing undefined/"not found" type of errors.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might foresee this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors. |
Ken Fyten
made changes -
Fix Version/s | 3.4 [ 10770 ] |
Arturo Zambrano
made changes -
Description |
After fixing ICE-9331, it became apparent that similar problems could occur when coalescing custom application resources. The error was produced because a source file, that didn't end with a blank line and whose last statement didn't end with a semi-colon, was being concatenated immediately before another resource file, without inserting any characters in between, so the final result contained a syntax error, which was preventing the browser from interpreting the rest of the coalesced resource, causing undefined/"not found" type of errors.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might foresee this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors. |
After fixing ICE-9331, it became apparent that similar problems could occur when coalescing custom application resources. The error was produced because a source file, that didn't end with a blank line and whose last statement didn't end with a semi-colon, was being concatenated immediately before another resource file, without inserting any characters in between, so the final result contained a syntax error, which was preventing the browser from interpreting the rest of the coalesced resource, causing undefined/"not found" type of errors.
While we could make sure to end all of our code with semi-colons (many function declarations are not doing this, perhaps because they already end with a closing curly bracket), many custom application source files, created by app developers, might ignore this rule, which could cause errors like the ones described in ICE-9331. So, it would be advisable to insert a blank line between each coalesced (concatenated) resource to prevent this kind of errors. |
Ken Fyten
made changes -
Assignee | Mircea Toma [ mircea.toma ] | |
Priority | Major [ 3 ] | Minor [ 4 ] |
Assignee Priority | P2 [ 10011 ] | |
Component/s | Framework [ 10013 ] | |
Component/s | ACE-Components [ 10050 ] |
Mircea Toma
made changes -
Status | Open [ 1 ] | Resolved [ 5 ] |
Resolution | Fixed [ 1 ] |
Repository | Revision | Date | User | Message |
ICEsoft Public SVN Repository | #36644 | Thu Jul 11 13:29:18 MDT 2013 | mircea.toma | |
Files Changed | ||||
MODIFY
/icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/application/CoalescingResource.java
|
Ken Fyten
made changes -
Fix Version/s | 4.0 [ 11382 ] |
Ken Fyten
made changes -
Status | Resolved [ 5 ] | Closed [ 6 ] |
Inserting blank line in between coalesced resources.